From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60473C433F5 for ; Mon, 13 Sep 2021 15:42:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 24E66610A2 for ; Mon, 13 Sep 2021 15:42:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 24E66610A2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Xz8TrdTn42JrPxDI/E9sut7xysOfeB8sbV02iCAWDwg=; b=k9VvcPwdCyhhqP RdSW/KHILfZwOoIEFKmmcc0cjnpopVkr4ggy6we5uce7di8wJm4mxZ6Kg7YGpTvh3Uf6wtrmigrj1 AVX3b35CyYSnVDgfZccq56ORuffkhrhar5ieDRdmxr8vJnra9lms8QGjObuHXrVG7+iBtSL3lMY+l jR/JDSWI5JfHq9iPtzFAAtTuGuGRQXMkUop+zXQ3f90YiJnJbhAS3aqH+CYKPeGjeLs331kDMp7oV uKURBy5gCquigI9z9bv/LGRBvKjJBxDFfdiDN04BatGEsK7/yjOlZTQWuYtfdqP/ENGjCfHlXXB53 Bc4xBeje/1blFVx5kbBA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mPo4d-002DZI-2z; Mon, 13 Sep 2021 15:40:47 +0000 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mPo4Y-002DYC-Tb for linux-arm-kernel@lists.infradead.org; Mon, 13 Sep 2021 15:40:44 +0000 Received: by mail-pl1-x629.google.com with SMTP id w6so6092764pll.3 for ; Mon, 13 Sep 2021 08:40:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=C6MugQm2AwA23iHWdSlbbRK11qZ1TXFavSZy+irB8B8=; b=ZwSMY1AGALo5HMCCeOYe6N9GDXlWOvU5HL/36GKuyCdplCHiHl3LSeUn6H3EmUz+Al 2b9QcX9tQ/NpHwPEyBSFHX2sdzXNvk4LfuQwOez7uRzBfoK5zazieql7/npRVgw/jZ// OzByCDTqYpQXO4yV/5pEqabjD0AdsKp62ToR8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=C6MugQm2AwA23iHWdSlbbRK11qZ1TXFavSZy+irB8B8=; b=jp7h0YIaZ4k5+yVCmXsDSTLMcNGkIRFWjBSoDOjgBJXTa2GlQmzBYAvsvxvAXgCqgd LmH0Jxn84OWag0yz+qp0A/nmop7pRwWHdM1MiwHkTBgyUmwS5Qdsr82DdtvjtdwzbuY0 N/hJlgpedAh/jDAnX2UqEx38aevrgr3qFRrTOhIS+66NJ8VbvKaH39XnuQ5JcbE7+n7Z 3RH2xTjnX6cCnGRlwooz1l6NDvF83iRIjgeYZ1LovQ/o0AZSwUN22MnYu4i1rFni9hEf EXsALBSL0SniWmTGkVN9ylGDcfEb0S2sVm7sFgBiS/Us5yooOCJTL2OeBc8ESnrU+dxY jQGg== X-Gm-Message-State: AOAM5326Kx4hNHF+puKVDL4cu9lA8/v8SkzaHa+fIgZ+J88jCtEQJHT1 dWl4OpMzaYcDqYUmugQXBsd1Hw== X-Google-Smtp-Source: ABdhPJye3fuE3GC78as/7jM1tA/moe6HT7UfsXHS+EkXq5cr3ZUXfg/i1Ggzf+XRpoem5D8OC0UfJg== X-Received: by 2002:a17:902:bf07:b0:138:e32d:9f2e with SMTP id bi7-20020a170902bf0700b00138e32d9f2emr10766118plb.59.1631547642141; Mon, 13 Sep 2021 08:40:42 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id p24sm7427371pfh.136.2021.09.13.08.40.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Sep 2021 08:40:41 -0700 (PDT) Date: Mon, 13 Sep 2021 08:40:40 -0700 From: Kees Cook To: Ard Biesheuvel Cc: linux-arm-kernel@lists.infradead.org, Keith Packard , Russell King , Arnd Bergmann , Linus Walleij Subject: Re: [PATCH v4 1/5] gcc-plugins: arm-ssp: Prepare for THREAD_INFO_IN_TASK support Message-ID: <202109130840.3501BF22@keescook> References: <20210913104001.3043132-1-ardb@kernel.org> <20210913104001.3043132-2-ardb@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210913104001.3043132-2-ardb@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210913_084043_008780_30D8E73D X-CRM114-Status: GOOD ( 15.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 13, 2021 at 12:39:57PM +0200, Ard Biesheuvel wrote: > We will be enabling THREAD_INFO_IN_TASK support for ARM, which means > that we can no longer load the stack canary value by masking the stack > pointer and taking the copy that lives in thread_info. Instead, we will > be able to load it from the task_struct directly, by using the TPIDRURO > register which will hold the current task pointer when > THREAD_INFO_IN_TASK is in effect. This is much more straight-forward, > and allows us to declutter this code a bit while at it. > > Signed-off-by: Ard Biesheuvel Reviewed-by: Kees Cook -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel