From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF93FC433F5 for ; Mon, 13 Sep 2021 08:58:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8834061029 for ; Mon, 13 Sep 2021 08:58:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8834061029 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=M/7C21+c+dT3XnHGG6YB1Xn6TJeRA1UVkVO6CwqFi8g=; b=DN9iCRJ+9mOMUo G4SHQfRnjH9CIhpdiT1EPyQ0s2ydBU16MdwbpeLDQzIBWkOyBP0V5/yo0RJEhBHDPppENWhCs3h3n LtukwvlzI/gAC1ExTj5X3le5mwWQfdeOinVf2JOwcdj/bPNtKeVir2LD3ZEmN4jql3u4IzCNa8mYl hpRgsQxusjWTfxw9qWtnbfdtcHqThFj5pfVm8Tw/rnR6qoO7El2WQsuGoo7p7C2KZwLF7mQneC0Af Mht8oZt+vTZCNiqKYLzLBApf4uD1jtmedZXqWyEl2YMEZxLvd+9P3Hv3OC12Wx7dTD/xx1VRM3ekb liKVEdSB/JTvRGRDy1YA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mPhlZ-000ut7-DX; Mon, 13 Sep 2021 08:56:42 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mPhk5-000uI5-48 for linux-arm-kernel@lists.infradead.org; Mon, 13 Sep 2021 08:55:10 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CDCE96D; Mon, 13 Sep 2021 01:55:04 -0700 (PDT) Received: from e120937-lin (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3BC9D3F5A1; Mon, 13 Sep 2021 01:55:04 -0700 (PDT) Date: Mon, 13 Sep 2021 09:55:01 +0100 From: Cristian Marussi To: Adam Borowski Cc: Sudeep Holla , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] firmware: arm_scmi: fix build failure if ARM_SCMI_PROTOCOL=y VIRTIO=m Message-ID: <20210913085501.GA22275@e120937-lin> References: <20210912212725.11909-1-kilobyte@angband.pl> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210912212725.11909-1-kilobyte@angband.pl> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210913_015509_275737_72154135 X-CRM114-Status: GOOD ( 17.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Sep 12, 2021 at 11:27:25PM +0200, Adam Borowski wrote: > A "bool" for a subfeature doesn't force the dependency by itself. > > Signed-off-by: Adam Borowski > --- Hi Adam, thanks for this fix, BUT it was already spotted by LKP https://lore.kernel.org/linux-mm/202108151230.lcHk2Pkk-lkp@intel.com/ and a proposed fix is already queued on sudeep/for-next/scmi. https://git.kernel.org/pub/scm/linux/kernel/git/sudeep.holla/linux.git/commit/?h=for-next/scmi&id=7b4262378924a9985bc4c35ea015bd48dfe57792 I supposed it will picked up with the next 5.15 scmi fixes. Probably the original distribution list was a bit odd since I replied to the above original LKP mail recipients, apologies for this. Thanks, Cristian > drivers/firmware/arm_scmi/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/firmware/arm_scmi/Kconfig b/drivers/firmware/arm_scmi/Kconfig > index 7f4d2435503b..cca557bc625b 100644 > --- a/drivers/firmware/arm_scmi/Kconfig > +++ b/drivers/firmware/arm_scmi/Kconfig > @@ -68,7 +68,7 @@ config ARM_SCMI_TRANSPORT_SMC > > config ARM_SCMI_TRANSPORT_VIRTIO > bool "SCMI transport based on VirtIO" > - depends on VIRTIO > + depends on VIRTIO >= ARM_SCMI_PROTOCOL > select ARM_SCMI_HAVE_TRANSPORT > select ARM_SCMI_HAVE_MSG > help > -- > 2.33.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel