From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F222DC433EF for ; Tue, 14 Sep 2021 10:10:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BF121610A6 for ; Tue, 14 Sep 2021 10:10:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BF121610A6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8dDAOi7HhdVFjtpS2Wpu0+I6JWD0+1akdPg98PcOk8Y=; b=JbT9Dne0Mu6qAk QMh2veT7iQm2WsWQfqZODs4HqMOILUVMqjV2isRL0NFR0k6mRVdgAmsMk136eukhdKY1758K7Jcul Pxq1MUNO1SOZwrx1f2STQ/qejocpzI0w8Inde8YIXUUH6VE3UAlXf8aOorvgv5hDSY/G1BGdfPKiy 8kAMmitKjep8+eCR9RD9yS8/dGZtf+CAiP1698XbZhsBDNLs7Ht4uIXgu4Dyro538vSzthGlT5U8j zc4+Yw82gurLOfJ4H7NKY+fhLhjpi1aVVgKcXfPzqmGj0JKncW/hUJNTKv71UVe2F3D7UqiRQ3NG+ W95jVPQbOnYDcrMYGgyQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQ5N6-0059oH-W6; Tue, 14 Sep 2021 10:09:02 +0000 Received: from mail-pf1-x435.google.com ([2607:f8b0:4864:20::435]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQ5N1-0059m9-8F for linux-arm-kernel@lists.infradead.org; Tue, 14 Sep 2021 10:08:56 +0000 Received: by mail-pf1-x435.google.com with SMTP id x7so11683477pfa.8 for ; Tue, 14 Sep 2021 03:08:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=8xfW5n5lGYHVjHYEbwTg272CCVO8ZvflsK9NBrpkrL8=; b=SnNwn7UQ8QhZcGeDD0myjSpJ7z0VOD8lcXL+A4oGbNlWV0dzX/atBgXx/r4Glvvkbs fYSR6NP4moNEEX24Ry62rkXiJuDpLyPiD6gOqzoNKwpCRh+piuvmZYBKc51uOLIuT1cG S9vPVbBmBY2XvAB2chVphNaTjYMF2pMMmgYrs9DGMHcnGOu5AnU602gPxeMmXBjMCk1H NdZHpRk17CLU7mQ+1Eq2AfLAYdS7wq+S8xpQ7cQgppsLpTNRLF4Mo5ZZJewjZDLvu/tA EbIO+i2m4o/IO9ArY6gXKXstApZ/+bcDLL34I/uavVWnYCTh67rNUCOWez8oGU4fjvPi hhtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=8xfW5n5lGYHVjHYEbwTg272CCVO8ZvflsK9NBrpkrL8=; b=rPaoqRK913xsPwVPYTlQ7M5yb12MTx2hVXLAQT3YgL61lbCU4pSPZ9zCA0vX2tu6Jr lNjUvUQzgXUirEGkxHX9lOvlbSsd2r6jbg+RhJ6AaJ8hSleuey9zfnQtr3P+X0cm1CKe inT6MW8/vWpGPkWUGxW2d4cbpOuhEHvDrcXDlPLdmMnZtO9ZJPrkgHOLw8ZCHgTc8ylY gl36k6nm6AmGBRx/JvFCD0/ZLYyHsnHfiNPVD9FSH4MRKaIOHGa3Y2MbWI77Pur1+hwh m0qCetJgLiDPEiEi6jOOg/OuabQQ/LalVOdyFPiOxCT9hC7trFABLSXKmvXLpVKkipai XBvQ== X-Gm-Message-State: AOAM533jqBaQyVOl5T45ROx6SJB44NK7tjfRuQrq3AmPfr2/cjaHPk0B r0lVraHgtjTknfOUegEtGOR3IA== X-Google-Smtp-Source: ABdhPJyxxLqEAQTWjjzZxP89GKxIT19IHBKBS3aAHfouriHBRsZzMZaVmcusJD7X03+K1uKBye267g== X-Received: by 2002:a63:7045:: with SMTP id a5mr14635597pgn.404.1631614132722; Tue, 14 Sep 2021 03:08:52 -0700 (PDT) Received: from leoy-ThinkPad-X240s ([204.124.181.224]) by smtp.gmail.com with ESMTPSA id g9sm8012220pfh.13.2021.09.14.03.08.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Sep 2021 03:08:52 -0700 (PDT) Date: Tue, 14 Sep 2021 18:08:47 +0800 From: Leo Yan To: Suzuki K Poulose Cc: Mathieu Poirier , Mike Leach , Alexander Shishkin , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/2] coresight: Update comments for removing cs_etm_find_snapshot() Message-ID: <20210914100847.GD1538480@leoy-ThinkPad-X240s> References: <20210912125748.2816606-1-leo.yan@linaro.org> <20210912125748.2816606-3-leo.yan@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210914_030855_317883_C4223F28 X-CRM114-Status: GOOD ( 17.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 14, 2021 at 10:27:26AM +0100, Suzuki Kuruppassery Poulose wrote: [...] > > diff --git a/drivers/hwtracing/coresight/coresight-tmc-etr.c b/drivers/hwtracing/coresight/coresight-tmc-etr.c > > index d23c7690f29a..ce14eb83925c 100644 > > --- a/drivers/hwtracing/coresight/coresight-tmc-etr.c > > +++ b/drivers/hwtracing/coresight/coresight-tmc-etr.c > > @@ -1573,9 +1573,8 @@ tmc_update_etr_buffer(struct coresight_device *csdev, > > /* > > * In snapshot mode we simply increment the head by the number of byte > > - * that were written. User space function cs_etm_find_snapshot() will > > - * figure out how many bytes to get from the AUX buffer based on the > > - * position of the head. > > + * that were written. User space will figure out how many bytes to get > > + * from the AUX buffer based on the position of the head. > > */ > > if (etr_perf->snapshot) > > handle->head += size; > > > > > Thanks for the revised patch, I have queued both the patches. Cool, and thanks Suzuki! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel