From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D9DFC433F5 for ; Tue, 14 Sep 2021 18:16:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6E1FD60184 for ; Tue, 14 Sep 2021 18:16:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6E1FD60184 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=M7+tdoYSP9zgFlybax0sMT11309fZKBWOknMvRwfApE=; b=NPdem9mT+PUwrQ LCu/SBchpTNRUva1DJwQu+s1jNSFMkg2DDfxZxJskM1UqiacdavuaXVzZreCrpZofb3vtxxpDyKXa SIZgf0COEv+o1xYBmgdG/JRayeE5wOIdZ6FFiCkI9+FD7moU/KdK1JiLByQPA5Qe8ejoneO1qK4nX +eXFfh5bqHllNS9nrodXns8jxtN+mAup7bdR9L7DbllmpPRajpUe1cJz+mU+8+w9C47sj6DXxxOid /2gDQJuUqwaHHKBW98+z1u9tPINEc0f2Hytzzwwui9L6brH0jbtBjL+X2Sa0vXiT2UcvftEUIwOSM tZHdlx1AN7AJIlCgJdgw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQCwD-006hiN-Sg; Tue, 14 Sep 2021 18:13:47 +0000 Received: from mail-pf1-x42f.google.com ([2607:f8b0:4864:20::42f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQCW4-006bxp-Ip for linux-arm-kernel@lists.infradead.org; Tue, 14 Sep 2021 17:46:46 +0000 Received: by mail-pf1-x42f.google.com with SMTP id n30so21790pfq.5 for ; Tue, 14 Sep 2021 10:46:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=7UFM2ZEfyisKcjzE2kztorsuEGj60mmoqCDZgmBx5qk=; b=adISV1GzrtR3BVLqWylk7j+Nf0f9LohcT8NA2GxEC5o5Ir6X0Rf80NFfjWbiZ4MfIH ARLEjkxxSPs8mBEmc9VUj2WyjNFe0RkVCmXChHcxpVOh50a4gFrHiqvBH8BTPF2sT1jd aaLZPBnnrqTDq2NK/mwpYYUhvoXrF1JBe6706NdMEh8Iua+zLYFmVbYAU5GTw8bwA/dt di+mdi9j/bH5jgWOne9zkrkyVO32aegprpms/DaZkgojU9DnTvLT91RNBHstQRZS/ktF c4MOx8GF/wpcp/CSo05i1B66s/sOZBxxhFS/d0ZvSSStyIXEIXRE+t+8FKHmY81HfZ5E CcPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=7UFM2ZEfyisKcjzE2kztorsuEGj60mmoqCDZgmBx5qk=; b=nbJQk5uiiO6qn8jxqqugz3aptyfbujyYoFg6F2DyFikEm8vW8YRekv/EEZ6YfzfDSs PdOHDpEvtOJkxNckW5/ayCd7d21PlcF7xrzLwGZC9ni6gHbRYv5r9h3+5Da/+Pk6S05H DHmCxRvxOGeyB9OvNO0UbSDmTWPlxzfMwMbxUOlwAqPrx7g0u3aqNOOVpzcTR1xoB8rv wVhNFyAZiQrKodirWep0sKSiVhgbXLcrVEWvbNAMt2t7saW1exVjq1D5qZwB5Pm8yONo TIEdXiGtduF3Ar/+DyLz0Iqs8kZ27r8Vt0IX+M4ZVeaysVAkSAGKoeG08BKZ5ZTvZ+9p U+Bg== X-Gm-Message-State: AOAM530YDuNfTslVPH5C/zZEGPQErjR5jQMidmaYjkyvjln36Yfdyu6L f5zgyDawdILG894pdHZ5zcp7Gg== X-Google-Smtp-Source: ABdhPJzNx8VjnH2V9I2EnHJTuQp2w956w0/y+JiYMwH4mCa/ph7gOkFElD1jQd/qXlADKOpBI9CZjA== X-Received: by 2002:a63:da49:: with SMTP id l9mr16290385pgj.277.1631641602979; Tue, 14 Sep 2021 10:46:42 -0700 (PDT) Received: from p14s (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id pc3sm2354264pjb.0.2021.09.14.10.46.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Sep 2021 10:46:42 -0700 (PDT) Date: Tue, 14 Sep 2021 11:46:39 -0600 From: Mathieu Poirier To: Shengjiu Wang Cc: ohad@wizery.com, bjorn.andersson@linaro.org, robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, daniel.baluta@nxp.com, linux-imx@nxp.com, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, shengjiu.wang@gmail.com Subject: Re: [PATCH v4 1/4] remoteproc: imx_rproc: Move common structure to header file Message-ID: <20210914174639.GB1719994@p14s> References: <1631092255-25150-1-git-send-email-shengjiu.wang@nxp.com> <1631092255-25150-2-git-send-email-shengjiu.wang@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1631092255-25150-2-git-send-email-shengjiu.wang@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210914_104644_718690_8B67C8DB X-CRM114-Status: GOOD ( 22.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 08, 2021 at 05:10:52PM +0800, Shengjiu Wang wrote: > Move common structure imx_rproc_att, imx_rproc_method > and imx_rproc_dcfg to header file which can be shared with > imx_dsp_rproc driver. > > Signed-off-by: Shengjiu Wang > --- > drivers/remoteproc/imx_rproc.c | 28 +------------------------ > drivers/remoteproc/imx_rproc.h | 37 ++++++++++++++++++++++++++++++++++ > 2 files changed, 38 insertions(+), 27 deletions(-) > create mode 100644 drivers/remoteproc/imx_rproc.h > Reviewed-by: Mathieu Poirier > diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c > index d88f76f5305e..b0da0130c3b6 100644 > --- a/drivers/remoteproc/imx_rproc.c > +++ b/drivers/remoteproc/imx_rproc.c > @@ -19,6 +19,7 @@ > #include > #include > > +#include "imx_rproc.h" > #include "remoteproc_internal.h" > > #define IMX7D_SRC_SCR 0x0C > @@ -72,33 +73,6 @@ struct imx_rproc_mem { > /* M4 own area. Can be mapped at probe */ > #define ATT_OWN BIT(1) > > -/* address translation table */ > -struct imx_rproc_att { > - u32 da; /* device address (From Cortex M4 view)*/ > - u32 sa; /* system bus address */ > - u32 size; /* size of reg range */ > - int flags; > -}; > - > -/* Remote core start/stop method */ > -enum imx_rproc_method { > - IMX_RPROC_NONE, > - /* Through syscon regmap */ > - IMX_RPROC_MMIO, > - /* Through ARM SMCCC */ > - IMX_RPROC_SMC, > -}; > - > -struct imx_rproc_dcfg { > - u32 src_reg; > - u32 src_mask; > - u32 src_start; > - u32 src_stop; > - const struct imx_rproc_att *att; > - size_t att_size; > - enum imx_rproc_method method; > -}; > - > struct imx_rproc { > struct device *dev; > struct regmap *regmap; > diff --git a/drivers/remoteproc/imx_rproc.h b/drivers/remoteproc/imx_rproc.h > new file mode 100644 > index 000000000000..23d8e808d27f > --- /dev/null > +++ b/drivers/remoteproc/imx_rproc.h > @@ -0,0 +1,37 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +/* > + * Copyright (c) 2017 Pengutronix, Oleksij Rempel > + * Copyright 2021 NXP > + */ > + > +#ifndef _IMX_RPROC_H > +#define _IMX_RPROC_H > + > +/* address translation table */ > +struct imx_rproc_att { > + u32 da; /* device address (From Cortex M4 view)*/ > + u32 sa; /* system bus address */ > + u32 size; /* size of reg range */ > + int flags; > +}; > + > +/* Remote core start/stop method */ > +enum imx_rproc_method { > + IMX_RPROC_NONE, > + /* Through syscon regmap */ > + IMX_RPROC_MMIO, > + /* Through ARM SMCCC */ > + IMX_RPROC_SMC, > +}; > + > +struct imx_rproc_dcfg { > + u32 src_reg; > + u32 src_mask; > + u32 src_start; > + u32 src_stop; > + const struct imx_rproc_att *att; > + size_t att_size; > + enum imx_rproc_method method; > +}; > + > +#endif /* _IMX_RPROC_H */ > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel