From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAF58C433EF for ; Wed, 15 Sep 2021 16:28:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B844D60EB4 for ; Wed, 15 Sep 2021 16:28:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B844D60EB4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TZE4gXoaBKoTl3bqNJW/GeqtOFvmw0y6W7hjInEEaDY=; b=EREflspHdcFsxy DfO1dxgwZ3hBAA9JD7dCX89QRBVxpQGdkiKgoHuR8YlWq7UgN4F6S9JmTxhUBfgBhIYXviscyVxag oBuKnBZkbtYCUJuIud4cft1CsHzqBQ5yuRvhbudFtNiVNIydzwohdB8YSQ3k8ecwUQu1dZrx9ipSJ 1ca6YHHb8vbivzOgsaATiCi+vwZDsAYChuLXJN72kYq+CR6GQ4yHjmc5VIZceqyAehhCKGAKGyWlv FwNZp/tIHJ4GqLsZILlXXkKsEe8WrO4gO0UcyYlmHJBeqL7VT3weGeBK/ysVh0KArryKnntBLApnH +BcFcgShLYZN9is9C2WQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQXk6-009Xvh-Lg; Wed, 15 Sep 2021 16:26:38 +0000 Received: from mail-pf1-x42c.google.com ([2607:f8b0:4864:20::42c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQXk3-009Xv6-DE for linux-arm-kernel@lists.infradead.org; Wed, 15 Sep 2021 16:26:36 +0000 Received: by mail-pf1-x42c.google.com with SMTP id w19so3074887pfn.12 for ; Wed, 15 Sep 2021 09:26:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ih4ccONJXL/PbRgcG69Qj1KxFWhtsoZxz36rz8hjCjQ=; b=U8zlsDMZH1rY2fZRveIN+Oct6FrbVB+bvbRsK9kPFHc/YOyPrllDbjHNb4Qnl84HWY d4jBANSfXq3pZMU9eUfAQL9MlPD69cjcPtt0kygt2/n5k+sho2TJ65HbgzK8PqP3lcio 3qKz7mauBmpz6Xp9nR0XCoa5haiU6ScHLbQkU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ih4ccONJXL/PbRgcG69Qj1KxFWhtsoZxz36rz8hjCjQ=; b=wQjFQit2/b3odqrMj6h16xUJbE41bD0lVG6FdfOSl7mUvGU/+wqGkldg91nIR7vFEk 4+n3t/Sc7ULZPZpAOyYxvb2qsV2PVzrEfX7RSoeRXJtzaR3a7KDZfpl97Orba2OqPkvq y4HsYZVDi51LqH9poVp8Gc+yHEgV6xG0xJWYHv9zabR6DaFb0LjrO4bj08UySqJ2CzsZ qgrj6nomN3mIpw27PI1P2YdSIwGQiG7FGxFLd9w34Ie3Gco+Hemu71QqIYF31zjvX7XJ 72iWuYtmlb4UBazU7cAsPbFFhDfEeGNjk90miiMBp4kkgBmRQNlPU+iBoHAYLGsMaDMa YHjw== X-Gm-Message-State: AOAM533tLSWWP5sIrSWMexveTy1S8BHa25jt1/Ou6w/AnfWh5k+oqFma sPU5WpzzMlV8hhxHjwalMRf9Ng== X-Google-Smtp-Source: ABdhPJyVviu5tU+fHpwvs/8+rKhXARv6XJHR7R3hTfO0rSQD1ySPlMpaumXV7mGwa0Ay/CBxfy7hTg== X-Received: by 2002:aa7:9395:0:b0:438:9980:5c94 with SMTP id t21-20020aa79395000000b0043899805c94mr472307pfe.81.1631723194106; Wed, 15 Sep 2021 09:26:34 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id u194sm412964pfc.177.2021.09.15.09.26.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Sep 2021 09:26:33 -0700 (PDT) Date: Wed, 15 Sep 2021 09:26:32 -0700 From: Kees Cook To: Ard Biesheuvel Cc: Linus Walleij , Linux ARM , Keith Packard , Russell King , Arnd Bergmann , Neil Armstrong , Qing Zhao Subject: Re: [PATCH v4 1/5] gcc-plugins: arm-ssp: Prepare for THREAD_INFO_IN_TASK support Message-ID: <202109150902.448CA338B@keescook> References: <20210913104001.3043132-1-ardb@kernel.org> <20210913104001.3043132-2-ardb@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210915_092635_546291_D198E058 X-CRM114-Status: GOOD ( 23.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 15, 2021 at 08:37:44AM +0200, Ard Biesheuvel wrote: > On Wed, 15 Sept 2021 at 00:04, Linus Walleij wrote: > > > > Hi Ard, > > > > thanks for this patch series! > > > > On Mon, Sep 13, 2021 at 12:40 PM Ard Biesheuvel wrote: > > > > > config STACKPROTECTOR_PER_TASK > > > bool "Use a unique stack canary value for each task" > > > - depends on GCC_PLUGINS && STACKPROTECTOR && SMP && !XIP_DEFLATED_DATA > > > + depends on GCC_PLUGINS && STACKPROTECTOR && THREAD_INFO_IN_TASK && !XIP_DEFLATED_DATA > > > select GCC_PLUGIN_ARM_SSP_PER_TASK > > > > Am I reading this right that STACKPROTECTOR_PER_TASK > > was available for ARMv6 with SMP before this > > change and after this change it will only be available for > > ARMv7 since THREAD_INFO_IN_TASK which is now a dependency > > will only be available for ARMv7 (or ARMv6k)? > > > > Yes. We could potentially keep the old code path in the plugin as > well, but what I would really prefer to do is get > -mstack-protector-guard=tls implemented in GCC, so we can phase out > the plugin entirely. For tracking, I've added this for arm32 support: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102352 (And updated https://github.com/KSPP/linux/issues/29) -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel