From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7382DC433F5 for ; Thu, 16 Sep 2021 13:51:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 24EE160EB4 for ; Thu, 16 Sep 2021 13:51:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 24EE160EB4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yNWFVddtrCBQZg4h+oqdRqMhemAfAm7mXfYEHJWRBEw=; b=LRfoopIznobs6G+fxoB4kCgccI 7KWZzi5aQJtqSbFMbBP1Kty9RCqbgH4Oyl1+mjZpB5YiL/tFN6FCahYr6V+tdYn/cjp3YCy9RrtTn FWaOpGvtZIyxzp5YO2KnZmtVqa0mFDs/ujSlW1kZ0Jpe852VIbBvNtTgwczaFFk2wZH4FEkZ03C7t wPeE7nCLG05MUPp6k5RborrOJ7hw5eEpgOosTYw5nAmcYpMChtqwRzwtdz050XmfFHfWWQwD8f+v1 KpNM0vteA2eJquR4pd5FFr/QPWAacPOcA5+Z4ne3dNRc7ilp0jVxRRArhoab/qwe2MT5ofJHpC0l4 Xh9CP6qQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQrll-00BFFe-GQ; Thu, 16 Sep 2021 13:49:41 +0000 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQrlh-00BFEH-K4 for linux-arm-kernel@lists.infradead.org; Thu, 16 Sep 2021 13:49:38 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id F281832009A1; Thu, 16 Sep 2021 09:49:35 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 16 Sep 2021 09:49:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=hGTVPZFTMsORaX5yiAkxUoFb7lF s1xVmUrZXKC4Tl80=; b=2TxfP18c0sCp4qlaH7ELC8YOs/GELiQ9PFVvGHPOnOe Jsepbl3Z6AYjMRYqEsWXWuFVawpmw9eg9UTz+R3j+1XAKDgOh2krQiUgMTxwsX3x 728KnZwLVuvaF7oDoyt4vLXzsqrp2niSiVDJg3mOQp7TSngrXqg3BC0nRZika9Wu S/aQ1e2g4pFmqJ3nmX9Odz0NY4zDb/vDWKcxNXHxpK/2RYNMW6KlWcQYMdEhC7qn FBLiaQ4RWThuQVqkmWkBy0Z1I7a8Mw//hNGsicV+FlYVufvUlc9cWwtOEWt6HHHh 1FBlYQjxF6OczhLY1l1Y52IkVtCHls+8EnJDLw3a1jA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=hGTVPZ FTMsORaX5yiAkxUoFb7lFs1xVmUrZXKC4Tl80=; b=Y6JykOIqHJmeOZW1JYFlHU hoESyUgOnZZfrVbZm9t4TNgWbJDO4R1Ra66CzDDLsb2FdoJphcnCLZHij7MNVhty hxKkAu1tike17BhuF5l33+0hFukv8vzVrZUyEVxFjOrOKT9BaQJR/OjqkyHo1yVs pbncNPsssG0kni3PsR1KMHDAtY1MnoIsEdRUHzdu1LqKIEaz4VSyyy5MqFcLtYlS Vf0g+afLWFKScXRvN+PQCBVi191u+tEl1I7RenGqFNsb+tG5VUOP53Rw0vR/HNGU exVSnOTZHilRSlNB14xonyZl7TsMd9ydqmernpVL8+bdHA0TKzPUe6EqMNNSCfXQ == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudehgedgieegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepleekgeehhfdutdeljefgleejffehfffgieejhffgueefhfdtveetgeehieeh gedunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmh grgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 16 Sep 2021 09:49:33 -0400 (EDT) Date: Thu, 16 Sep 2021 15:49:32 +0200 From: Maxime Ripard To: Jernej Skrabec Cc: wens@csie.org, airlied@linux.ie, daniel@ffwll.ch, saravanak@google.com, megous@megous.com, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] drm/sun4i: dw-hdmi: Fix HDMI PHY clock setup Message-ID: <20210916134932.omo7uln7vgwuponn@gilmour> References: <20210915175836.3158839-1-jernej.skrabec@gmail.com> MIME-Version: 1.0 In-Reply-To: <20210915175836.3158839-1-jernej.skrabec@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210916_064937_708370_A09838FC X-CRM114-Status: GOOD ( 11.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============3918602364796237175==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============3918602364796237175== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="zoalnj333bw3b74u" Content-Disposition: inline --zoalnj333bw3b74u Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 15, 2021 at 07:58:36PM +0200, Jernej Skrabec wrote: > Recent rework, which made HDMI PHY driver a platform device, inadvertely > reversed clock setup order. HW is very touchy about it. Proper way is to > handle controllers resets and clocks first and HDMI PHYs second. >=20 > Currently, without this fix, first mode set completely fails (nothing on > HDMI monitor) on H3 era PHYs. On H6, it still somehow work. >=20 > Move HDMI PHY reset & clocks handling to sun8i_hdmi_phy_init() which > will assure that code is executed after controllers reset & clocks are > handled. Additionally, add sun8i_hdmi_phy_deinit() which will deinit > them at controllers driver unload. >=20 > Tested on A64, H3, H6 and R40. >=20 > Fixes: 9bf3797796f5 ("drm/sun4i: dw-hdmi: Make HDMI PHY into a platform d= evice") > Signed-off-by: Jernej Skrabec Applied, thanks Maxime --zoalnj333bw3b74u Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYUNLbAAKCRDj7w1vZxhR xZ1VAP97LhyfzDujhDpzpZoCr0Ek8Vrbmxn2TWjt+iqPJjmXJwD/ZfGocsWg01VQ TbwLRdd1aOIfVXtbQfCKOhuuV4nakg0= =XBvq -----END PGP SIGNATURE----- --zoalnj333bw3b74u-- --===============3918602364796237175== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============3918602364796237175==--