From: Nishanth Menon <nm@ti.com>
To: Sinthu Raja <sinthu.raja@mistralsolutions.com>
Cc: Ohad Ben-Cohen <ohad@wizery.com>,
devicetree@vger.kernel.org, Sinthu Raja <sinthu.raja@ti.com>,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Baolin Wang <baolin.wang7@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] dt-bindings: hwlock: omap: Remove board-specific compatible from DT example
Date: Fri, 17 Sep 2021 09:44:55 -0500 [thread overview]
Message-ID: <20210917144455.nj6bc2enytlgqmzn@studied> (raw)
In-Reply-To: <20210917094740.18891-1-sinthu.raja@ti.com>
On 15:17-20210917, Sinthu Raja wrote:
> From: Sinthu Raja <sinthu.raja@ti.com>
>
> The example includes a board-specific compatible property, this is
> wrong as the example should be board agnostic. Replace the same with a
> generic soc node.
>
> Fixes: d8db9dc34871 ("dt-bindings: hwlock: omap: Convert binding to YAML")
> Signed-off-by: Sinthu Raja <sinthu.raja@ti.com>
> ---
>
> This patch was triggered by discussions in [1].
>
> When applying the patch, if you could provide an immutable tag for the
> bindings, it would help line things up for new platforms to be added for
> us. See [2] for the context
Aah yes, thanks.. Bjorn.. once Rob acks ofcourse (since this is
bindings).
Reviewed-by: Nishanth Menon <nm@ti.com>
>
> [1] https://lore.kernel.org/all/20210818074030.1877-1-sinthu.raja@ti.com/
> [2] https://lore.kernel.org/linux-arm-kernel/20210125141642.4yybjnklk3qsqjdy@steersman/
>
> .../devicetree/bindings/hwlock/ti,omap-hwspinlock.yaml | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/hwlock/ti,omap-hwspinlock.yaml b/Documentation/devicetree/bindings/hwlock/ti,omap-hwspinlock.yaml
> index ae1b37dbee75..d56dc1bebdc6 100644
> --- a/Documentation/devicetree/bindings/hwlock/ti,omap-hwspinlock.yaml
> +++ b/Documentation/devicetree/bindings/hwlock/ti,omap-hwspinlock.yaml
> @@ -47,10 +47,8 @@ examples:
> };
>
> - |
> - / {
> + soc {
> /* K3 AM65x SoCs */
> - model = "Texas Instruments K3 AM654 SoC";
> - compatible = "ti,am654-evm", "ti,am654";
> #address-cells = <2>;
> #size-cells = <2>;
>
> --
> 2.32.0
>
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-09-17 14:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-17 9:47 [PATCH] dt-bindings: hwlock: omap: Remove board-specific compatible from DT example Sinthu Raja
2021-09-17 14:44 ` Nishanth Menon [this message]
2021-09-20 21:14 ` Suman Anna
2021-09-20 22:01 ` Bjorn Andersson
2021-09-22 21:00 ` Nishanth Menon
2021-09-17 15:12 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210917144455.nj6bc2enytlgqmzn@studied \
--to=nm@ti.com \
--cc=baolin.wang7@gmail.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=robh+dt@kernel.org \
--cc=sinthu.raja@mistralsolutions.com \
--cc=sinthu.raja@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox