From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 776DEC433F5 for ; Mon, 20 Sep 2021 16:25:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 455CC61163 for ; Mon, 20 Sep 2021 16:25:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 455CC61163 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=n/yBdgejVUn23W1hwiPNrEw275qlRq/54wQqQVHonQE=; b=okhaW4dbeLWV7x V1b+I92l2mNIBjVjiC7r98r38YonKYD7gUWTNE46QIOglc/JjsiAQnRYgvUnHs6+C2fTQ17iPPyKb Zouctw2nfnBswtjLKi5O7lEa58aa7hV9+jT9NYvkdnVUH1jtErqqOv6mjKNbj5Vq/9zP8H5NLIIS6 jKGWEZhVLU0QKKT/EKpfYOf+6NpgEpJ4oYEn7iZ/XoETXQ0xV9WAvbXgKrsAchCMMhWa2BgSyB/fx ByS42J2yPZuDCWZmY4Sta0UgG97lNd4rKqOUEUFsrZ+nDTPMtI1KamHcGa7V0/Sak7q5ejM21XHEK 88iNq3q2ISCFSyu9kIEg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSM5K-002Q7p-8R; Mon, 20 Sep 2021 16:24:02 +0000 Received: from mail-pf1-x42a.google.com ([2607:f8b0:4864:20::42a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSM5G-002Q6I-UG for linux-arm-kernel@lists.infradead.org; Mon, 20 Sep 2021 16:24:00 +0000 Received: by mail-pf1-x42a.google.com with SMTP id 203so8867193pfy.13 for ; Mon, 20 Sep 2021 09:23:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=bNaDFmzVv3uKPgKAqiQqJeFLc8FV9NeWINL4Lel0gO0=; b=b0pO9F7KxZdfy+vW9e/AF1J2CxXgi7bTOPPwUmpqOKwsmYQu2JrK2SDKY5lnXdSN6t 0f+qEjn+IDksJl75FTZnuq3Vlo9rVExKtfY+L5yr+S1TDwJUA0CQnPvzeum048IbTXce 2ok2uAVgzxTby5Xl3toVcqQt3JJIwwSRrzmg/hLzEJP4JWIzmlP3pP/V8LIURdcsdjII oKGh6My7P7DM69py7SaKWNKCUxD1qYv4g27xKHbze5PU6iL6CcpwMggveTWqGVvKzjxC 7TOj9aPwETWxc1mvjrxhDQ5M5sGXQd1AHLIOQvtZ0O945FhD/n9+PI5cYuLLMcCfQiYA MIkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=bNaDFmzVv3uKPgKAqiQqJeFLc8FV9NeWINL4Lel0gO0=; b=Oa/ybbcVvxqvhgV1dqBIe66j7q1awnxVJ1DMAy87rJD8miUPewFeCQeZLuxDzH1lzq qibGCcf03L2kQC0Io3i88T2Wp5bDpb800Q0KGS+vTh7DE21tz9/dd6YBIigAtZnIXJpZ rgKz2Pr+sQV8fQHEWPP7F/UDsmo3WlBb1Fj3u0JG950zBLrU5OqyYz8P13yWXOASAOJu HjzTVRY+TIX43i1BtMmV3ar0+bQnH1HranLJUgw8AvvrpszSaSm1e/TlnIGAWIXE+ZQm f4ZuGzsyFW6L0sfm7nw6++5xh5eY87hmhbHKZ8TvdKv+AR4Kz4VxneSIKlOScQoVp05R 6E0A== X-Gm-Message-State: AOAM5321gkqMDPmv+0zFwA0B8FemZqb4kt6AYjnDfoJPWQRhdk+VhP/Z RR0pR4vPFtz1+wbyu6oDTW0bKQ== X-Google-Smtp-Source: ABdhPJyoQVkhBTz7cZbF+5Gwl/g+ZNuJHTyIYkNbuUzIvtdIMoUaRelARr0HCZjzg9YMtLGBYupbXg== X-Received: by 2002:a62:1d4d:0:b0:443:eac2:8a1b with SMTP id d74-20020a621d4d000000b00443eac28a1bmr21576833pfd.2.1632155036924; Mon, 20 Sep 2021 09:23:56 -0700 (PDT) Received: from p14s (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id p24sm14593784pfh.136.2021.09.20.09.23.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Sep 2021 09:23:55 -0700 (PDT) Date: Mon, 20 Sep 2021 10:23:53 -0600 From: Mathieu Poirier To: "Peng Fan (OSS)" Cc: ohad@wizery.com, bjorn.andersson@linaro.org, o.rempel@pengutronix.de, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, aisheng.dong@nxp.com, Peng Fan , kernel test robot Subject: Re: [PATCH V4 1/6] remoteproc: elf_loader: fix loading segment when is_iomem true Message-ID: <20210920162353.GA2023964@p14s> References: <20210910090621.3073540-1-peng.fan@oss.nxp.com> <20210910090621.3073540-2-peng.fan@oss.nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210910090621.3073540-2-peng.fan@oss.nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210920_092359_011244_BE062998 X-CRM114-Status: GOOD ( 20.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 10, 2021 at 05:06:16PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > It seems luckliy work on i.MX platform, but it is wrong. > Need use memcpy_toio, not memcpy_fromio. > Lucky or not I just can't understand how this worked in the first place. > Fixes: 40df0a91b2a52 ("remoteproc: add is_iomem to da_to_va") SHA tag should be 12 characters. > Tested-by: Dong Aisheng (i.MX8MQ) > Reported-by: kernel test robot > Reported-by: Dong Aisheng > Signed-off-by: Peng Fan I will add a CC:stable, fix the title, fix the SHA and pick this patch. > --- > drivers/remoteproc/remoteproc_elf_loader.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/remoteproc/remoteproc_elf_loader.c b/drivers/remoteproc/remoteproc_elf_loader.c > index 469c52e62faff..44e7f9308f4bc 100644 > --- a/drivers/remoteproc/remoteproc_elf_loader.c > +++ b/drivers/remoteproc/remoteproc_elf_loader.c > @@ -220,7 +220,7 @@ int rproc_elf_load_segments(struct rproc *rproc, const struct firmware *fw) > /* put the segment where the remote processor expects it */ > if (filesz) { > if (is_iomem) > - memcpy_fromio(ptr, (void __iomem *)(elf_data + offset), filesz); > + memcpy_toio((void __iomem *)ptr, elf_data + offset, filesz); > else > memcpy(ptr, elf_data + offset, filesz); > } > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel