From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E8E2C433EF for ; Mon, 20 Sep 2021 17:01:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3CCCA61A8A for ; Mon, 20 Sep 2021 17:01:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3CCCA61A8A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=akqtvs1rH/E6XExA79KxDgsM2mZSgCot5WYEyn9JuCI=; b=YbC/HMf6O8ajAP U5HzCt/eaN+cFtY7NjpkXRi885NT2fr4tFJ8mR5RZ8mtnEn0xQnzPF/zpmJFthFiMgL/4WBbFdfj4 hC2iGYHd1YiF7TC173NRTfHhYLKXRkDi/yisJh06sQYyzdnKZIoWz3QH+sDHc5UqdJIVHDmJFfGq1 7CRJW3UYDKuOisMu+wJBWyeg0XGt4qUbPc286VWCqwJXc6nph2iSjqswmagGy/NQlHMB9S6WpmI2n m1N+SBMsYCzpR/1sQpjbCzO5gCoUQRZqcooy3MGUupsVvZhPvSORZNLqkuieGs6HEB+HmxSVtSC+2 sOC1cGnm8SKq4bfuQY/w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSMef-002VvG-Qn; Mon, 20 Sep 2021 17:00:34 +0000 Received: from mail-pj1-x102b.google.com ([2607:f8b0:4864:20::102b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSMeb-002VtZ-JZ for linux-arm-kernel@lists.infradead.org; Mon, 20 Sep 2021 17:00:31 +0000 Received: by mail-pj1-x102b.google.com with SMTP id t20so12420386pju.5 for ; Mon, 20 Sep 2021 10:00:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=kdjk66ClBUEHOQPo5O8pA1o0FV9ziXIRLgjji0kwuh4=; b=GXc/nby8oxLKc3PPElYjdztWj1YGfkAPflMMyus5Xe/wB3d+zdLugKfbLT7Pqwt5Ir XY4JI4IvuLuczzd2eZQJOugP9XQtnX7EGXplnW/Z6t5IhsPFwaMuE1AHbMa2Kdt3muBb LVbZC8o+dHSX0DXVnuPvmPwChzBxc7/hlvMbzuNfly/WJUdxckC8U2D/EwcBgXYTb5j4 m8GeUYEDK56MaWfgqr0KY8LVCb8Wmf3B7Dy+6n3nwFwyHIV451Q0qHN+SRPFbz4Qpj4x lMo76MufwJ7JA9tn2G4uiOpL1sM6kj19635m+SxzRxGok6OCDiz3aKwC+27X7AaMJ8Ny icHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=kdjk66ClBUEHOQPo5O8pA1o0FV9ziXIRLgjji0kwuh4=; b=tB8iebMcuNkJQhO2TM3gqI6nGAh3RTlo5CIesJgtLXv6ZpY1k/BcuCY9hopHSM6eoM F+E1yc/LqsGu+fJd3gVkWiiO/IAaTAWvNejZmvlHM8H05q/dafXSTtsBuWJCpAdu2PJN KVJDE7Ze3kGcUYwSeUcaKAYK5nJAPitOGsToLlqIAPmuekl/Scdt3vohaerE5w+4MqZX vp69XJNsIdcoIfeNrQw9PcCqi78PbgKX85cVa0hxIXXU3aWVTactogxcLfNL9s36W19X 64qKrEtRN87xkMW/ecsz8g93fBTG6YpigadI7ZNB0gtmDKJehP6IacCNXCP8Vhj4OcBQ ozpg== X-Gm-Message-State: AOAM530mIkpG+rWbqo6cgnEtZFmdFGXxMKm2+Ivw/kj3gfIVak7q5I7T gL00Wkb8WhbkOb4pHA1stU5OQQ== X-Google-Smtp-Source: ABdhPJwePHcQqWYde1cff7qtLVe6G+DpjcWltD5K1uAZ7fHOrweVgF/3qRwJ22HBdXQIXr73L76N7g== X-Received: by 2002:a17:902:9b8b:b0:13c:aad1:8a9a with SMTP id y11-20020a1709029b8b00b0013caad18a9amr18836287plp.89.1632157228425; Mon, 20 Sep 2021 10:00:28 -0700 (PDT) Received: from p14s (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id i5sm28994pjk.47.2021.09.20.10.00.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Sep 2021 10:00:27 -0700 (PDT) Date: Mon, 20 Sep 2021 11:00:24 -0600 From: Mathieu Poirier To: "Peng Fan (OSS)" Cc: ohad@wizery.com, bjorn.andersson@linaro.org, o.rempel@pengutronix.de, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, aisheng.dong@nxp.com, Peng Fan Subject: Re: [PATCH V4 6/6] remoteproc: imx_rproc: change to ioremap_wc for dram Message-ID: <20210920170024.GD2023964@p14s> References: <20210910090621.3073540-1-peng.fan@oss.nxp.com> <20210910090621.3073540-7-peng.fan@oss.nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210910090621.3073540-7-peng.fan@oss.nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210920_100029_722267_8C171264 X-CRM114-Status: GOOD ( 17.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 10, 2021 at 05:06:21PM +0800, Peng Fan (OSS) wrote: > From: Dong Aisheng > > DRAM is not io memory, so changed to ioremap_wc. This is also > aligned with core io accessories. e.g. memcpy/memset and cpu direct > access. > > Cc: Bjorn Andersson > Cc: Mathieu Poirier > Cc: Peng Fan > Reviewed-and-tested-by: Peng Fan > Signed-off-by: Dong Aisheng > Signed-off-by: Peng Fan > --- > drivers/remoteproc/imx_rproc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) I have applied patches 4, 5 and 6 of this set. > > diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c > index ff620688fad94..4ae416ba50807 100644 > --- a/drivers/remoteproc/imx_rproc.c > +++ b/drivers/remoteproc/imx_rproc.c > @@ -597,7 +597,7 @@ static int imx_rproc_addr_init(struct imx_rproc *priv, > break; > > /* Not use resource version, because we might share region */ > - priv->mem[b].cpu_addr = devm_ioremap(&pdev->dev, res.start, resource_size(&res)); > + priv->mem[b].cpu_addr = devm_ioremap_wc(&pdev->dev, res.start, resource_size(&res)); > if (!priv->mem[b].cpu_addr) { > dev_err(dev, "failed to remap %pr\n", &res); > return -ENOMEM; > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel