linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [Patchv2] arm64: dts: meson-g12b-odroid-n2: add 5v regulator gpio
@ 2021-09-20 20:47 Anand Moon
  2021-09-21  7:24 ` Neil Armstrong
  0 siblings, 1 reply; 2+ messages in thread
From: Anand Moon @ 2021-09-20 20:47 UTC (permalink / raw)
  To: linux-arm-kernel, linux-amlogic, linux-kernel
  Cc: Anand Moon, Neil Armstrong, Rob Herring, Kevin Hilman,
	Jerome Brunet, Martin Blumenstingl, Christian Hewitt, devicetree

As described in the Odroid-n2 & Odroid-n2-plus schematics,
the 5V regulator is controlled by GPIOH_8 and in Open Drain
since this GPIO doesn't support Push-Pull.

Fixes: c35f6dc5c377 ("arm64: dts: meson: Add minimal support for Odroid-N2")
Fixes: ef599f5f3e10 ("arm64: dts: meson: convert ODROID-N2 to dtsi")

Cc: Neil Armstrong <narmstrong@baylibre.com>
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
V1- Added missing Fix tags and update the Neil's Ack
---
 arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
index 344573e157a7..26943c53dfa7 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
@@ -99,6 +99,8 @@ vcc_5v: regulator-vcc_5v {
 		regulator-max-microvolt = <5000000>;
 		regulator-always-on;
 		vin-supply = <&main_12v>;
+		gpio = <&gpio GPIOH_8 GPIO_OPEN_DRAIN>;
+		enable-active-high;
 	};
 
 	vcc_1v8: regulator-vcc_1v8 {
-- 
2.33.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Patchv2] arm64: dts: meson-g12b-odroid-n2: add 5v regulator gpio
  2021-09-20 20:47 [Patchv2] arm64: dts: meson-g12b-odroid-n2: add 5v regulator gpio Anand Moon
@ 2021-09-21  7:24 ` Neil Armstrong
  0 siblings, 0 replies; 2+ messages in thread
From: Neil Armstrong @ 2021-09-21  7:24 UTC (permalink / raw)
  To: linux-kernel, linux-arm-kernel, Anand Moon, linux-amlogic
  Cc: Neil Armstrong, Rob Herring, devicetree, Kevin Hilman,
	Jerome Brunet, Martin Blumenstingl, Christian Hewitt

Hi,

On Mon, 20 Sep 2021 20:47:37 +0000, Anand Moon wrote:
> As described in the Odroid-n2 & Odroid-n2-plus schematics,
> the 5V regulator is controlled by GPIOH_8 and in Open Drain
> since this GPIO doesn't support Push-Pull.
> 
> Fixes: c35f6dc5c377 ("arm64: dts: meson: Add minimal support for Odroid-N2")
> Fixes: ef599f5f3e10 ("arm64: dts: meson: convert ODROID-N2 to dtsi")

Thanks, Applied to https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git (v5.16/dt64)

[1/1] arm64: dts: meson-g12b-odroid-n2: add 5v regulator gpio
      https://git.kernel.org/amlogic/c/ecff7bab5c9c2e2b6f5739b328347e08415879ec

-- 
Neil

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-09-21  7:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-09-20 20:47 [Patchv2] arm64: dts: meson-g12b-odroid-n2: add 5v regulator gpio Anand Moon
2021-09-21  7:24 ` Neil Armstrong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).