From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AD45C433F5 for ; Wed, 22 Sep 2021 01:25:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4B09C61184 for ; Wed, 22 Sep 2021 01:25:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4B09C61184 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VnnDZqpc/jZjMhdIGPTHe5/hC1dPAW77YZMU26fzOQg=; b=PUigUuhtROove2 oWbcMQPdX8XNgkGNRLCZmieX9M3JBwbgyl8DDFuT7xPvpWdNa0WACvTkDSYJIPxSM+AcuopmOl5to ykwvUEhA5AwlZl/NyAECToica6F24jy2S5VCkVmJE1I7v9Z0y5stT8WR31l5NOi/3wmE6B7FnQinJ 9iFbIX7ecUhO5qtEV1JHgKD/5LBT9ZSdCFKEhPHlS3DBXSmE73u41qVsiZdltDWMWLWsqB0tTQpF7 gSrdzu+Pxm5YDSgSjtKms7ceBj1UqmnGxq11GFDD3t/q/VyqlwNSBplaJcFFJzmAZb+WzImODSJzF Zvs1HEHyQQdTKppU4yEA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSqz8-006U5l-Qz; Wed, 22 Sep 2021 01:23:43 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSqz4-006U5A-PM for linux-arm-kernel@lists.infradead.org; Wed, 22 Sep 2021 01:23:40 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7A64E61184; Wed, 22 Sep 2021 01:23:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632273818; bh=eM85Ho9gidJ7n+2awXz/HV2PxjpY4TSqcYq6FGWY090=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dQP0vDkk0YBha8zWorlAgCGVjaCLPy9ZXI7ccMPQHA7sh1vYsD0jnJL8kbVMcp+ow SWxTUUYYfLLuu/xHIISD4islcX9te5Dy2Cvo1gBzcDEhLM5i1R8KchwBZuj+Vs4DiF sSRpg4s+GFrocbCmWxLBlA2p/GbDrOAgPPEHho/3U9/lNgiuRfxCZbphKgNp7WDI9l 8aM0UQ6DK5RN0TWOMMIEx10Aid9wFbjOkQvwrdebkftwrA0yhIKIvsbhr8+6VrvZit jfZzJFP2hKRSqy/77qX17sBSiJg6E9xGj+3OM5z5ZGaTETiuruaxKLjDeKHRcnlXOo S8FDOKPD0tGVw== Date: Wed, 22 Sep 2021 09:23:34 +0800 From: Shawn Guo To: Fabio Estevam Cc: Oleksij Rempel , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Markus Niebel Subject: Re: [PATCH 1/4] ARM: dts: imx6dl-alti6p: Fix the SPI chipselect polarity Message-ID: <20210922012333.GB10217@dragon> References: <20210716133659.3372047-1-festevam@gmail.com> <20210717045741.shvni526xvo4bzcf@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210921_182338_905958_50F0EF17 X-CRM114-Status: GOOD ( 21.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Aug 14, 2021 at 10:27:13AM -0300, Fabio Estevam wrote: > Hi Shawn, > > On Sat, Jul 17, 2021 at 1:57 AM Oleksij Rempel wrote: > > > > On Fri, Jul 16, 2021 at 10:36:56AM -0300, Fabio Estevam wrote: > > > The conversion of the spi-imx driver to use GPIO descriptors > > > in commit 8cdcd8aeee28 ("spi: imx/fsl-lpspi: Convert to GPIO descriptors") > > > helped to detect the following SPI chipselect polarity mismatch on an > > > imx6q-sabresd for example: > > > > > > [ 4.854337] m25p80@0 enforce active low on chipselect handle > > > > > > Prior to the above commit, the chipselect polarity passed via cs-gpios > > > property was ignored and considered active-low. > > > > > > The reason for such mismatch is clearly explained in the comments inside > > > drivers/gpio/gpiolib-of.c: > > > > > > * SPI children have active low chip selects > > > * by default. This can be specified negatively > > > * by just omitting "spi-cs-high" in the > > > * device node, or actively by tagging on > > > * GPIO_ACTIVE_LOW as flag in the device > > > * tree. If the line is simultaneously > > > * tagged as active low in the device tree > > > * and has the "spi-cs-high" set, we get a > > > * conflict and the "spi-cs-high" flag will > > > * take precedence. > > > > > > To properly represent the SPI chipselect polarity, change it to active-low > > > when the "spi-cs-high" property is absent. > > > > > > Signed-off-by: Fabio Estevam > > > > Reviewed-by: Oleksij Rempel > > Thank you! > > A gentle ping on this series. Should we have Fixes tags for the patches? Shawn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel