From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1914C433EF for ; Wed, 22 Sep 2021 21:02:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 757836112F for ; Wed, 22 Sep 2021 21:02:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 757836112F Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=K7oHqX+Bf9Ama2jVlQu0SJcB+J9CUw+lP4ztlEWf/xA=; b=bdupinyoCOwhv3 pnFmhBoBeYzk+NuoMuPQvOSfghldPcoG2jah9W/SxL796WjtFPsrm8ooe02CZKj4NK1w8Pqf8eQcL RDnRYS2u1W3sM++4AeJ8eeTld4lXiuTvWYRHwHnu3yVwGNeYsaIo+VmZ+kn5JlwE5PoW7zdlqDD7z w1N5fxyAzgagnktc5r6DAoqRp0424ujaw44gBAqY/guGNDAgc+jhBqIouT4R5W/W2C1jubJFBdUtU 5iUGRW/b8wVGKOMgz59vYHWctAlXkCNqbBulYKzzAKJrZ6bq7z2MmT2aPbWfISdi6L40UOimef4K3 +71rKPMrSe4b/N1PAR6w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mT9Lk-009ePA-6B; Wed, 22 Sep 2021 21:00:16 +0000 Received: from fllv0015.ext.ti.com ([198.47.19.141]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mT9Lg-009eOM-5h for linux-arm-kernel@lists.infradead.org; Wed, 22 Sep 2021 21:00:13 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 18ML08oh034020; Wed, 22 Sep 2021 16:00:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1632344408; bh=LUibseOnhjOc+FgMv1x4a+9RVzzzcJXHveE+rZFdCM4=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=oGeBzH6DqTDB8kOuPXbjhQFmEeGO6XeyR1owA0a40tjTW6oWZG1a7y1aLYVNg92tR OLJyHwy+2MGg78DioAM9HQcjOvJBmir2tNe2tKNXHB60zgADMbnAPCL2TZ5yUCTnQX +vt+JxbmtRH8WkKUXEfq+Px/U5Q9gUN0GyIM7Vhg= Received: from DLEE115.ent.ti.com (dlee115.ent.ti.com [157.170.170.26]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 18ML08ru101677 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 22 Sep 2021 16:00:08 -0500 Received: from DLEE114.ent.ti.com (157.170.170.25) by DLEE115.ent.ti.com (157.170.170.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Wed, 22 Sep 2021 16:00:07 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE114.ent.ti.com (157.170.170.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via Frontend Transport; Wed, 22 Sep 2021 16:00:08 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 18ML07VV030330; Wed, 22 Sep 2021 16:00:07 -0500 Date: Wed, 22 Sep 2021 16:00:07 -0500 From: Nishanth Menon To: Bjorn Andersson Subject: Re: [PATCH] dt-bindings: hwlock: omap: Remove board-specific compatible from DT example Message-ID: <20210922210007.myuuwpwd7ltpdvtf@expanse> References: <20210917094740.18891-1-sinthu.raja@ti.com> <20210917144455.nj6bc2enytlgqmzn@studied> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210922_140012_346916_869BFC3F X-CRM114-Status: GOOD ( 25.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ohad Ben-Cohen , devicetree@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, Sinthu Raja , Rob Herring , Baolin Wang , Sinthu Raja , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 17:01-20210920, Bjorn Andersson wrote: > On Mon 20 Sep 16:14 CDT 2021, Suman Anna wrote: > > > On 9/17/21 9:44 AM, Nishanth Menon wrote: > > > On 15:17-20210917, Sinthu Raja wrote: > > >> From: Sinthu Raja > > >> > > >> The example includes a board-specific compatible property, this is > > >> wrong as the example should be board agnostic. Replace the same with a > > >> generic soc node. > > >> > > >> Fixes: d8db9dc34871 ("dt-bindings: hwlock: omap: Convert binding to YAML") > > >> Signed-off-by: Sinthu Raja > > >> --- > > >> > > >> This patch was triggered by discussions in [1]. > > >> > > >> When applying the patch, if you could provide an immutable tag for the > > >> bindings, it would help line things up for new platforms to be added for > > >> us. See [2] for the context > > > > > > > > > Aah yes, thanks.. Bjorn.. once Rob acks ofcourse (since this is > > > bindings). > > > > Hmm, I don't think an immutable tag is needed for this patch. This is just > > cleanup, what is your exact dependency here? > > > > The relevant HwSpinlock dts nodes are all upstream on all applicable platforms > > already. > > > > I agree and in general I think it's better to do DT validation against > linux-next, as you would otherwise miss out on any newly introduced > issues from inherited bindings etc. I agree that an immutable commit is not needed on this specific patch. The updated revision[1] posted had already dropped that request. On the other hand, series[2] makes Rob's checks fail (as it runs on rc1) - and helps keep everyone sane by getting an immutable commit merged in allowing for follow on patches to stay clean. NOTE: I do test patches for both checks and functionality to the best I can on both rc1 (my tree)[3] and on linux-next on the day I pick the patches up. [1] https://lore.kernel.org/all/20210920123152.32751-1-sinthu.raja@ti.com/ [2] https://lore.kernel.org/all/20210917095426.19277-1-sinthu.raja@ti.com/ [3] https://git.kernel.org/pub/scm/linux/kernel/git/nmenon/linux.git/tree/ -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel