From: Nishanth Menon <nm@ti.com>
To: Suman Anna <s-anna@ti.com>
Cc: Sinthu Raja <sinthu.raja@mistralsolutions.com>,
Rob Herring <robh+dt@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Ohad Ben-Cohen <ohad@wizery.com>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-remoteproc@vger.kernel.org>,
Sinthu Raja <sinthu.raja@ti.com>,
"Nagalla, Hari" <hnagalla@ti.com>
Subject: Re: [PATCH V3 2/2] dt-bindings: remoteproc: k3-dsp: Remove board-specific compatible from DT example
Date: Sat, 25 Sep 2021 09:52:33 -0500 [thread overview]
Message-ID: <20210925145233.vczhgui6cchkih5m@oxidize> (raw)
In-Reply-To: <6a6a0d3a-522c-d01c-d3b8-a13488d0c736@ti.com>
On 12:54-20210924, Suman Anna wrote:
> Hi Sinthu,
>
> On 9/24/21 12:25 PM, Suman Anna wrote:
> > On 9/24/21 11:29 AM, Nishanth Menon wrote:
> >> On 11:10-20210924, Suman Anna wrote:
> >>> Hi Sinthu,
> >>>
> >>> On 9/17/21 4:54 AM, Sinthu Raja wrote:
> >>>> From: Sinthu Raja <sinthu.raja@ti.com>
> >>>>
> >>>> The example includes a board-specific compatible property, this is
> >>>> wrong as the example should be board agnostic and gets in the way of
> >>>> additions for newer platforms. Replace the same with a generic soc
> >>>> node.
> >>>
> >>> What board specific property? This description looks wrong.
>
> Can you please repost dropping the Fixes line, and modifying the patch
> description as follows:
>
> dt-bindings: remoteproc: k3-dsp: Cleanup SoC compatible from DT example
>
> The K3 DSP binding example used the root-node with a SoC compatible
> property originally to address the dt_binding_check warnings resulting
> from using a value of 2 for #address-cells and #size-cells as per most
> common usage on K3 SoCs. Clean this up and replace it with a generic soc
> node to keep it agnostic of the SoC or board compatibles that are outside
> the scope of this binding.
This looks good to me as well. Thanks.
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D)/Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-09-25 14:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-17 9:54 [PATCH V3 0/2] dt-bindings: remoteproc: k3-r5f|dsp: Remove Sinthu Raja
2021-09-17 9:54 ` [PATCH V3 1/2] dt-bindings: remoteproc: k3-r5f: Remove board-specific compatible from DT example Sinthu Raja
2021-09-22 20:00 ` Rob Herring
2021-09-17 9:54 ` [PATCH V3 2/2] dt-bindings: remoteproc: k3-dsp: " Sinthu Raja
2021-09-22 20:00 ` Rob Herring
2021-09-24 16:10 ` Suman Anna
2021-09-24 16:29 ` Nishanth Menon
2021-09-24 17:25 ` Suman Anna
2021-09-24 17:54 ` Suman Anna
2021-09-25 14:52 ` Nishanth Menon [this message]
2021-09-17 14:47 ` [PATCH V3 0/2] dt-bindings: remoteproc: k3-r5f|dsp: Remove Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210925145233.vczhgui6cchkih5m@oxidize \
--to=nm@ti.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=hnagalla@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=ohad@wizery.com \
--cc=robh+dt@kernel.org \
--cc=s-anna@ti.com \
--cc=sinthu.raja@mistralsolutions.com \
--cc=sinthu.raja@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).