From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7101EC433F5 for ; Sat, 25 Sep 2021 14:54:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 34101610CB for ; Sat, 25 Sep 2021 14:54:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 34101610CB Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VIjO5qy7er8/tyz1QvHj/VR334tS6gQ8DUzUnl96hXs=; b=jJioR4yKpcei6r PkbPgkD+1V5tKe/QwpBdJtZUpvbwPtcNZmHqserZ4qqpcBZk7d4XIqRAxM9QNsFOSFaESqD8GRvYG LZ9j7MO/L0jLxBKrJbdgSn26WW8O7QPlg+M88qPzvA8qMiBFVUJWI9lL+dC7QBd57G+RwJwPEPQwy f04f3DGuV5gV4sADnOz6j1wTEkZJduoBnH8GecCzbtsiwN2MZuRMvjTYloYPlm5xMwNEj4mCISgoI TWLUtVUgjYeZin2tglJjNNyda/WVbedSuwDdnJofLPhqB4fCX0fLwLmGDeAwhd8wORfGDLOkFYoRb DLyDfXFp8zP1DMuAc5fA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mU92f-00Gk60-1Z; Sat, 25 Sep 2021 14:52:41 +0000 Received: from fllv0015.ext.ti.com ([198.47.19.141]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mU92b-00Gk52-9h for linux-arm-kernel@lists.infradead.org; Sat, 25 Sep 2021 14:52:38 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 18PEqYs2015433; Sat, 25 Sep 2021 09:52:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1632581554; bh=uJ7DvnEmGCuz4FVCDrHQuDOi+qqLDfXdcIzC2WTH42o=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=PA7N5/5P964G7xnovC9ZGpoJD4Oe9P2C7PzJX9CEjGrbL8gKUVyUSiUBRbOD97HG2 JKtyR1TaSasVgKyp4HmJa1z1qm+YPofgZkZ1lxo0IPD2WRhZbhjcEXcNFH8m0mgf3x fBZAzdb8qGG2xx6U1WdoND00Xj+bRBVTRjT5i0IM= Received: from DLEE115.ent.ti.com (dlee115.ent.ti.com [157.170.170.26]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 18PEqYSR101790 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Sat, 25 Sep 2021 09:52:34 -0500 Received: from DLEE100.ent.ti.com (157.170.170.30) by DLEE115.ent.ti.com (157.170.170.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Sat, 25 Sep 2021 09:52:33 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE100.ent.ti.com (157.170.170.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via Frontend Transport; Sat, 25 Sep 2021 09:52:33 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 18PEqXfY085824; Sat, 25 Sep 2021 09:52:33 -0500 Date: Sat, 25 Sep 2021 09:52:33 -0500 From: Nishanth Menon To: Suman Anna CC: Sinthu Raja , Rob Herring , Mathieu Poirier , Bjorn Andersson , Ohad Ben-Cohen , , , , , Sinthu Raja , "Nagalla, Hari" Subject: Re: [PATCH V3 2/2] dt-bindings: remoteproc: k3-dsp: Remove board-specific compatible from DT example Message-ID: <20210925145233.vczhgui6cchkih5m@oxidize> References: <20210917095426.19277-1-sinthu.raja@ti.com> <20210917095426.19277-3-sinthu.raja@ti.com> <4d43e927-3998-e9a9-87a6-6036b769a975@ti.com> <20210924162920.mvnzcibfm7s265us@boxing> <6a6a0d3a-522c-d01c-d3b8-a13488d0c736@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6a6a0d3a-522c-d01c-d3b8-a13488d0c736@ti.com> User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210925_075237_490553_767C96E2 X-CRM114-Status: GOOD ( 17.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12:54-20210924, Suman Anna wrote: > Hi Sinthu, > > On 9/24/21 12:25 PM, Suman Anna wrote: > > On 9/24/21 11:29 AM, Nishanth Menon wrote: > >> On 11:10-20210924, Suman Anna wrote: > >>> Hi Sinthu, > >>> > >>> On 9/17/21 4:54 AM, Sinthu Raja wrote: > >>>> From: Sinthu Raja > >>>> > >>>> The example includes a board-specific compatible property, this is > >>>> wrong as the example should be board agnostic and gets in the way of > >>>> additions for newer platforms. Replace the same with a generic soc > >>>> node. > >>> > >>> What board specific property? This description looks wrong. > > Can you please repost dropping the Fixes line, and modifying the patch > description as follows: > > dt-bindings: remoteproc: k3-dsp: Cleanup SoC compatible from DT example > > The K3 DSP binding example used the root-node with a SoC compatible > property originally to address the dt_binding_check warnings resulting > from using a value of 2 for #address-cells and #size-cells as per most > common usage on K3 SoCs. Clean this up and replace it with a generic soc > node to keep it agnostic of the SoC or board compatibles that are outside > the scope of this binding. This looks good to me as well. Thanks. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D)/Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel