From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 157E8C433EF for ; Sun, 26 Sep 2021 11:25:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D229960F9B for ; Sun, 26 Sep 2021 11:25:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D229960F9B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GC+SsXAM051PTeV8qJ5VOEzPuNXrkiXtzV1QBKc+hws=; b=lv0iwGMwBrhoKv vhhDZakR6+Ovsx78N4nHkLWAJjyYWhuMltbLdp558gfYgp+nQLWBWaIcVEbi2tYNLUfA/CZpp7ERH rjWdATG/cI3nG9m7QWgbHjdmuXj6eKcPAkfaF06rrjtJrkIepvoIbiSw4ciXpfcNwVSMZ2tcyXxYd cKfF2jafe85w0nOM4cccGV7wQo6mOE/nIuR/baNu5/FacZHxVmtIC+qT6QNON/0JhIp7BLtlhm/M0 +jGeP76Ajo/9Vs8kdcQiG6Ha2ir7qPxsG4vmN0aj5vXyk+U4ca7401h62nkYNw+jEi6/Tjw+hpDPe yYs/ypUByDrGy5AhHKHw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mUSGB-000RMa-FT; Sun, 26 Sep 2021 11:23:55 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mUSG8-000RLz-B3 for linux-arm-kernel@lists.infradead.org; Sun, 26 Sep 2021 11:23:53 +0000 Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 56EA360F9B; Sun, 26 Sep 2021 11:23:46 +0000 (UTC) Date: Sun, 26 Sep 2021 12:27:34 +0100 From: Jonathan Cameron To: Billy Tsai Cc: , , , , , , , , , , , , , Subject: Re: [v7 00/11] Add support for ast2600 ADC Message-ID: <20210926122734.2fccf55a@jic23-huawei> In-Reply-To: <20210922081520.30580-1-billy_tsai@aspeedtech.com> References: <20210922081520.30580-1-billy_tsai@aspeedtech.com> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210926_042352_450955_38ED4AD6 X-CRM114-Status: GOOD ( 22.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 22 Sep 2021 16:15:09 +0800 Billy Tsai wrote: > This patch serials make aspeed_adc.c can support ast2600 and backward > compatible. Hi Billy, Series applied to the togreg branch of iio.git and pushed out as testing for 0-day to poke at it. Note the fix for platform_set_drvdata() is in the fixes branch so there will be a bit of mess around context for patch 1 but that should all resolve in a trivial fashion. Thanks, Jonathan > > Change since v6: > aspeed_adc.c: > - Fix the parameter error for aspeed_adc_unregister_fixed_divider. > > Change since v5: > aspeed_adc.c: > - Use devm_clk_hw_register_divider() > - Enabling and setting the ADC to normal mode is a necessary flow, so > take it out of the condition. > > Change since v4: > dt-bindings: > - Add clocks maxItems. > - Rename the property to meet the property-units.yaml. > - Add the description for the difference between adc0 and adc1. > aspeed_adc.c: > - Use new property name to get internal reference voltage: units from mv > to uv. > - Fix -Wnonnull warning caused by snprintf parameters. > - Add suffix mv to the vref parameters. > - Use ARRAY_SIZE instead of 32. > - Add a reset action for ADC power down and Use devm_iio_device_register. > - Fix typo error. > - Separate the offset interface of ch7 when battery sensing enable > > Change since v3: > dt-bindings: > - Fix properties:aspeed,int_vref_mv type error. > > Change since v2: > dt-bindings: > - Create a new dt-bindings for ast2600 adc > aspeed_adc.c: > - Splits the patch for more details > - Remove version enum and use the flags in model data to distinguish > hardware feature > - Support trimming data get and set. > - Use devm_add_action_or_reset to simplify probe error handling. > > Changes since v1: > dt-bindings: > - Fix the aspeed,adc.yaml check error. > - Add battery-sensing property. > aspeed_adc.c: > - Change the init flow: > Clock and reference voltage setting should be completed before adc > engine enable. > - Change the default sampling rate to meet most user case. > - Add patch #8 to suppoert battery sensing mode. > > Billy Tsai (11): > iio: adc: aspeed: Keep model data to driver data. > iio: adc: aspeed: Restructure the model data > iio: adc: aspeed: Add vref config function > iio: adc: aspeed: Use model_data to set clk scaler. > iio: adc: aspeed: Use devm_add_action_or_reset. > iio: adc: aspeed: Support ast2600 adc. > iio: adc: aspeed: Fix the calculate error of clock. > iio: adc: aspeed: Add func to set sampling rate. > iio: adc: aspeed: Add compensation phase. > iio: adc: aspeed: Support battery sensing. > iio: adc: aspeed: Get and set trimming data. > > drivers/iio/adc/aspeed_adc.c | 554 +++++++++++++++++++++++++++++------ > 1 file changed, 459 insertions(+), 95 deletions(-) > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel