From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F6A2C433EF for ; Sun, 26 Sep 2021 12:20:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C871460F4B for ; Sun, 26 Sep 2021 12:20:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C871460F4B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RqjwXvu1g/2zVU9EssvTnaVa2BBdcZfWx3yWqHCoiQ8=; b=GWSWzeGdy7HYfA qqNh7hPYTeAvbh3KmnweF0a5mChUxw9ms2ZSadVLyVxiOQ3Pq8Bi61CYdChG0PO5A+UsUUACoux0W TlZIIizyh10er6s1jgAiEIZyWhEEujmE+5O46/JM+DuWvmNDnXsYrbJSxz/e6bCAZxZ0KjKHyr90A lTSvitFFR9cuRodiMKrRoVTSIi1gZ/SGcYVoq6tixyCpk5NOLWOEpvVpTNQPJdB8YHVSSwS6TNyWe EtR+CpIR4+YSotQ+CKiXjK/QRKha75oRGHICAjalpqIBUYHt2WzbX0Chj1lHGL2yxPTT8AfU7fpog N1CwSjJWfKyTbg1CXnmg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mUT7z-000YUQ-It; Sun, 26 Sep 2021 12:19:31 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mUT7v-000YTb-H6 for linux-arm-kernel@lists.infradead.org; Sun, 26 Sep 2021 12:19:28 +0000 Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0CB1760F4B; Sun, 26 Sep 2021 12:19:23 +0000 (UTC) Date: Sun, 26 Sep 2021 13:23:13 +0100 From: Jonathan Cameron To: Olivier Moysan Cc: Alexandre Torgue , Fabrice Gasnier , "Lars-Peter Clausen" , Maxime Coquelin , Rob Herring , , , , , Subject: Re: [PATCH v3 0/7] iio: adc: stm32-adc: add internal channels support Message-ID: <20210926132313.16c7a356@jic23-huawei> In-Reply-To: <20210924083410.12332-1-olivier.moysan@foss.st.com> References: <20210924083410.12332-1-olivier.moysan@foss.st.com> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210926_051927_619469_9B1A3CDF X-CRM114-Status: GOOD ( 19.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 24 Sep 2021 10:34:03 +0200 Olivier Moysan wrote: > This patchset adds support of ADC2 internal channels VDDCORE, VREFINT and VBAT > on STM32MP15x SoCs. The generic IIO channel bindings is also introduced here > to provide this feature. The legacy channel binding is kept for backward compatibility. Hi Olivier, I had a read through and am happy with how this looks now. I'll leave it on the list for a while longer because Rob may well want to take a final look at patch 1. Obviously input from other people also welcome! If it looks like I have forgotten it in a few weeks feel free to poke me. Thanks, Jonathan > > Changes in v2: > - Add 'deprecated' to channels legacy properties in ADC bindings > - Add set/clr service for common registers, to make code more generic in > internal channels enable/disable services. > - Expose vrefint channel as a processed channel to return > the actual value of vrefp. > - Minor code improvements > > Changes in v3: > - fix vrefint sampling time check. > > Olivier Moysan (7): > dt-bindings: iio: stm32-adc: add generic channel binding > dt-bindings: iio: stm32-adc: add nvmem support for vrefint internal > channel > iio: adc: stm32-adc: split channel init into several routines > iio: adc: stm32-adc: add support of generic channels binding > iio: adc: stm32-adc: add support of internal channels > iio: adc: stm32-adc: add vrefint calibration support > iio: adc: stm32-adc: use generic binding for sample-time > > .../bindings/iio/adc/st,stm32-adc.yaml | 108 ++++- > drivers/iio/adc/stm32-adc-core.h | 8 + > drivers/iio/adc/stm32-adc.c | 426 ++++++++++++++++-- > 3 files changed, 487 insertions(+), 55 deletions(-) > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel