From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CE40C433F5 for ; Sun, 26 Sep 2021 14:13:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2EF2E60F9B for ; Sun, 26 Sep 2021 14:13:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2EF2E60F9B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=swGDqx+8ZAQ9e/Iwon0t+jUFb1e4+OmaF27vUy9zFgM=; b=inKLxpuxF2olnB s35TdgLVSNv4oVMQzGUmX77xZYpazoldrmXBtFonwtvjhMMYFg3VKzocr+ffeMi+pJUj8pIEZb11V fLJylZyKCp30FxFomIsHXunah2tRej7GZOQtrzw4or24Z95iR+Tj4yf50DqVO03rgbBJZQ3SBgoAJ ihj/XadryOY8/bOwKijDy9UGebTe4wOzvutdxfRmk3zT6mnLL/zTiwU8SNq4+w1wceNmBF72KiA7I cWyNh8DWiAPQOdWAU42JnAfzSHKa5J1//QeOPKMJGQ8X757acSVDKlDO4r3CAhTJzqFnX2s3roCxa Wj7Z1eOrrCUxrd7LsD0g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mUUtG-000gtt-Re; Sun, 26 Sep 2021 14:12:26 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mUUtC-000gtD-62 for linux-arm-kernel@lists.infradead.org; Sun, 26 Sep 2021 14:12:23 +0000 Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8A30660FC2; Sun, 26 Sep 2021 14:12:18 +0000 (UTC) Date: Sun, 26 Sep 2021 15:16:07 +0100 From: Jonathan Cameron To: Cai Huoqing Cc: Lars-Peter Clausen , Rob Herring , Shawn Guo , "Sascha Hauer" , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , , , , Subject: Re: [PATCH v6 0/3] iio: imx8qxp-adc: Add driver support for NXP IMX8QXP ADC Message-ID: <20210926151607.0c78736f@jic23-huawei> In-Reply-To: <20210925020555.129-1-caihuoqing@baidu.com> References: <20210925020555.129-1-caihuoqing@baidu.com> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210926_071222_296203_BAA646F0 X-CRM114-Status: GOOD ( 20.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, 25 Sep 2021 10:05:44 +0800 Cai Huoqing wrote: > The NXP i.MX 8QuadXPlus SOC has a new ADC IP. These patches add > driver support for this ADC. Hi Cai Huoqing, Series applies with the changes discussed in replies to patch 1. Applied to the togreg branch of iio.git which will be initially pushed out as testing to let 0-day see if it can find anything we missed. Thanks, Jonathan > > dt-bindings: iio: adc: > v1->v2: > *Fix some indentation issues. > *Mark status as okay. > *Change clock2 source. > v3->v4: > *Remove 'status' from examples. > *Remove unused 'state'. > *Remove interrupts-parent. > *Change num of address/size-cells from 1 to 2. > v4->v5: > *Remove unused properties. > > iio: imx8qxp-adc: > v1->v2: > *Squash patches 1, 2, 3, and 5 into a single patch. > *Add device specific prefix. > *Remove the brackets around individual numbers. > *Make use of FIELD_PREP() and FIELD_GET(). > *Remove a lot of cache values. > *Replace mlock with adc->lock. > *Move adc->value read from isr to the completion. > *Set pm_runtime_disable/_put_noidle() before adc_disable. > *Add error handler-err_disable_reg/err_unprepare_clk. > v2->v3: > *Add "return 0" to adc_runtime_resume(). > v3->v4: > *Sort header file declarations in alphabetical order. > *Remove explicitly cast from "void *". > *Make use of dev_err_probe(). > *Add some blank lines to help readability. > v4->v5: > *Update commit message. > *Remove unused headers. > *Wrap imx8qxp_adc_read_raw() at a shorter line length that helps readability. > *Deal with clock/regulator in probe/remove(). > *Use ADC_DRIVER_NAME instead of dev_name(dev). > *Don't use dev_error_probe() without returning -PROBE_DEFER. > v5->v6: > *Rename the error path labels to indicate the action that will be performed. > > v1 link: > https://patchwork.kernel.org/project/linux-arm-kernel/patch/20210830172140.414-4-caihuoqing@baidu.com/ > v3 link: > https://patchwork.kernel.org/project/linux-arm-kernel/cover/20210907015724.1377-1-caihuoqing@baidu.com/ > v4 link: > https://patchwork.kernel.org/project/linux-arm-kernel/cover/20210912071334.1745-1-caihuoqing@baidu.com/ > v5 link: > https://patchwork.kernel.org/project/linux-arm-kernel/cover/20210921052821.91-1-caihuoqing@baidu.com/ > > Cai Huoqing (3): > iio: imx8qxp-adc: Add driver support for NXP IMX8QXP ADC > iio: imx8qxp-adc: dt-bindings: iio: adc: Add binding documentation for > NXP IMX8QXP ADC > MAINTAINERS: Add the driver info of the NXP IMX8QXP > > .../bindings/iio/adc/nxp,imx8qxp-adc.yaml | 78 +++ > MAINTAINERS | 7 + > drivers/iio/adc/Kconfig | 10 + > drivers/iio/adc/Makefile | 1 + > drivers/iio/adc/imx8qxp-adc.c | 492 ++++++++++++++++++ > 5 files changed, 588 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/adc/nxp,imx8qxp-adc.yaml > create mode 100644 drivers/iio/adc/imx8qxp-adc.c > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel