From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 254A3C433F5 for ; Mon, 27 Sep 2021 09:53:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DA6F36115C for ; Mon, 27 Sep 2021 09:53:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DA6F36115C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=UvX7GYFb9BIHIEiviElDxW1lwB/0BhoEZSeNV5HnrP0=; b=BCGsgVikVTjorl rMhgX3D14ba1xqtSA7fF4NJOoEoqKa9Iq+OXFd1UQACEEwItAMex5ilOy11ZeYEpyA2c12ciBoIs4 bhmzy4Csqmfb7020vGWrWJS7uxgukYFIfDHC5cXnW1KTyJtcXtDZ5W/jZiwr+nEWIE+b4GNSXVU5O KWdLyJOHAVK8ROFz9TBdgWKr0WsaHXgc4pZ+W0alsqKdRDyRS1hD4EyYqe9g2aIW/yFnw8+nw47hi igSpp4h4R06DtSE7EXY5/CusA/BcuwSuFPupO+f462ljyFFVUK6BpDDQZhzEOpLNulaqJAI2Wr4MZ 0pbRA5bolU2rnQkgvZSQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mUnIk-002DhS-Hs; Mon, 27 Sep 2021 09:51:58 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mUnIg-002Dh2-Rk for linux-arm-kernel@lists.infradead.org; Mon, 27 Sep 2021 09:51:56 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id EA975600EF; Mon, 27 Sep 2021 09:51:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632736314; bh=euDAn8QrdLy6aBu3eAQGzTKso/i73eEHDM14y55fAE0=; h=From:To:Cc:Subject:Date:From; b=W8PXnhQrvX224HksE/K58bchshcna7UHoYaosUrKvh/wqqGxGTQpVOs6BMX9slA8d R28g9mygpMuq7SJAnuEPBjNNKvLdHbEYtAkLBz3sFA0mVtdVZHGQXZw2sXKeu5ltTN laJiEqUlvoFEYihvfvGmV9bYlwC9/8ctMlI4FQDs72aKJLEeXDgGS0bqMQ5S0ezK7B p9t3OCc2doBvkYHHpRiPzw+3dkwGXKDk4/+1AeZsU+UjHzXz5RRrOJS/dgQ8LGqEhs zC+PpzQMpAmDD6r8VOy5u3Nav2nXXkLtM4GNoeDP2LmMIe9lnEg1JG3rbanF1SRj8Z 4q8e9ToGYLbIQ== From: Arnd Bergmann To: Krzysztof Kozlowski , "Rafael J. Wysocki" , Viresh Kumar Cc: Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] cpufreq: s3c244x: add fallthrough comments for switch Date: Mon, 27 Sep 2021 11:51:44 +0200 Message-Id: <20210927095150.944127-1-arnd@kernel.org> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210927_025154_935068_736C435D X-CRM114-Status: UNSURE ( 9.39 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Arnd Bergmann Apparently nobody has so far caught this warning, I hit it in randconfig build testing: drivers/cpufreq/s3c2440-cpufreq.c: In function 's3c2440_cpufreq_setdivs': drivers/cpufreq/s3c2440-cpufreq.c:175:10: error: this statement may fall through [-Werror=implicit-fallthrough=] camdiv |= S3C2440_CAMDIVN_HCLK3_HALF; ^ drivers/cpufreq/s3c2440-cpufreq.c:176:2: note: here case 3: ^~~~ drivers/cpufreq/s3c2440-cpufreq.c:181:10: error: this statement may fall through [-Werror=implicit-fallthrough=] camdiv |= S3C2440_CAMDIVN_HCLK4_HALF; ^ drivers/cpufreq/s3c2440-cpufreq.c:182:2: note: here case 4: ^~~~ Both look like the fallthrough is intentional, so add the new "fallthrough;" keyword. Signed-off-by: Arnd Bergmann --- drivers/cpufreq/s3c2440-cpufreq.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/cpufreq/s3c2440-cpufreq.c b/drivers/cpufreq/s3c2440-cpufreq.c index 148e8aedefa9..2011fb9c03a4 100644 --- a/drivers/cpufreq/s3c2440-cpufreq.c +++ b/drivers/cpufreq/s3c2440-cpufreq.c @@ -173,12 +173,14 @@ static void s3c2440_cpufreq_setdivs(struct s3c_cpufreq_config *cfg) case 6: camdiv |= S3C2440_CAMDIVN_HCLK3_HALF; + fallthrough; case 3: clkdiv |= S3C2440_CLKDIVN_HDIVN_3_6; break; case 8: camdiv |= S3C2440_CAMDIVN_HCLK4_HALF; + fallthrough; case 4: clkdiv |= S3C2440_CLKDIVN_HDIVN_4_8; break; -- 2.29.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel