From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2605C433EF for ; Mon, 27 Sep 2021 10:50:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AA57860F4B for ; Mon, 27 Sep 2021 10:50:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AA57860F4B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+ytCygnnQp41MT0fdc2oVT42+djLyNWDSuFilo59jLU=; b=LcN2ffIzDil/tU zAEAPmQYH0GXcgK0zGlGgYqtS0L4+CR5pBhwnJMp3Odpdv1uSUjLEq99SZ63f+B9nUGLthAPI1Yt8 eiArazD4c4NS+MNXxmFyRLaQjX4MitoSFazVn3vSC29E8vTGPMUMJaDHrC8yVNn8aG81ugS1JMDw8 abujhal5X2TmF/8pwwwLajc2YE8ULkmXeShAupoF4TPmq9OiuvcgKfwSvATmsaxv7USkoo2YLg1i/ LWsW3R9Tr+/WrXS7sIsxVG/YVLIwlMHS9jf2b9avx3913hFQSBckU+Y7zxe3aKiI81hkMPA4BnYBM 7Cx1J0vMxni/v8MHYfCA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mUoBm-002LHn-Nt; Mon, 27 Sep 2021 10:48:50 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mUoBi-002LHL-OX for linux-arm-kernel@lists.infradead.org; Mon, 27 Sep 2021 10:48:48 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 10497ED1; Mon, 27 Sep 2021 03:48:44 -0700 (PDT) Received: from bogus (unknown [10.57.25.233]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 909173F70D; Mon, 27 Sep 2021 03:48:41 -0700 (PDT) Date: Mon, 27 Sep 2021 11:48:21 +0100 From: Sudeep Holla To: Rob Herring Cc: devicetree@vger.kernel.org, Guillaume Tucker , Sudeep Holla , Liviu Dudau , Lorenzo Pieralisi , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] arm: dts: vexpress: Fix motherboard bus 'interrupt-map' Message-ID: <20210927104821.pmm33yarfpujgfjm@bogus> References: <20210924214221.1877686-1-robh@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210924214221.1877686-1-robh@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210927_034846_868068_AF078E3F X-CRM114-Status: GOOD ( 19.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 24, 2021 at 04:42:21PM -0500, Rob Herring wrote: > Commit 078fb7aa6a83 ("arm: dts: vexpress: Fix addressing issues with > 'motherboard-bus' nodes") broke booting on a couple of 32-bit VExpress > boards. The problem is #address-cells size changed, but interrupt-map > was not updated. This results in the timer interrupt (and all the > other motherboard interrupts) not getting mapped. > > As the 'interrupt-map' properties are all just duplicates across boards, > just move them into vexpress-v2m.dtsi and vexpress-v2m-rs1.dtsi. > Strictly speaking, 'interrupt-map' is dependent on the parent > interrupt controller, but it's not likely we'll ever have a different > parent than GICv2 on these old platforms. If there was one, > 'interrupt-map' can still be overridden. > > Fixes: 078fb7aa6a83 ("arm: dts: vexpress: Fix addressing issues with 'motherboard-bus' nodes") > Reported-by: Reported-by: "kernelci.org bot" > Cc: Guillaume Tucker > Cc: Liviu Dudau > Cc: Sudeep Holla > Cc: Lorenzo Pieralisi > Cc: linux-arm-kernel@lists.infradead.org > Signed-off-by: Rob Herring > --- > I tested this on QEMU VExpress CA9. I also added a check to dtc for > 'interrupt-map' to catch this kind of error. I need to run it on the > rest of the tree and upstream it before enabling in the kernel. > Thanks for fixing this quickly. This time I tested on both Juno and TC2. Sorry I missed to test it on TC2 earlier as the board was not accessible. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel