From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 017F7C433F5 for ; Mon, 27 Sep 2021 11:39:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BAA2C60F4B for ; Mon, 27 Sep 2021 11:39:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BAA2C60F4B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=fEcotiPMjc3dHIpMrYUj44qLVkgCapJB/Yuovol9Mos=; b=yfi+lxg83KRFU3 F8ZgTHm1P80mHeKJB2/3Wme3s0W1llUfjAlNI16frjXF1XZetqipHZ7ESp6Dz2fPb9okdaWtsLGHo gTjJC3yqDqHir2xM4kOkbF5pHUxcfteUEq06fB2vdlpoBCRIBm4bReGzRlF08rbXyLHzHFcu/4XKL qoEj+GSCjR7l1FczcQGIXm4l5MKQC/4BDU95/PifeqRdz8FOFoHt2cBDTeKobdWJing0917WPQcdS J86krsNbNf5VSq8+HYSSz1H0/QMZe6ksvIoWvzbIfcjB+AtnhoAOYT/3OBV2uuJzlyiNCLPjgzgAW sOFr16AZDLkVDVxhb05A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mUowY-002SGB-G7; Mon, 27 Sep 2021 11:37:10 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mUowV-002SFH-2n; Mon, 27 Sep 2021 11:37:08 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6C1B560EFD; Mon, 27 Sep 2021 11:37:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632742626; bh=S53mQIgJmKuw8oAdVPMGibdAZq9B1XNWAEqUxJ18+bg=; h=From:To:Cc:Subject:Date:From; b=Co0Utw3xDXUni3n1X3K6LnsXERWQcHHvduRZWQRoxmHJePzRhYkDzOT6ovApqrmj0 xuGJLgPVHkMBtowLerSvwwtD/1Cdm0RmdKmkLuYd16vEv1i0BqM6wPVmZm+uzEGyq/ abFf0+tVJPE6qnOBvlGPtJlA3vtg8G8qT7T3blGam/XMwOGjO3fFclqa71ZHkVOqPZ 1znJk2//wPEJg3eMoVrGSnQJdmqE2Y0UVTvIpumUitoy5vf79V8tMs4uP3xMQ9nUz2 AyZE5EV0c2x4BgJ5NWWNoV0Tjn+jyuH8xb7m1ShoinYSomhTm3hu0fPwQR3mJ4pkDx rcA5yfykA5DLw== From: Arnd Bergmann To: Nicolas Saenz Julienne , Greg Kroah-Hartman , Dan Carpenter Cc: Arnd Bergmann , Stefan Wahren , Ojaswin Mujoo , Phil Elwell , Amarjargal Gundjalam , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH] staging: vc04_services: shut up out-of-range warning Date: Mon, 27 Sep 2021 13:36:56 +0200 Message-Id: <20210927113702.3866843-1-arnd@kernel.org> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210927_043707_172354_397F80C0 X-CRM114-Status: UNSURE ( 9.40 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Arnd Bergmann The comparison against SIZE_MAX produces a harmless warning on 64-bit architectures: drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:185:16: error: result of comparison of constant 419244183493398898 with expression of type 'unsigned int' is always false [-Werror,-Wtautological-constant-out-of-range-compare] if (num_pages > (SIZE_MAX - sizeof(struct pagelist) - ~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Shut up that warning by adding a cast to a longer type. Fixes: ca641bae6da9 ("staging: vc04_services: prevent integer overflow in create_pagelist()") Signed-off-by: Arnd Bergmann --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c index b25369a13452..967f10b9582a 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c @@ -182,7 +182,7 @@ create_pagelist(char *buf, char __user *ubuf, offset = (uintptr_t)ubuf & (PAGE_SIZE - 1); num_pages = DIV_ROUND_UP(count + offset, PAGE_SIZE); - if (num_pages > (SIZE_MAX - sizeof(struct pagelist) - + if ((size_t)num_pages > (SIZE_MAX - sizeof(struct pagelist) - sizeof(struct vchiq_pagelist_info)) / (sizeof(u32) + sizeof(pages[0]) + sizeof(struct scatterlist))) -- 2.29.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel