From: "Pali Rohár" <pali@kernel.org>
To: Robert Marko <robert.marko@sartura.hr>
Cc: andrew@lunn.ch, gregory.clement@bootlin.com,
sebastian.hesselbarth@gmail.com, robh+dt@kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] arm64: dts: marvell: espressobin-ultra: enable front USB3 port
Date: Tue, 28 Sep 2021 17:37:31 +0200 [thread overview]
Message-ID: <20210928153731.7we6p7mclil2e5j2@pali> (raw)
In-Reply-To: <20210927154159.2168500-4-robert.marko@sartura.hr>
On Monday 27 September 2021 17:41:59 Robert Marko wrote:
> Espressobin Ultra has a front panel USB3.0 Type-A port which works
> just fine so enable it.
> I dont see a reason why it was disabled in the first place anyway.
If USB 3.0 port is was tested and is working fine, then what about
adding Fixes: tag into commit message?
> Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> ---
> arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts
> index 96855a10b4a0..aada43fa236c 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-ultra.dts
> @@ -112,7 +112,6 @@ rtc@51 {
>
> &usb3 {
> usb-phy = <&usb3_phy>;
> - status = "disabled";
> };
>
> &mdio {
> --
> 2.31.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-09-28 15:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-27 15:41 [PATCH 1/4] arm64: dts: marvell: espressobin-ultra: enable UART output by default Robert Marko
2021-09-27 15:41 ` [PATCH 2/4] arm64: dts: marvell: espressobin-ultra: fix SPI-NOR config Robert Marko
2021-09-27 15:41 ` [PATCH 3/4] arm64: dts: marvell: espressobin-ultra: add PHY and switch reset pins Robert Marko
2021-09-27 16:38 ` Andrew Lunn
2021-09-28 15:32 ` Pali Rohár
2021-09-28 16:02 ` Robert Marko
2022-09-24 12:03 ` Pali Rohár
2021-09-27 15:41 ` [PATCH 4/4] arm64: dts: marvell: espressobin-ultra: enable front USB3 port Robert Marko
2021-09-28 15:37 ` Pali Rohár [this message]
2021-09-28 16:02 ` Robert Marko
2021-09-27 16:37 ` [PATCH 1/4] arm64: dts: marvell: espressobin-ultra: enable UART output by default Andrew Lunn
2021-09-28 15:13 ` Pali Rohár
2021-09-28 15:49 ` Robert Marko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210928153731.7we6p7mclil2e5j2@pali \
--to=pali@kernel.org \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robert.marko@sartura.hr \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox