* [PATCH] ARM: dts: spear13xx: Drop malformed 'interrupt-map' on PCI nodes
@ 2021-09-28 19:21 Rob Herring
2021-10-04 6:14 ` Viresh Kumar
0 siblings, 1 reply; 5+ messages in thread
From: Rob Herring @ 2021-09-28 19:21 UTC (permalink / raw)
To: Viresh Kumar, Shiraz Hashim; +Cc: linux-arm-kernel, devicetree, linux-kernel
The spear13xx PCI 'interrupt-map' property is not parse-able.
'#interrupt-cells' is missing and there are 3 #address-cells. Based on the
driver, the only supported interrupt is for MSI. Therefore, 'interrupt-map'
is not needed.
Cc: Viresh Kumar <vireshk@kernel.org>
Cc: Shiraz Hashim <shiraz.linux.kernel@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org
Signed-off-by: Rob Herring <robh@kernel.org>
---
arch/arm/boot/dts/spear1310.dtsi | 6 ------
arch/arm/boot/dts/spear1340.dtsi | 2 --
2 files changed, 8 deletions(-)
diff --git a/arch/arm/boot/dts/spear1310.dtsi b/arch/arm/boot/dts/spear1310.dtsi
index c4b49baf9804..2f746a9428a7 100644
--- a/arch/arm/boot/dts/spear1310.dtsi
+++ b/arch/arm/boot/dts/spear1310.dtsi
@@ -82,8 +82,6 @@ pcie0: pcie@b1000000 {
reg = <0xb1000000 0x4000>, <0x80000000 0x20000>;
reg-names = "dbi", "config";
interrupts = <0 68 0x4>;
- interrupt-map-mask = <0 0 0 0>;
- interrupt-map = <0x0 0 &gic 0 68 0x4>;
num-lanes = <1>;
phys = <&miphy0 1>;
phy-names = "pcie-phy";
@@ -101,8 +99,6 @@ pcie1: pcie@b1800000 {
reg = <0xb1800000 0x4000>, <0x90000000 0x20000>;
reg-names = "dbi", "config";
interrupts = <0 69 0x4>;
- interrupt-map-mask = <0 0 0 0>;
- interrupt-map = <0x0 0 &gic 0 69 0x4>;
num-lanes = <1>;
phys = <&miphy1 1>;
phy-names = "pcie-phy";
@@ -120,8 +116,6 @@ pcie2: pcie@b4000000 {
reg = <0xb4000000 0x4000>, <0xc0000000 0x20000>;
reg-names = "dbi", "config";
interrupts = <0 70 0x4>;
- interrupt-map-mask = <0 0 0 0>;
- interrupt-map = <0x0 0 &gic 0 70 0x4>;
num-lanes = <1>;
phys = <&miphy2 1>;
phy-names = "pcie-phy";
diff --git a/arch/arm/boot/dts/spear1340.dtsi b/arch/arm/boot/dts/spear1340.dtsi
index 1a8f5e8b10e3..827e887afbda 100644
--- a/arch/arm/boot/dts/spear1340.dtsi
+++ b/arch/arm/boot/dts/spear1340.dtsi
@@ -47,8 +47,6 @@ pcie0: pcie@b1000000 {
reg = <0xb1000000 0x4000>, <0x80000000 0x20000>;
reg-names = "dbi", "config";
interrupts = <0 68 0x4>;
- interrupt-map-mask = <0 0 0 0>;
- interrupt-map = <0x0 0 &gic 0 68 0x4>;
num-lanes = <1>;
phys = <&miphy0 1>;
phy-names = "pcie-phy";
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] ARM: dts: spear13xx: Drop malformed 'interrupt-map' on PCI nodes
2021-09-28 19:21 [PATCH] ARM: dts: spear13xx: Drop malformed 'interrupt-map' on PCI nodes Rob Herring
@ 2021-10-04 6:14 ` Viresh Kumar
2021-10-21 21:12 ` Rob Herring
0 siblings, 1 reply; 5+ messages in thread
From: Viresh Kumar @ 2021-10-04 6:14 UTC (permalink / raw)
To: Rob Herring
Cc: Viresh Kumar, Shiraz Hashim, linux-arm-kernel, devicetree,
linux-kernel
On 28-09-21, 14:21, Rob Herring wrote:
> The spear13xx PCI 'interrupt-map' property is not parse-able.
> '#interrupt-cells' is missing and there are 3 #address-cells. Based on the
> driver, the only supported interrupt is for MSI. Therefore, 'interrupt-map'
> is not needed.
>
> Cc: Viresh Kumar <vireshk@kernel.org>
> Cc: Shiraz Hashim <shiraz.linux.kernel@gmail.com>
> Cc: linux-arm-kernel@lists.infradead.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> arch/arm/boot/dts/spear1310.dtsi | 6 ------
> arch/arm/boot/dts/spear1340.dtsi | 2 --
> 2 files changed, 8 deletions(-)
>
> diff --git a/arch/arm/boot/dts/spear1310.dtsi b/arch/arm/boot/dts/spear1310.dtsi
> index c4b49baf9804..2f746a9428a7 100644
> --- a/arch/arm/boot/dts/spear1310.dtsi
> +++ b/arch/arm/boot/dts/spear1310.dtsi
> @@ -82,8 +82,6 @@ pcie0: pcie@b1000000 {
> reg = <0xb1000000 0x4000>, <0x80000000 0x20000>;
> reg-names = "dbi", "config";
> interrupts = <0 68 0x4>;
> - interrupt-map-mask = <0 0 0 0>;
> - interrupt-map = <0x0 0 &gic 0 68 0x4>;
> num-lanes = <1>;
> phys = <&miphy0 1>;
> phy-names = "pcie-phy";
> @@ -101,8 +99,6 @@ pcie1: pcie@b1800000 {
> reg = <0xb1800000 0x4000>, <0x90000000 0x20000>;
> reg-names = "dbi", "config";
> interrupts = <0 69 0x4>;
> - interrupt-map-mask = <0 0 0 0>;
> - interrupt-map = <0x0 0 &gic 0 69 0x4>;
> num-lanes = <1>;
> phys = <&miphy1 1>;
> phy-names = "pcie-phy";
> @@ -120,8 +116,6 @@ pcie2: pcie@b4000000 {
> reg = <0xb4000000 0x4000>, <0xc0000000 0x20000>;
> reg-names = "dbi", "config";
> interrupts = <0 70 0x4>;
> - interrupt-map-mask = <0 0 0 0>;
> - interrupt-map = <0x0 0 &gic 0 70 0x4>;
> num-lanes = <1>;
> phys = <&miphy2 1>;
> phy-names = "pcie-phy";
> diff --git a/arch/arm/boot/dts/spear1340.dtsi b/arch/arm/boot/dts/spear1340.dtsi
> index 1a8f5e8b10e3..827e887afbda 100644
> --- a/arch/arm/boot/dts/spear1340.dtsi
> +++ b/arch/arm/boot/dts/spear1340.dtsi
> @@ -47,8 +47,6 @@ pcie0: pcie@b1000000 {
> reg = <0xb1000000 0x4000>, <0x80000000 0x20000>;
> reg-names = "dbi", "config";
> interrupts = <0 68 0x4>;
> - interrupt-map-mask = <0 0 0 0>;
> - interrupt-map = <0x0 0 &gic 0 68 0x4>;
> num-lanes = <1>;
> phys = <&miphy0 1>;
> phy-names = "pcie-phy";
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ARM: dts: spear13xx: Drop malformed 'interrupt-map' on PCI nodes
2021-10-04 6:14 ` Viresh Kumar
@ 2021-10-21 21:12 ` Rob Herring
2021-10-22 4:35 ` Viresh Kumar
0 siblings, 1 reply; 5+ messages in thread
From: Rob Herring @ 2021-10-21 21:12 UTC (permalink / raw)
To: Viresh Kumar
Cc: Viresh Kumar, Shiraz Hashim, linux-arm-kernel, devicetree,
linux-kernel@vger.kernel.org
On Mon, Oct 4, 2021 at 1:14 AM Viresh Kumar <viresh.kumar@linaro.org> wrote:
>
> On 28-09-21, 14:21, Rob Herring wrote:
> > The spear13xx PCI 'interrupt-map' property is not parse-able.
> > '#interrupt-cells' is missing and there are 3 #address-cells. Based on the
> > driver, the only supported interrupt is for MSI. Therefore, 'interrupt-map'
> > is not needed.
> >
> > Cc: Viresh Kumar <vireshk@kernel.org>
> > Cc: Shiraz Hashim <shiraz.linux.kernel@gmail.com>
> > Cc: linux-arm-kernel@lists.infradead.org
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > ---
> > arch/arm/boot/dts/spear1310.dtsi | 6 ------
> > arch/arm/boot/dts/spear1340.dtsi | 2 --
> > 2 files changed, 8 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/spear1310.dtsi b/arch/arm/boot/dts/spear1310.dtsi
> > index c4b49baf9804..2f746a9428a7 100644
> > --- a/arch/arm/boot/dts/spear1310.dtsi
> > +++ b/arch/arm/boot/dts/spear1310.dtsi
> > @@ -82,8 +82,6 @@ pcie0: pcie@b1000000 {
> > reg = <0xb1000000 0x4000>, <0x80000000 0x20000>;
> > reg-names = "dbi", "config";
> > interrupts = <0 68 0x4>;
> > - interrupt-map-mask = <0 0 0 0>;
> > - interrupt-map = <0x0 0 &gic 0 68 0x4>;
> > num-lanes = <1>;
> > phys = <&miphy0 1>;
> > phy-names = "pcie-phy";
> > @@ -101,8 +99,6 @@ pcie1: pcie@b1800000 {
> > reg = <0xb1800000 0x4000>, <0x90000000 0x20000>;
> > reg-names = "dbi", "config";
> > interrupts = <0 69 0x4>;
> > - interrupt-map-mask = <0 0 0 0>;
> > - interrupt-map = <0x0 0 &gic 0 69 0x4>;
> > num-lanes = <1>;
> > phys = <&miphy1 1>;
> > phy-names = "pcie-phy";
> > @@ -120,8 +116,6 @@ pcie2: pcie@b4000000 {
> > reg = <0xb4000000 0x4000>, <0xc0000000 0x20000>;
> > reg-names = "dbi", "config";
> > interrupts = <0 70 0x4>;
> > - interrupt-map-mask = <0 0 0 0>;
> > - interrupt-map = <0x0 0 &gic 0 70 0x4>;
> > num-lanes = <1>;
> > phys = <&miphy2 1>;
> > phy-names = "pcie-phy";
> > diff --git a/arch/arm/boot/dts/spear1340.dtsi b/arch/arm/boot/dts/spear1340.dtsi
> > index 1a8f5e8b10e3..827e887afbda 100644
> > --- a/arch/arm/boot/dts/spear1340.dtsi
> > +++ b/arch/arm/boot/dts/spear1340.dtsi
> > @@ -47,8 +47,6 @@ pcie0: pcie@b1000000 {
> > reg = <0xb1000000 0x4000>, <0x80000000 0x20000>;
> > reg-names = "dbi", "config";
> > interrupts = <0 68 0x4>;
> > - interrupt-map-mask = <0 0 0 0>;
> > - interrupt-map = <0x0 0 &gic 0 68 0x4>;
> > num-lanes = <1>;
> > phys = <&miphy0 1>;
> > phy-names = "pcie-phy";
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Are you going to apply this?
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ARM: dts: spear13xx: Drop malformed 'interrupt-map' on PCI nodes
2021-10-21 21:12 ` Rob Herring
@ 2021-10-22 4:35 ` Viresh Kumar
2021-10-22 14:07 ` Rob Herring
0 siblings, 1 reply; 5+ messages in thread
From: Viresh Kumar @ 2021-10-22 4:35 UTC (permalink / raw)
To: Rob Herring
Cc: Viresh Kumar, Shiraz Hashim, linux-arm-kernel, devicetree,
linux-kernel@vger.kernel.org
On 21-10-21, 16:12, Rob Herring wrote:
> On Mon, Oct 4, 2021 at 1:14 AM Viresh Kumar <viresh.kumar@linaro.org> wrote:
> >
> > On 28-09-21, 14:21, Rob Herring wrote:
> > > The spear13xx PCI 'interrupt-map' property is not parse-able.
> > > '#interrupt-cells' is missing and there are 3 #address-cells. Based on the
> > > driver, the only supported interrupt is for MSI. Therefore, 'interrupt-map'
> > > is not needed.
> > >
> > > Cc: Viresh Kumar <vireshk@kernel.org>
> > > Cc: Shiraz Hashim <shiraz.linux.kernel@gmail.com>
> > > Cc: linux-arm-kernel@lists.infradead.org
> > > Signed-off-by: Rob Herring <robh@kernel.org>
> > > ---
> > > arch/arm/boot/dts/spear1310.dtsi | 6 ------
> > > arch/arm/boot/dts/spear1340.dtsi | 2 --
> > > 2 files changed, 8 deletions(-)
> > >
> > > diff --git a/arch/arm/boot/dts/spear1310.dtsi b/arch/arm/boot/dts/spear1310.dtsi
> > > index c4b49baf9804..2f746a9428a7 100644
> > > --- a/arch/arm/boot/dts/spear1310.dtsi
> > > +++ b/arch/arm/boot/dts/spear1310.dtsi
> > > @@ -82,8 +82,6 @@ pcie0: pcie@b1000000 {
> > > reg = <0xb1000000 0x4000>, <0x80000000 0x20000>;
> > > reg-names = "dbi", "config";
> > > interrupts = <0 68 0x4>;
> > > - interrupt-map-mask = <0 0 0 0>;
> > > - interrupt-map = <0x0 0 &gic 0 68 0x4>;
> > > num-lanes = <1>;
> > > phys = <&miphy0 1>;
> > > phy-names = "pcie-phy";
> > > @@ -101,8 +99,6 @@ pcie1: pcie@b1800000 {
> > > reg = <0xb1800000 0x4000>, <0x90000000 0x20000>;
> > > reg-names = "dbi", "config";
> > > interrupts = <0 69 0x4>;
> > > - interrupt-map-mask = <0 0 0 0>;
> > > - interrupt-map = <0x0 0 &gic 0 69 0x4>;
> > > num-lanes = <1>;
> > > phys = <&miphy1 1>;
> > > phy-names = "pcie-phy";
> > > @@ -120,8 +116,6 @@ pcie2: pcie@b4000000 {
> > > reg = <0xb4000000 0x4000>, <0xc0000000 0x20000>;
> > > reg-names = "dbi", "config";
> > > interrupts = <0 70 0x4>;
> > > - interrupt-map-mask = <0 0 0 0>;
> > > - interrupt-map = <0x0 0 &gic 0 70 0x4>;
> > > num-lanes = <1>;
> > > phys = <&miphy2 1>;
> > > phy-names = "pcie-phy";
> > > diff --git a/arch/arm/boot/dts/spear1340.dtsi b/arch/arm/boot/dts/spear1340.dtsi
> > > index 1a8f5e8b10e3..827e887afbda 100644
> > > --- a/arch/arm/boot/dts/spear1340.dtsi
> > > +++ b/arch/arm/boot/dts/spear1340.dtsi
> > > @@ -47,8 +47,6 @@ pcie0: pcie@b1000000 {
> > > reg = <0xb1000000 0x4000>, <0x80000000 0x20000>;
> > > reg-names = "dbi", "config";
> > > interrupts = <0 68 0x4>;
> > > - interrupt-map-mask = <0 0 0 0>;
> > > - interrupt-map = <0x0 0 &gic 0 68 0x4>;
> > > num-lanes = <1>;
> > > phys = <&miphy0 1>;
> > > phy-names = "pcie-phy";
> >
> > Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
>
> Are you going to apply this?
No, you or Arnd can directly apply it. I don't send pull requests for SPEAr
anymore due to very low traffic.
--
viresh
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ARM: dts: spear13xx: Drop malformed 'interrupt-map' on PCI nodes
2021-10-22 4:35 ` Viresh Kumar
@ 2021-10-22 14:07 ` Rob Herring
0 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2021-10-22 14:07 UTC (permalink / raw)
To: Viresh Kumar, SoC Team
Cc: Viresh Kumar, Shiraz Hashim, linux-arm-kernel, devicetree,
linux-kernel@vger.kernel.org
On Thu, Oct 21, 2021 at 11:35 PM Viresh Kumar <viresh.kumar@linaro.org> wrote:
>
> On 21-10-21, 16:12, Rob Herring wrote:
> > On Mon, Oct 4, 2021 at 1:14 AM Viresh Kumar <viresh.kumar@linaro.org> wrote:
> > >
> > > On 28-09-21, 14:21, Rob Herring wrote:
> > > > The spear13xx PCI 'interrupt-map' property is not parse-able.
> > > > '#interrupt-cells' is missing and there are 3 #address-cells. Based on the
> > > > driver, the only supported interrupt is for MSI. Therefore, 'interrupt-map'
> > > > is not needed.
> > > >
> > > > Cc: Viresh Kumar <vireshk@kernel.org>
> > > > Cc: Shiraz Hashim <shiraz.linux.kernel@gmail.com>
> > > > Cc: linux-arm-kernel@lists.infradead.org
> > > > Signed-off-by: Rob Herring <robh@kernel.org>
> > > > ---
> > > > arch/arm/boot/dts/spear1310.dtsi | 6 ------
> > > > arch/arm/boot/dts/spear1340.dtsi | 2 --
> > > > 2 files changed, 8 deletions(-)
> > > >
> > > > diff --git a/arch/arm/boot/dts/spear1310.dtsi b/arch/arm/boot/dts/spear1310.dtsi
> > > > index c4b49baf9804..2f746a9428a7 100644
> > > > --- a/arch/arm/boot/dts/spear1310.dtsi
> > > > +++ b/arch/arm/boot/dts/spear1310.dtsi
> > > > @@ -82,8 +82,6 @@ pcie0: pcie@b1000000 {
> > > > reg = <0xb1000000 0x4000>, <0x80000000 0x20000>;
> > > > reg-names = "dbi", "config";
> > > > interrupts = <0 68 0x4>;
> > > > - interrupt-map-mask = <0 0 0 0>;
> > > > - interrupt-map = <0x0 0 &gic 0 68 0x4>;
> > > > num-lanes = <1>;
> > > > phys = <&miphy0 1>;
> > > > phy-names = "pcie-phy";
> > > > @@ -101,8 +99,6 @@ pcie1: pcie@b1800000 {
> > > > reg = <0xb1800000 0x4000>, <0x90000000 0x20000>;
> > > > reg-names = "dbi", "config";
> > > > interrupts = <0 69 0x4>;
> > > > - interrupt-map-mask = <0 0 0 0>;
> > > > - interrupt-map = <0x0 0 &gic 0 69 0x4>;
> > > > num-lanes = <1>;
> > > > phys = <&miphy1 1>;
> > > > phy-names = "pcie-phy";
> > > > @@ -120,8 +116,6 @@ pcie2: pcie@b4000000 {
> > > > reg = <0xb4000000 0x4000>, <0xc0000000 0x20000>;
> > > > reg-names = "dbi", "config";
> > > > interrupts = <0 70 0x4>;
> > > > - interrupt-map-mask = <0 0 0 0>;
> > > > - interrupt-map = <0x0 0 &gic 0 70 0x4>;
> > > > num-lanes = <1>;
> > > > phys = <&miphy2 1>;
> > > > phy-names = "pcie-phy";
> > > > diff --git a/arch/arm/boot/dts/spear1340.dtsi b/arch/arm/boot/dts/spear1340.dtsi
> > > > index 1a8f5e8b10e3..827e887afbda 100644
> > > > --- a/arch/arm/boot/dts/spear1340.dtsi
> > > > +++ b/arch/arm/boot/dts/spear1340.dtsi
> > > > @@ -47,8 +47,6 @@ pcie0: pcie@b1000000 {
> > > > reg = <0xb1000000 0x4000>, <0x80000000 0x20000>;
> > > > reg-names = "dbi", "config";
> > > > interrupts = <0 68 0x4>;
> > > > - interrupt-map-mask = <0 0 0 0>;
> > > > - interrupt-map = <0x0 0 &gic 0 68 0x4>;
> > > > num-lanes = <1>;
> > > > phys = <&miphy0 1>;
> > > > phy-names = "pcie-phy";
> > >
> > > Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> >
> > Are you going to apply this?
>
> No, you or Arnd can directly apply it. I don't send pull requests for SPEAr
> anymore due to very low traffic.
Sigh. Where is this tribal knowledge documented?
soc@kernel.org should be listed in the MAINTAINERS entry if that is
the case (yes, I know they don't want to be).
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-10-22 14:11 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-09-28 19:21 [PATCH] ARM: dts: spear13xx: Drop malformed 'interrupt-map' on PCI nodes Rob Herring
2021-10-04 6:14 ` Viresh Kumar
2021-10-21 21:12 ` Rob Herring
2021-10-22 4:35 ` Viresh Kumar
2021-10-22 14:07 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).