From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55BE3C433EF for ; Wed, 29 Sep 2021 10:11:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 07DBB6108F for ; Wed, 29 Sep 2021 10:11:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 07DBB6108F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hzWecHHmAbPMqReKByS0VKJCV0VjRUy+axQKTdyzYb4=; b=nu5MAFgx8AFdTZ l1xmuOo5Y5iMqoLwebPeJdz+2lx//48trr0JZyawS9I6cWqGzTgWEMS2NcQ7qpHMzbZSNmkhwbPZK E/z9CNpN6ZOYJLWfcqCeE4rtZcwnPbt6c5xO76PnekD5zPQRJR7iH8a2vM4McWtSnC52O3WppGx5i 3AWdvSA7Z5KTZcvlnTQO0gVfIN3QBFAGSr+HHeDkNzw51h80vZOkLcbvWBdE3KSKkXebjANE+U/fE VAefCbgsnCoQWNsmOgCDLI1qC8T9wWISkRAJOKMxcU8POsu9Rb7zkcTtbaARk/WjZD6NCGgQ8e9BP F07LnhLpSZtOCbpQHPNA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVWXu-00AgQY-L0; Wed, 29 Sep 2021 10:10:38 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVWXr-00AgPm-5p for linux-arm-kernel@lists.infradead.org; Wed, 29 Sep 2021 10:10:36 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id C5A1960FE8; Wed, 29 Sep 2021 10:10:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632910234; bh=6IHLSvP1ghkbN4FLAePFphEp0d1TKXf3K9nSYoznCts=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=S1V/sH/4H3EJ/BmcXmIZpvD4yVuGZuAfNQdj2vBTZQsBId/EZCvalXaGyiKVKz+Ec 5aVsReMKETH94yaATug7Gv5l9OsGW8y0PjnyqCNhOW8VGm1yd6GYJ5HPKSg2+5MWmK tT+ScPofCmeYdR+HpNim8sn3bnNAnpftwVWL+YR9xTa1VnllfApPT2dSKOLRy6tBmL scKLgM/douszxH6mFYLpAO+dLzIkScz5mMBZ2kuV6l6wgM6nYJKw0nKlSfDQC9oB/7 x4hrUCcjBjqMpZ6inq6C+sP0uUrvHRFAW26lJODv2oYEOPCf/9mYiaRMMIXpYAw3UI POfPtCyNgrASA== Date: Wed, 29 Sep 2021 11:10:29 +0100 From: Will Deacon To: Chris Goldsworthy Cc: Catalin Marinas , Andrew Morton , David Hildenbrand , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Sudarshan Rajagopalan Subject: Re: [RFC] arm64: mm: update max_pfn after memory hotplug Message-ID: <20210929101028.GB21057@willie-the-truck> References: <595d09279824faf1f54961cef52b745609b05d97.1632437225.git.quic_cgoldswo@quicinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <595d09279824faf1f54961cef52b745609b05d97.1632437225.git.quic_cgoldswo@quicinc.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210929_031035_254616_52B8FC76 X-CRM114-Status: GOOD ( 16.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 23, 2021 at 03:54:48PM -0700, Chris Goldsworthy wrote: > From: Sudarshan Rajagopalan > > After new memory blocks have been hotplugged, max_pfn and max_low_pfn > needs updating to reflect on new PFNs being hot added to system. > > Signed-off-by: Sudarshan Rajagopalan > Signed-off-by: Chris Goldsworthy > --- > arch/arm64/mm/mmu.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c > index cfd9deb..fd85b51 100644 > --- a/arch/arm64/mm/mmu.c > +++ b/arch/arm64/mm/mmu.c > @@ -1499,6 +1499,11 @@ int arch_add_memory(int nid, u64 start, u64 size, > if (ret) > __remove_pgd_mapping(swapper_pg_dir, > __phys_to_virt(start), size); > + else { > + max_pfn = PFN_UP(start + size); > + max_low_pfn = max_pfn; > + } We use 'max_pfn' as part of the argument to set_max_mapnr(). Does that need updating as well? Do we have sufficient locking to ensure nobody is looking at max_pfn or max_low_pfn while we update them? Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel