From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CC93C433EF for ; Wed, 29 Sep 2021 16:24:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EB019613DA for ; Wed, 29 Sep 2021 16:24:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EB019613DA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HO8qDjaP+7n9LJ6T8tumBRaajvLG1RXD6zLBZKG7Fdo=; b=4r8Z5+1KRgIlsy ++rFfRIGnCBwImP7v2gMAeG0X3mFCXe5ITL1+5hE0roTmQu5SNBHtS8EySpuDLeY7Ez1QJB4ps97o tB7W4yQdUoESGq9qpKrfzuQNvnCV3FPQAyFJbiFA14eLRJI9BreAKJScWBnJ7Bjw30KU18Wm+WF2r GM1z/1e/cEU+ni3OR6ZN1N6x90UcGwNEPIOLDuErrDOVzlC25PHN8KmQXk7df6y7bjGlxmbHh3yp7 CP+gq3aenll4I/GN0tB5Tr4p+6KNCuG6GHiKyiqAP6SKnkKpT1LhKMyso+QZtRg97mvj0ydKUDJnY L7MQ+aszyt/vJn8p8rOw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVcM0-00BnAm-Jf; Wed, 29 Sep 2021 16:22:44 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVcLv-00Bn8q-Ec; Wed, 29 Sep 2021 16:22:40 +0000 Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 275C461246; Wed, 29 Sep 2021 16:22:32 +0000 (UTC) Date: Wed, 29 Sep 2021 17:26:27 +0100 From: Jonathan Cameron To: Cai Huoqing Cc: Linus Walleij , Lars-Peter Clausen , Shawn Guo , Sascha Hauer , "Pengutronix Kernel Team" , Fabio Estevam , "NXP Linux Team" , Vladimir Zapolskiy , "Neil Armstrong" , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Andy Gross , "Bjorn Andersson" , Heiko Stuebner , , , , , , Subject: Re: [PATCH v3 2/9] iio: adc: imx7d_adc: Make use of the helper function dev_err_probe() Message-ID: <20210929172627.1dfd4f17@jic23-huawei> In-Reply-To: <20210928141956.2148-2-caihuoqing@baidu.com> References: <20210928141956.2148-1-caihuoqing@baidu.com> <20210928141956.2148-2-caihuoqing@baidu.com> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210929_092239_548116_17816E3D X-CRM114-Status: GOOD ( 20.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 28 Sep 2021 22:19:48 +0800 Cai Huoqing wrote: > When possible use dev_err_probe help to properly deal with the > PROBE_DEFER error, the benefit is that DEFER issue will be logged > in the devices_deferred debugfs file. > Using dev_err_probe() can reduce code size, and the error value > gets printed. > > Signed-off-by: Cai Huoqing Hi Cai, It is currently not printing a message, but should we handle the same for platform_get_irq? One other minor comment inline. Actual change here is fine. Thanks, Jonathan > --- > drivers/iio/adc/imx7d_adc.c | 16 +++++----------- > 1 file changed, 5 insertions(+), 11 deletions(-) > > diff --git a/drivers/iio/adc/imx7d_adc.c b/drivers/iio/adc/imx7d_adc.c > index 4969a5f941e3..f47360cbff3b 100644 > --- a/drivers/iio/adc/imx7d_adc.c > +++ b/drivers/iio/adc/imx7d_adc.c > @@ -496,19 +496,13 @@ static int imx7d_adc_probe(struct platform_device *pdev) > return irq; > > info->clk = devm_clk_get(dev, "adc"); > - if (IS_ERR(info->clk)) { > - ret = PTR_ERR(info->clk); > - dev_err(dev, "Failed getting clock, err = %d\n", ret); > - return ret; > - } > + if (IS_ERR(info->clk)) > + return dev_err_probe(dev, PTR_ERR(info->clk), "Failed getting clock\n"); Where it doesn't hurt readabilty preferred to keep below 80 chars. > > info->vref = devm_regulator_get(dev, "vref"); > - if (IS_ERR(info->vref)) { > - ret = PTR_ERR(info->vref); > - dev_err(dev, > - "Failed getting reference voltage, err = %d\n", ret); > - return ret; > - } > + if (IS_ERR(info->vref)) > + return dev_err_probe(dev, PTR_ERR(info->vref), > + "Failed getting reference voltage\n"); > > platform_set_drvdata(pdev, indio_dev); > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel