From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B613FC433F5 for ; Wed, 29 Sep 2021 16:38:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8336A61411 for ; Wed, 29 Sep 2021 16:38:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8336A61411 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nYh5bDAsnNq7PyeXF0XO1sOY7Dfiib5lZzb+bcPjPaI=; b=CvBz8NA4EpNl5c /WHkoq3SuiPv8fwLEMT1z+XLKzOF0tSEceN0Y72CeNQtgGrkZvf0vpn12vbfbH2hno/eqvtN1MlnX TYmdUeAXQHhY3rUO/SK93E2IW/pgdj4gkfC7fmbyQXcSf64Ufz45J+QujsUzGU3CjfaKfUSBeN7pT ECQmT6wYQiYVPX7V7TD7aTa2/EBpE0Gywz6dnTiAmiL2+mh+uU74oR2tVmHrlTD6jUnY7z7bJ0DKZ hbR/QfHxI1wrn7YhKBidw0iPb86vB/5mP8yU79+r1J69Xzja0cKqLacCnpR7uNklyTJF22qqvvKkK VyllSM3iqXCzfSaJlZ4w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVcZQ-00Bpyx-OA; Wed, 29 Sep 2021 16:36:36 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVcZL-00Bpy9-Mb; Wed, 29 Sep 2021 16:36:32 +0000 Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BFC20613D0; Wed, 29 Sep 2021 16:36:25 +0000 (UTC) Date: Wed, 29 Sep 2021 17:40:19 +0100 From: Jonathan Cameron To: Cai Huoqing Cc: Linus Walleij , Lars-Peter Clausen , Shawn Guo , Sascha Hauer , "Pengutronix Kernel Team" , Fabio Estevam , "NXP Linux Team" , Vladimir Zapolskiy , "Neil Armstrong" , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Andy Gross , "Bjorn Andersson" , Heiko Stuebner , , , , , , Subject: Re: [PATCH v3 5/9] iio: adc: max1241: Make use of the helper function dev_err_probe() Message-ID: <20210929174019.3f93dfde@jic23-huawei> In-Reply-To: <20210928141956.2148-5-caihuoqing@baidu.com> References: <20210928141956.2148-1-caihuoqing@baidu.com> <20210928141956.2148-5-caihuoqing@baidu.com> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210929_093631_790794_215E39A0 X-CRM114-Status: GOOD ( 20.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 28 Sep 2021 22:19:51 +0800 Cai Huoqing wrote: > When possible use dev_err_probe help to properly deal with the > PROBE_DEFER error, the benefit is that DEFER issue will be logged > in the devices_deferred debugfs file. > Using dev_err_probe() can reduce code size, and the error value > gets printed. > > Signed-off-by: Cai Huoqing Hi Cai, Please also add a message to the devm_gpiod_get_optional() and similar handling so that we maintain information on that as well. Thanks, Jonathan > --- > drivers/iio/adc/max1241.c | 14 ++++++-------- > 1 file changed, 6 insertions(+), 8 deletions(-) > > diff --git a/drivers/iio/adc/max1241.c b/drivers/iio/adc/max1241.c > index b60f8448f21a..130ca8dc6fa0 100644 > --- a/drivers/iio/adc/max1241.c > +++ b/drivers/iio/adc/max1241.c > @@ -148,10 +148,9 @@ static int max1241_probe(struct spi_device *spi) > mutex_init(&adc->lock); > > adc->vdd = devm_regulator_get(dev, "vdd"); > - if (IS_ERR(adc->vdd)) { > - dev_err(dev, "failed to get vdd regulator\n"); > - return PTR_ERR(adc->vdd); > - } > + if (IS_ERR(adc->vdd)) > + return dev_err_probe(dev, PTR_ERR(adc->vdd), > + "failed to get vdd regulator\n"); > > ret = regulator_enable(adc->vdd); > if (ret) > @@ -164,10 +163,9 @@ static int max1241_probe(struct spi_device *spi) > } > > adc->vref = devm_regulator_get(dev, "vref"); > - if (IS_ERR(adc->vref)) { > - dev_err(dev, "failed to get vref regulator\n"); > - return PTR_ERR(adc->vref); > - } > + if (IS_ERR(adc->vref)) > + return dev_err_probe(dev, PTR_ERR(adc->vref), > + "failed to get vref regulator\n"); > > ret = regulator_enable(adc->vref); > if (ret) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel