From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D23AC433F5 for ; Thu, 30 Sep 2021 17:49:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4F485619F6 for ; Thu, 30 Sep 2021 17:49:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4F485619F6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+4vy7ZfPxSbmSqiEZdvDNIeVVErlEhuP8nwJ1E9XjnA=; b=IML91DQvy0+J23 ApNPigYxSFmxrjegFk1ZDwWZ26E2A0sp/MfocRTPNEcXxb7lqY+QF1umZUSUMRmgFimczri/V8Wih lAp1EFf4jjfg5wg6qo5RfikZUF8JGs9vl3y3tsg9TyEpg+3NpC4TMSkDH7VgQY3sp8VmX3+cAEmFd 4GB1xDGzVvORFwuz4ibC6xz6Wqog7ZkwMrCH5pR0IQ5xNS5ieJKNnXJFW362XFiW+ZMscNHjcBfMs mtSkXlKcxNRz+L/uSk7LEhJ2B7Mtn196LG2adxfBcwYypRclxoMMgJF7+hvEWBqeAW0xDt5Ul1XrH /rpPSpusyrct9MPAGxNA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mW09X-00FOxc-TZ; Thu, 30 Sep 2021 17:47:28 +0000 Received: from mail-pl1-x62b.google.com ([2607:f8b0:4864:20::62b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mW09S-00FOw9-8r for linux-arm-kernel@lists.infradead.org; Thu, 30 Sep 2021 17:47:25 +0000 Received: by mail-pl1-x62b.google.com with SMTP id j4so3108193plx.4 for ; Thu, 30 Sep 2021 10:47:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+IS0gEgo7hipR9gibsQw5KtPLx6dQXKFRc1+dywoXVA=; b=m0rDM0cnK0yrtL29pL81MAGf7w2Yed+jc4KUJF0fL6YCvGOj2OOT/73pX0N1cuLGzf ECJdJfF5q+Tu3Vs0H54vg8YCX4POSPt/jTDx97+sRolpUheG7qnd3LACShH3YDUGL+oL edpJws/IQ1QQ+9i+FXscZHebVHzxRo9Z53ybE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+IS0gEgo7hipR9gibsQw5KtPLx6dQXKFRc1+dywoXVA=; b=qekYcmvZocce5Wuk0hqZvmHKn8YsMRSyfCg8JdRs8oSqClwrWUx25kiNTTxo3BTzvL Pvx15GSvfFIh/H92ACllXtls2KehgOxDywDxnw3tECRMENJ2Ty/BiO6+/tLDag7OYZub 06locEncWwSEQrQPQWSeXEyTYQdYfdwMazK+1YRy4Lh9tgjSKXRJTtY4PPLnM33kiPqP F0ORInuSJGsFiB1Xg27rx5FWcS6ebzanhE6OPP2uzQehiGurH5UXDQHko6Tle22rUT86 TxXInqTp+XtXbWKzHqUJfTDb4nMQejGNKFJhKoNM/uQJIpR86V+1ObOvSd5C96aBV3Vo /hIA== X-Gm-Message-State: AOAM533L8T157D5T8TfM8iLG3jj3YfJPSGUwYneMxEkptYCF1sujYeAR IPu0fdkl9BLehP51zqHSkpowBA== X-Google-Smtp-Source: ABdhPJwKcuP6DGDrVJJap2YBfnw9gJ29cZ6T8aj/WEWFIltD4Sz9lDFqVeOwFghXxQzDWleVwS3vJg== X-Received: by 2002:a17:902:e74d:b0:13e:77cd:a300 with SMTP id p13-20020a170902e74d00b0013e77cda300mr2394421plf.80.1633024041447; Thu, 30 Sep 2021 10:47:21 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id x19sm3606048pfn.105.2021.09.30.10.47.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Sep 2021 10:47:20 -0700 (PDT) Date: Thu, 30 Sep 2021 10:47:19 -0700 From: Kees Cook To: Michael Ellerman Cc: Ard Biesheuvel , Linux Kernel Mailing List , Keith Packard , Russell King , Catalin Marinas , Will Deacon , Benjamin Herrenschmidt , Christophe Leroy , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Peter Zijlstra , Andy Lutomirski , Linus Torvalds , Arnd Bergmann , Linux ARM , "open list:LINUX FOR POWERPC (32-BIT AND 64-BIT)" , linux-riscv , "open list:S390" Subject: Re: [RFC PATCH 4/8] powerpc: add CPU field to struct thread_info Message-ID: <202109301045.15DDDA0B@keescook> References: <20210914121036.3975026-1-ardb@kernel.org> <20210914121036.3975026-5-ardb@kernel.org> <87ee99lii7.fsf@mpe.ellerman.id.au> <87pmst1rn9.fsf@mpe.ellerman.id.au> <878rzf0zmb.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <878rzf0zmb.fsf@mpe.ellerman.id.au> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210930_104722_368044_4CE5A325 X-CRM114-Status: GOOD ( 31.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 30, 2021 at 08:46:04AM +1000, Michael Ellerman wrote: > Ard Biesheuvel writes: > > On Tue, 28 Sept 2021 at 02:16, Michael Ellerman wrote: > >> > >> Michael Ellerman writes: > >> > Ard Biesheuvel writes: > >> >> On Tue, 14 Sept 2021 at 14:11, Ard Biesheuvel wrote: > >> >>> > >> >>> The CPU field will be moved back into thread_info even when > >> >>> THREAD_INFO_IN_TASK is enabled, so add it back to powerpc's definition > >> >>> of struct thread_info. > >> >>> > >> >>> Signed-off-by: Ard Biesheuvel > >> >> > >> >> Michael, > >> >> > >> >> Do you have any objections or issues with this patch or the subsequent > >> >> ones cleaning up the task CPU kludge for ppc32? Christophe indicated > >> >> that he was happy with it. > >> > > >> > No objections, it looks good to me, thanks for cleaning up that horror :) > >> > > >> > It didn't apply cleanly to master so I haven't tested it at all, if you can point me at a > >> > git tree with the dependencies I'd be happy to run some tests over it. > >> > >> Actually I realised I can just drop the last patch. > >> > >> So that looks fine, passes my standard quick build & boot on qemu tests, > >> and builds with/without stack protector enabled. > >> > > > > Thanks. > > > > Do you have any opinion on how this series should be merged? Kees Cook > > is willing to take them via his cross-arch tree, or you could carry > > them if you prefer. Taking it via multiple trees at the same time is > > going to be tricky, or take two cycles, with I'd prefer to avoid. > > I don't really mind. If Kees is happy to take it then that's OK by me. > > If Kees put the series in a topic branch based off rc2 then I could > merge that, and avoid any conflicts. I've created: git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git for-next/thread_info/cpu it includes a --no-ff merge commit, which I'm not sure is desirable? Let me know if I should adjust this, or if Linus will yell about this if I send him a PR containing a merge commit? I'm not sure what's right here. Thanks! -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel