From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 023D6C433EF for ; Thu, 30 Sep 2021 18:00:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C49F2619F6 for ; Thu, 30 Sep 2021 18:00:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C49F2619F6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Z1wJmA7BvVia/k6n00IiuuBMDlDvQ8VsslM5RYpAIik=; b=XmM37rQdnVJl+E LKWOxVjzu1+mLrgv8NF0FwVOKkNT0VT2FOqgEQgY+6Ooaf1euV/0bMVha82w5o40BnURCSQ1o/CBh jPqFRDlraeYtdzuiDTDZWteiQmpZtPUlsdy+JAAYCGwdIaUJkSZ/xaIH9dj86gmJNSjwU5b3G0Vyo gDa+WY36RhnZIr7GvN2Q3ZLpz4UGD3CbctIwGdPJ7RdZOplQFr7ELb4BhHYcepLojiLHdyLkWDYo+ F2fC3U4DjRE5mQd+Xa5wObxLHM9X0EZvz3NQlegoIYLA5AIgX9uuusDB16eGP37zgCOkZ/ZIsd/MH NCISx86QrF/sRI7d4ATQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mW0Jl-00FQXZ-4P; Thu, 30 Sep 2021 17:58:01 +0000 Received: from mail-pg1-x531.google.com ([2607:f8b0:4864:20::531]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mW0Jh-00FQWi-5A for linux-arm-kernel@lists.infradead.org; Thu, 30 Sep 2021 17:57:58 +0000 Received: by mail-pg1-x531.google.com with SMTP id h3so7058158pgb.7 for ; Thu, 30 Sep 2021 10:57:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=g6bz22D6xwh6dY6ebf3YVMVwbapBNBp7nh6i3iRX4rg=; b=dOKiID32WTuG8C1FY2tDSCXxPTOcTSojqkYxtMXC81eBn/3A6Aez9SSrNtOe43/vqZ r14bP3+HhfILcH+mSy8qbeihv9hjIQXbOsvQAQoJGyCKi69gMmOvcfw3hK26OXgksxet 6+FGEby1cJgq/DR2sx0qdTMffsxJehFBI0/Jf/sVsQgmrcbIcBz6EdQNrgyPsTt1ZPgS ZCrOOjiBSKNIPp+/HCaTNKw6aPf7kK6fUNTW2E3WZsyf88X/+1OL9qKMSq5fRaxxt2F7 DIRuiz0ePqm6/qsgCz/Hfrbu/DHfLIfGouCHbrROrDb5RKPxOQPBaXqRmADH9pI1E8cY amAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=g6bz22D6xwh6dY6ebf3YVMVwbapBNBp7nh6i3iRX4rg=; b=k9kzfhh4B5y/imGTr7CNKRrG8vIa95OEJtPtsyOizsuBCPMh4nFMwkTQBnWDNyuJAu Q6SZWvrKvUb1ZuZDrNUuSncrZAXxpDMP2StWe2nGIo5cuL8EgxeTusA4mbWVfQoFEuEc qniNQtDUQ733Zb5Tyku6BTIkNcrpO78+fJ15H00Jh1BuzRJUe4ApFkOqAgFh3PR+rLLY NkI7ozIDU2nce02QyNN5qD0nEI1BlCsyjMfHKiEHexF0ixyzjVSw9H7+Gqblhinv2Txy 2JgIDMAbJ8cFOKuHwDMqdUXG8rlbQ3NxqztxSfx8mwrGp2/X0MolhdN+84T9sELWCZFs BA0w== X-Gm-Message-State: AOAM533YD74OG6odJZlfo4U+O+H6/s6fVAatNwIKQkCqXsKc9K7L7Phg ndA0RXd/EmCFfDJGrfk+t7w3gw== X-Google-Smtp-Source: ABdhPJxFoKp6KZ5DBAWAIpSMmQfLSbSbpU7b0scWhFG5joQHGKa00Znngko+61mQV7anI0cielGpPw== X-Received: by 2002:aa7:8887:0:b0:43c:83fe:2c56 with SMTP id z7-20020aa78887000000b0043c83fe2c56mr5591779pfe.82.1633024674520; Thu, 30 Sep 2021 10:57:54 -0700 (PDT) Received: from p14s (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id s188sm3436085pfb.44.2021.09.30.10.57.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Sep 2021 10:57:53 -0700 (PDT) Date: Thu, 30 Sep 2021 11:57:51 -0600 From: Mathieu Poirier To: Suzuki K Poulose Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, maz@kernel.org, catalin.marinas@arm.com, mark.rutland@arm.com, james.morse@arm.com, anshuman.khandual@arm.com, leo.yan@linaro.org, mike.leach@linaro.org, will@kernel.org, lcherian@marvell.com, coresight@lists.linaro.org Subject: Re: [PATCH v2 01/17] coresight: trbe: Fix incorrect access of the sink specific data Message-ID: <20210930175751.GC3047827@p14s> References: <20210921134121.2423546-1-suzuki.poulose@arm.com> <20210921134121.2423546-2-suzuki.poulose@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210921134121.2423546-2-suzuki.poulose@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210930_105757_226130_C1FD89D3 X-CRM114-Status: GOOD ( 18.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 21, 2021 at 02:41:05PM +0100, Suzuki K Poulose wrote: > The TRBE driver wrongly treats the aux private data as the TRBE driver > specific buffer for a given perf handle, while it is the ETM PMU's > event specific data. Fix this by correcting the instance to use > appropriate helper. > > Fixes: 3fbf7f011f242 ("coresight: sink: Add TRBE driver") > Signed-off-by: Suzuki K Poulose > --- > drivers/hwtracing/coresight/coresight-trbe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hwtracing/coresight/coresight-trbe.c b/drivers/hwtracing/coresight/coresight-trbe.c > index d4c57aed05e5..e3d73751d568 100644 > --- a/drivers/hwtracing/coresight/coresight-trbe.c > +++ b/drivers/hwtracing/coresight/coresight-trbe.c > @@ -363,7 +363,7 @@ static unsigned long __trbe_normal_offset(struct perf_output_handle *handle) > > static unsigned long trbe_normal_offset(struct perf_output_handle *handle) > { > - struct trbe_buf *buf = perf_get_aux(handle); > + struct trbe_buf *buf = etm_perf_sink_config(handle); I really wonder how things got to work before... I have fixed the 13-character SHA in the "Fixes" tag and added this patch to my local tree. More comments tomorrow. Thanks, Mathieu > u64 limit = __trbe_normal_offset(handle); > u64 head = PERF_IDX2OFF(handle->head, buf); > > -- > 2.24.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel