From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7D9EC433F5 for ; Fri, 1 Oct 2021 09:09:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ACED660FC1 for ; Fri, 1 Oct 2021 09:09:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org ACED660FC1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Pl3hWsHVfUsR9D/G57TpeJYFem5mwzW0/OllE7lPelk=; b=v0X2Arsyv6tnCs T/odrt0V5gDn3aBTRtJGbZB9KqZM/duTnZHUjU4RbeiqK/g17TSMd3u5DoRTlsxLrAJuvnmYKJpBt zzZSG2llShEbm9J1tO/1xaiOkuBlUIFpzc+deu//GBgR5OI1R9VWlyR5Kwb7M4TD9j6G2wisCvOQa 3EP91CUo59sKnrqOTcuKTBm+4fehYLL/5ajVOnr+Ss1jgMXxQyHFaN0WypU1cM0BYj8ReO0ZfHrQf YU+Q0BsGpaZ7MqXe1jyTkCqaTtG8K5J1aCeT4+uUJf2I6gBJJN75p7PB6Zueo6B0pAZ39B85P7F4o 2/D/LjZXQEuRAq6E31zA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mWEWC-00HASm-V0; Fri, 01 Oct 2021 09:07:49 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mWEW9-00HARi-UK for linux-arm-kernel@lists.infradead.org; Fri, 01 Oct 2021 09:07:47 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mWEW8-0005y6-MX; Fri, 01 Oct 2021 11:07:44 +0200 Received: from mtr by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1mWEW8-0005Rq-53; Fri, 01 Oct 2021 11:07:44 +0200 Date: Fri, 1 Oct 2021 11:07:44 +0200 From: Michael Tretter To: Michal Simek Cc: linux-arm-kernel@lists.infradead.org, rajan.vaja@xilinx.com, jolly.shah@xilinx.com Subject: Re: [PATCH v2 0/4] soc: xilinx: pm_domains: cleanup and fix PM_INIT_FINALIZE Message-ID: <20211001090744.GE28226@pengutronix.de> References: <20210825150313.4033156-1-m.tretter@pengutronix.de> <36fee5a7-6c6e-9f93-0ab9-a96967b70919@xilinx.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <36fee5a7-6c6e-9f93-0ab9-a96967b70919@xilinx.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 11:00:25 up 225 days, 12:24, 134 users, load average: 0.40, 0.25, 0.25 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: mtr@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211001_020745_997953_5CB50DFE X-CRM114-Status: GOOD ( 25.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Fri, 27 Aug 2021 10:00:59 +0200, Michal Simek wrote: > On 8/25/21 5:03 PM, Michael Tretter wrote: > > This is v2 of the series to cleanup and fix the zynqmp_pm_domains driver [0]. > > > > Patch 1 of this series fixes the ZynqMP PMU FW power management > > initialization, which was done by the wrong driver. PM_INIT_FINALIZE must be > > called from the zynqmp_pm_domains driver, which handles power domains, instead > > of the zynmp_power driver, which is responsible for suspend and shutdown. As a > > side effect, PM_INIT_FINALIZE powers down all devices that have not been > > requested, which might lead to misbehaving devices. Calling it from the > > sync_state callback ensures that all consumers have probed and are able to > > handle power management themselves. > > > > Patches 2 to 4 are various cleanup patches to improve the readability and > > debugging experience of the zynqmp_pm_domains driver. > > > > Michael > > > > [0] https://lore.kernel.org/linux-arm-kernel/20210317160410.2097178-1-m.tretter@pengutronix.de/ > > > > Changelog: > > > > v2: > > > > - move PM_INIT_FINALIZE to sync_state callback > > > > Michael Tretter (4): > > soc: xilinx: move PM_INIT_FINALIZE to zynqmp_pm_domains driver > > soc: xilinx: cleanup debug and error messages > > soc: xilinx: use a properly named field instead of flags > > soc: xilinx: add a to_zynqmp_pm_domain macro > > > > drivers/soc/xilinx/zynqmp_pm_domains.c | 91 +++++++++++++++----------- > > drivers/soc/xilinx/zynqmp_power.c | 1 - > > 2 files changed, 51 insertions(+), 41 deletions(-) > > > > Rajan: Please test and ack. > > It looks good to me. > Acked-by: Michal Simek Gentle ping. Michael _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel