From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 673F6C433EF for ; Fri, 1 Oct 2021 09:32:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 32C44610A3 for ; Fri, 1 Oct 2021 09:32:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 32C44610A3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zGthRbfIQj4EYsAxzaXJehq/JCahRz++QZUCeTC08L8=; b=2OZR1E+2Mqlan7 ZXQHSWI2ZpJW5XRaLuRK4w/j5CLiXgj71sZgkASksq3xfcb1lHG4zmh+EU/sUE9PDWYgMLCWMlEnH LrOpdbI/dvbVijVF8PDCkrNKbhlAAFYqXq/+mi5sRQQ3eTyps4EoTVc8bZ2PPRwL4pM+XGrLgHgFZ 32Dr5lqOL7HOy7Aoqq0eO9k0YVcEsimiekuZ2pZBX4ceZw62Y+L2rKQ351mNps3kS9HFtEAwXcmO1 KQyi+DhzYbw4t7DAVZiNo3ji61CmZ2PI58RWoaUx8c7S674FYgrjzZmoSLyZ3R1BTRVZBYgx1dn9u weIeWu75MLJQnR9eXJWQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mWEs2-00HFD7-Jk; Fri, 01 Oct 2021 09:30:22 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mWErw-00HFBj-Mj for linux-arm-kernel@lists.infradead.org; Fri, 01 Oct 2021 09:30:18 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D7AAC101E; Fri, 1 Oct 2021 02:30:15 -0700 (PDT) Received: from bogus (unknown [10.57.26.136]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7CE7D3F70D; Fri, 1 Oct 2021 02:30:13 -0700 (PDT) Date: Fri, 1 Oct 2021 10:29:39 +0100 From: Sudeep Holla To: Jens Wiklander Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, op-tee@lists.trustedfirmware.org, Sumit Garg , Marc Bonnici , Sudeep Holla , Jerome Forissier , sughosh.ganu@linaro.org Subject: Re: [PATCH v5 0/5] Add FF-A support in OP-TEE driver Message-ID: <20211001092939.heiskb5gqzx3nd7p@bogus> References: <20210831072412.887565-1-jens.wiklander@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210831072412.887565-1-jens.wiklander@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211001_023016_834061_B9250800 X-CRM114-Status: GOOD ( 25.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 31, 2021 at 09:24:07AM +0200, Jens Wiklander wrote: > Hi all, > > This adds supports for the OP-TEE driver to communicate with secure world > using FF-A [1] as transport. > > There is one change to the TEE subsystem with "tee: add sec_world_id to > struct tee_shm" to add support for holding globally unique handle assigned > by the FF-A. This is a field that I believe could useful for the AMDTEE > driver too. > > For communication the OP-TEE message protocol is still used, but with a new > type of memory reference, struct optee_msg_param_fmem, to carry the > information needed by FF-A. The OP-TEE driver is refactored internally with > to sets of callbacks, one for the old SMC based communication and another > set with FF-A as transport. The functions relating to the SMC based ABI > are moved to smc_abi.c while the FF-A based ABI is added in a ffa_abi.c. > > There is also a difference in how the drivers are instantiated. With the > SMC based transport we have a platform driver, module_platform_driver(), > today which we're keeping as is for this configuration. In a FF-A system we > have a FF-A driver, module_ffa_driver(), instead. > > The OP-TEE driver can be compiled for both targets at the same time and > it's up to runtime configuration (device tree or ACPI) to decide how it's > initialized. Note that it's only the old SMC based driver instance that > need device tree or ACPI to initialize. The FF-A based driver relies on the > FF-A bus instead. > > This can be tested QEMU > The repo for SPMC at S-EL1 retrieved by > repo init -u https://github.com/jenswi-linaro/manifest.git -m > qemu_v8.xml -b ffav4_spmc > repo sync > # Then checkout the branch optee_ffa_v5 from > # git://git.linaro.org/people/jens.wiklander/linux-tee.git > # in the linux directory > > To build do: > cd build > make toolchains > make all > > To boot: > make run-only > > Test with xtest, perhaps only with the command "xtest 1004" in case you're > not interested in too many tests. > Ran entire xtest test suite with latest TF-A, hafinum and OPTEE. So for the series, Tested-by: Sudeep Holla Minor comments to address OPTEE as module when FFA is also built as module. FFA as a module couple of bugs(thanks for reporting one of them). I have the fixes here[1], please test and provide feedback. -- Regards, Sudeep [1] https://lore.kernel.org/linux-arm-kernel/20210924092859.3057562-1-sudeep.holla@arm.com/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel