linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Alan Stern <stern@rowland.harvard.edu>
To: Hayes Wang <hayeswang@realtek.com>
Cc: Oliver Neukum <oneukum@suse.com>,
	Jason-ch Chen <jason-ch.chen@mediatek.com>,
	"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	 "linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>,
	"Project_Global_Chrome_Upstream_Group@mediatek.com"
	<Project_Global_Chrome_Upstream_Group@mediatek.com>,
	 "hsinyi@google.com" <hsinyi@google.com>,
	nic_swsd <nic_swsd@realtek.com>
Subject: Re: [PATCH] r8152: stop submitting rx for -EPROTO
Date: Fri, 1 Oct 2021 11:22:26 -0400	[thread overview]
Message-ID: <20211001152226.GA505557@rowland.harvard.edu> (raw)
In-Reply-To: <5f56b21575dd4f64a3b46aac21151667@realtek.com>

On Fri, Oct 01, 2021 at 03:26:48AM +0000, Hayes Wang wrote:
> > Alan Stern <stern@rowland.harvard.edu>
> > [...]
> > > There has been some discussion about this in the past.
> > >
> > > In general, -EPROTO is almost always a non-recoverable error.
> > 
> > Excuse me. I am confused about the above description.
> > I got -EPROTO before, when I debugged another issue.
> > However, the bulk transfer still worked after I resubmitted
> > the transfer. I didn't do anything to recover it. That is why
> > I do resubmission for -EPROTO.
> 
> I check the Linux driver and the xHCI spec.
> The driver gets -EPROTO for bulk transfer, when the host
> returns COMP_USB_TRANSACTION_ERROR.
> According to the spec of xHCI, USB TRANSACTION ERROR
> means the host did not receive a valid response from the
> device (Timeout, CRC, Bad PID, unexpected NYET, etc.).

That's right.  If the device and cable are working properly, this 
should never happen.  Or only extremely rarely (for example, caused 
by external electromagnetic interference).

> It seems to be reasonable why resubmission sometimes works.

Did you ever track down the reason why you got the -EPROTO error 
while debugging that other issue?  Can you reproduce it?

Alan Stern

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-10-01 15:24 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-29  5:18 [PATCH] r8152: stop submitting rx for -EPROTO Jason-ch Chen
2021-09-29  8:14 ` Hayes Wang
2021-09-29  9:52   ` Jason-ch Chen
2021-09-30  2:41     ` Hayes Wang
2021-10-01  1:36       ` Jason-ch Chen
2021-09-30  9:30     ` Oliver Neukum
2021-09-30 15:18       ` Alan Stern
2021-10-01  2:40         ` Hayes Wang
2021-10-01  3:26           ` Hayes Wang
2021-10-01 15:22             ` Alan Stern [this message]
2021-10-04  2:15               ` Hayes Wang
2021-10-04 11:44               ` Oliver Neukum
2021-10-04 14:33                 ` Alan Stern
2021-09-30 16:13       ` Hayes Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211001152226.GA505557@rowland.harvard.edu \
    --to=stern@rowland.harvard.edu \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=hayeswang@realtek.com \
    --cc=hsinyi@google.com \
    --cc=jason-ch.chen@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=nic_swsd@realtek.com \
    --cc=oneukum@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).