From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAEDEC433FE for ; Mon, 4 Oct 2021 16:53:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 76E5C61354 for ; Mon, 4 Oct 2021 16:53:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 76E5C61354 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LedP6KA/hrRItoMsMqUSIh18FvSHBH5HWBcVNc7lnTk=; b=TShGHz7aEqZb66 EwNnvlBBYNdcE1elW2FWOMTHDdtWPTEexdqHiA5NB26JOThoEfF/D4usZyk7V1XwLVi2cVE5pGcxX 20hjIwT/TlIl4EJREEYolVQNC8f1TylqsGnYqT8NMIn/MygNhm0/JvTHmz7BMZ0b1FNgBg6xbM3Ey sl9QQOLvLX4l9C8IPtmR7hhTidJYRpygbO4DMHWmZ11tsqeM9JxpZqs9bajs46pXRL+Sn76jYwgP/ FCbSy8tMW6uGp8o5yPX50tkmajmwpKbcahNCevUEQDx8IyNlZu2+IFVzGdL2fhLkPR1xmEIXNyzUp O7QMxETCCUT+7dwyMX+g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mXRBe-007Bsv-HH; Mon, 04 Oct 2021 16:51:34 +0000 Received: from mail-qt1-x82d.google.com ([2607:f8b0:4864:20::82d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mXRBa-007Brq-Kj for linux-arm-kernel@lists.infradead.org; Mon, 04 Oct 2021 16:51:32 +0000 Received: by mail-qt1-x82d.google.com with SMTP id e16so6288397qte.13 for ; Mon, 04 Oct 2021 09:51:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=fm0N+uR1hXDzNubZl52j+8JgNSoL4ihvsWR45BnPk0U=; b=fONFgNJfZDZei6PZNVpZuBiLsJj1X5q23bUBDHR6Fuxaodm1hwle2aSXXPZVhQpqj9 /ElI7DyN32U6z+PhNlz1pYV8PPs8OQn/iFlypBkab16easskT0oRAko11Dw8EcB06gh3 CT8v9N1IlFy843LfazZZljBlqka49vpAeBfatzveca+w8ZlAxXkZUlYcmf+sEfKG76u1 TY3Qw27XfzNUrJYbeVCCKzCM9MyLRwvqODBB2+ZIY6INJBFgZ0vzDFcU4588yCEQbWfI VrxXG8yZyLHHstArVfuqbBlnxD2yIw4Q9BeabvwIFlg/VlzoHYsVmsWnFXrwI3rskJ6H T5Iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=fm0N+uR1hXDzNubZl52j+8JgNSoL4ihvsWR45BnPk0U=; b=Jc6E52sQ7SJgaatl7CbcPooAagdPooKDWMvmiJ+engFoguLJ6vPOgQpNNfgeZEJM84 UmA267MzWbAiZ6qkqExc4uEVRP+HgYAPS91M974/EOn0ghvCv+4q+TvNZFtePAY1F6qS z2SzswjQ577bEplNk+qpWQisZRUc40Z/Cucc+ORYQDA8wBKNRPTzSpMPJdGHpe8H+5Hz C7Wg6DZXksRHIJYDn/gUU+MRmOEYJDvtUJ4o5+27xHpwsOLwON8HFNvorIhhSK/Kd1cX GlIuXmRL8qviHO6/BwnpFuiFAfB7HmIeS3ZUz9BZQAiJedHCLaago9wGgIn9R1KpXp+A N3Rg== X-Gm-Message-State: AOAM533E7U0407nK5Se+7HXNGyBh3aFXnz8Mrr3dSv1DZ+mFWpdjPA6F zH5Jc9XKmMO/V9c3YnA9A8TqIA== X-Google-Smtp-Source: ABdhPJwYxtXAD8Z3ExxCEQ19TzIoVR9HRb32/NI/yIjc3B407LzHe5QYs0z4lz+/49EyQ9oJMCYpoQ== X-Received: by 2002:ac8:4610:: with SMTP id p16mr6740796qtn.98.1633366289243; Mon, 04 Oct 2021 09:51:29 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-162-113-129.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.113.129]) by smtp.gmail.com with ESMTPSA id l26sm974766qkj.38.2021.10.04.09.51.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Oct 2021 09:51:28 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1mXRBX-00AXAU-Qu; Mon, 04 Oct 2021 13:51:27 -0300 Date: Mon, 4 Oct 2021 13:51:27 -0300 From: Jason Gunthorpe To: Florian Fainelli Cc: Mark Brown , Lino Sanfilippo , rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, nsaenz@kernel.org, linux-spi@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, p.rosenberger@kunbus.com, linux-integrity@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] spi: bcm2835: do not unregister controller in shutdown handler Message-ID: <20211004165127.GZ3544071@ziepe.ca> References: <20210928195657.5573-1-LinoSanfilippo@gmx.de> <20211001175422.GA53652@sirena.org.uk> <2c4d7115-7a02-f79e-c91b-3c2dd54051b2@gmx.de> <20211004131756.GW3544071@ziepe.ca> <20211004154436.GY3544071@ziepe.ca> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211004_095130_777009_087DBC10 X-CRM114-Status: GOOD ( 16.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 04, 2021 at 09:36:37AM -0700, Florian Fainelli wrote: > No please don't, I should have arguably justified the reasons why > better, but the main reason is that one of the platforms on which this > driver is used has received extensive power management analysis and > changes, and shutting down every bit of hardware, including something as > small as a SPI controller, and its clock (and its PLL) helped meet > stringent power targets. Huh? for device shutdown? What would this matter if the next step is reboot or power off? > TBH, I still wonder why we have .shutdown() and we simply don't use > .remove() which would reduce the amount of work that people have to do > validate that the hardware is put in a low power state and would also > reduce the amount of burden on the various subsystems. The difference between remove and shutdown really is that 'emergency' sense that shutdown is something that must complete in bounded time and thus only has to concern itself with quieting hardware to a safe state for the next step in the shutdown/reboot/kexec/kdump sequence. Many remove handlers happily block until, eg all user files are closed or something to allow a graceful module unload. Jason _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel