From: Jason Gunthorpe <jgg@ziepe.ca>
To: Mark Brown <broonie@kernel.org>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Lino Sanfilippo <LinoSanfilippo@gmx.de>,
rjui@broadcom.com, sbranden@broadcom.com,
bcm-kernel-feedback-list@broadcom.com, nsaenz@kernel.org,
linux-spi@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, p.rosenberger@kunbus.com,
linux-integrity@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] spi: bcm2835: do not unregister controller in shutdown handler
Date: Mon, 4 Oct 2021 14:35:31 -0300 [thread overview]
Message-ID: <20211004173531.GB3544071@ziepe.ca> (raw)
In-Reply-To: <YVs5gT1rj9HiAW5p@sirena.org.uk>
On Mon, Oct 04, 2021 at 06:27:29PM +0100, Mark Brown wrote:
> On Mon, Oct 04, 2021 at 02:13:01PM -0300, Jason Gunthorpe wrote:
>
> > I'm kind of surprised a scheme like this didn't involve a FW call
> > after Linux is done with the CPUs to quiet all the HW and let it
> > sleep, I've built things that way before at least.
>
> That's a *lot* of code to put in firmware if you can't physically power
> most of the system down.
Maybe? The chip I worked on we just made a list of register/value
pairs that covered all the functional blocks and the FW ran down the
list.
Mind you the chip was designed that poking ABC to reg 123 turned the
unit off no matter what. It didn't have a complex interactive shutdown
sequence.
Jason
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-10-04 17:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 19:56 [PATCH] spi: bcm2835: do not unregister controller in shutdown handler Lino Sanfilippo
2021-09-28 20:08 ` Mark Brown
2021-09-29 8:38 ` Aw: " Lino Sanfilippo
2021-10-01 17:54 ` Mark Brown
2021-10-03 15:25 ` Lino Sanfilippo
2021-10-04 12:49 ` Mark Brown
2021-10-04 13:17 ` Jason Gunthorpe
2021-10-04 14:12 ` Mark Brown
2021-10-04 15:44 ` Jason Gunthorpe
2021-10-04 16:31 ` Mark Brown
2021-10-04 16:36 ` Florian Fainelli
2021-10-04 16:51 ` Jason Gunthorpe
2021-10-04 16:55 ` Florian Fainelli
2021-10-04 17:13 ` Jason Gunthorpe
2021-10-04 17:27 ` Mark Brown
2021-10-04 17:35 ` Jason Gunthorpe [this message]
2021-10-04 17:44 ` Florian Fainelli
2021-10-04 17:56 ` Mark Brown
2021-10-04 17:05 ` Mark Brown
2021-10-04 16:52 ` Mark Brown
2021-10-04 16:57 ` Florian Fainelli
2021-10-04 18:30 ` Lino Sanfilippo
2021-10-04 18:37 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211004173531.GB3544071@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=LinoSanfilippo@gmx.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=broonie@kernel.org \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=nsaenz@kernel.org \
--cc=p.rosenberger@kunbus.com \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox