From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01259C433F5 for ; Tue, 5 Oct 2021 07:11:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B72FC61409 for ; Tue, 5 Oct 2021 07:11:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B72FC61409 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WPvM9oXVqqHFF3qE5EsiY8lrjIhdrJDrIoO/NqyEi64=; b=m32BB+WzS0G2IW +jBkbkWG8ZR9lH7aCfMB3vxyckzduyaSgaHv8k2Fp88n1avQRJq1cnRcBZvQ8IW8JZebtC6hxYKKY klSIKxY4NOURhxPC7ZDC5CpP1LAmmcPUc9zerOgiX3CwG0L5bcVYuH14U1bapvoHo3qrT1F5lyOrK yYfw+SuT1MleGDNfzARPSbQBt34IUhFloVWAUcrwghmH2Wmvdi0QzuvKADvGzknU3hqKfn22+yCEi Wh5oloGruuOshY4AvOfBNbCd7BApYW3iFQFL6UlU/+uzT8ZgUZPUhtVsAC5LiTkVwZgZ1xUaxwbxH niLvsFBoUkpYjX7d1Liw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mXeaN-009GkU-KW; Tue, 05 Oct 2021 07:09:59 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mXeaK-009GjM-16 for linux-arm-kernel@lists.infradead.org; Tue, 05 Oct 2021 07:09:57 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8E13861425; Tue, 5 Oct 2021 07:09:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1633417795; bh=LolzeVyvQ9Fdg5AkSm3PkTTdmlFXrwEm0GL30clzJto=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GxilFPaiS6TAr3bQVhm56wzc4JTQjhYIvMLUUju0F9keWMASsTqBJHwvoAeWZytso Ur8dqOIpN+fTIf/wdtaPFZ0UTFw/lePh/6iKtPZQpDMYrttaVpHfyAyOw72sYVcNmQ mRHXK3IXIDTJUwxNyEfqn2W/2Sbk1Jag8/alf8pjr3JSV0NZ9PT2pN7njnXka7FMkp VOeUvM84aserRlVX5MRJBD5CQv70yEU+3ydIDnQWT0DZ7LdIr9xBFl51zKPfZQSUew +zSLr7O8WiPyBbJBjOCQeUnn+AT9lJvJIQr27kiO+Aa2PBONDGxVKGpnSSdUjAOE1D QdRa/lhHU2QiQ== Date: Tue, 5 Oct 2021 15:09:49 +0800 From: Shawn Guo To: Frieder Schrempf Cc: devicetree@vger.kernel.org, Frieder Schrempf , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Rob Herring , Sascha Hauer , stable@vger.kernel.org, Fabio Estevam , NXP Linux Team , Pengutronix Kernel Team Subject: Re: [PATCH 4/8] arm64: dts: imx8mm-kontron: Fix reg_rst_eth2 and reg_vdd_5v regulators Message-ID: <20211005070949.GB20743@dragon> References: <20210930155633.2745201-1-frieder@fris.de> <20210930155633.2745201-5-frieder@fris.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210930155633.2745201-5-frieder@fris.de> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211005_000956_117483_0325857D X-CRM114-Status: GOOD ( 21.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 30, 2021 at 05:56:27PM +0200, Frieder Schrempf wrote: > From: Frieder Schrempf > > The regulator reg_vdd_5v represents the fixed 5V supply on the board which > can't be switched off. Mark it as always-on. > > The regulator reg_rst_eth2 should keep the reset signal of the USB ethernet > adapter deassertet anytime. Fix the polarity and mark it as always-on. It seems to be wrong from the beginning that the reset is modelled by a regulator. > > Fixes: 21c4f45b335f ("arm64: dts: Add the Kontron i.MX8M Mini SoMs and baseboards") > Cc: stable@vger.kernel.org > Signed-off-by: Frieder Schrempf > --- > arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts > index 62ba3bd08a0c..f2c8ccefd1bf 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts > @@ -70,7 +70,9 @@ reg_rst_eth2: regulator-rst-eth2 { > regulator-name = "rst-usb-eth2"; > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_usb_eth2>; > - gpio = <&gpio3 2 GPIO_ACTIVE_LOW>; > + gpio = <&gpio3 2 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + regulator-always-on; > }; > > reg_vdd_5v: regulator-5v { > @@ -78,6 +80,7 @@ reg_vdd_5v: regulator-5v { > regulator-name = "vdd-5v"; > regulator-min-microvolt = <5000000>; > regulator-max-microvolt = <5000000>; > + regulator-always-on; You do not have any on/off control over the regulator. So how does this always-on property make any difference? Shawn > }; > }; > > -- > 2.33.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel