From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D50EC433EF for ; Tue, 5 Oct 2021 07:22:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5B140613B5 for ; Tue, 5 Oct 2021 07:22:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5B140613B5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XPQoXvv86lRQHPupt+DYVH/pmuk3oN0OAvbFnXC0drI=; b=CNsizdJU5QRzrc xVgBtB7+njzLe26DStm4aMIOETgu6nSkdbSxE9wwJ7IIoIJxeSUVhn1T54ToqIew0QaAqn//reJ8H rTOrpMpqGtQlmbgRBblsRiGpuD4L5o/jxFcXtf+fhF+6/o+aCPHGaL8ZFrMOypKszamseCbtMxiWC bWfZX/jASmXbgMwE9iKPw4oiQdvPO2S8hW+E4LMGHCfwfL/yvjtyZkr/Mgo6vnBHrM9X3P8bJaBTi gJHzBALJ7RAGoCJT89wJehNwLAuYs8wDiOOyKn53A4piVVda8j86HZLysQVLXKUkdBq51sR73K8nK L+Sqx+RTNt2i2/PQJ8yw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mXel0-009Ker-2v; Tue, 05 Oct 2021 07:20:58 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mXekr-009Kbn-Vj for linux-arm-kernel@lists.infradead.org; Tue, 05 Oct 2021 07:20:51 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id E092361409; Tue, 5 Oct 2021 07:20:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1633418449; bh=N7hQX43Kc4fE1oxsGIaIgA7jCH+iDTQUQqbND1FQvec=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fQx/oH/Qe3bDAJIP7MxqLrVxADMwPDT+NeIDwVwCPVs/ndILpILM8+xyr/nwBfSRa qYPNEuOVdLZr4EOEULM0AZSnyvMPelUd+ELNseGJYzeaPuzl2KBTKEe2LQiO8mPZAA u71EXhikzdVPvxoitG6yAmEicZSq2jihmdxkJdfYeJIUtZiT8mFCrA4lEI9D2LLRvw tn0LsQEZ82LXJiXP5fgUMBPNMUZzkvLbiK/Xq7ytIKkL2j53eKF0f0/LVNZ2C+yxUe /3t6OgC0Np5i4id8X2NIgcub1Arj2WYlG9FowDp3ZKqB41pF27EFEX1beKeMkJcE46 dy1SO9AJl7hiw== Date: Tue, 5 Oct 2021 15:20:43 +0800 From: Shawn Guo To: Frieder Schrempf Cc: devicetree@vger.kernel.org, Frieder Schrempf , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Rob Herring , Sascha Hauer , stable@vger.kernel.org, Fabio Estevam , NXP Linux Team , Pengutronix Kernel Team Subject: Re: [PATCH 6/8] arm64: dts: imx8mm-kontron: Fix connection type for VSC8531 RGMII PHY Message-ID: <20211005072042.GD20743@dragon> References: <20210930155633.2745201-1-frieder@fris.de> <20210930155633.2745201-7-frieder@fris.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210930155633.2745201-7-frieder@fris.de> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211005_002050_071300_59D44F45 X-CRM114-Status: GOOD ( 20.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 30, 2021 at 05:56:29PM +0200, Frieder Schrempf wrote: > From: Frieder Schrempf > > Previously we falsely relied on the PHY driver to unconditionally > enable the internal RX delay. Since the following fix for the PHY > driver this is not the case anymore: > > commit 7b005a1742be ("net: phy: mscc: configure both RX and TX internal > delays for RGMII") > > In order to enable the delay we need to set the connection type to > "rgmii-rxid". Could you share some details of the issue that the delay is not enabled, e.g. how broken the Ethernet support is without this change? Shawn > > Fixes: 21c4f45b335f ("arm64: dts: Add the Kontron i.MX8M Mini SoMs and baseboards") > Cc: stable@vger.kernel.org > Signed-off-by: Frieder Schrempf > --- > arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts > index dbf11e03ecce..0e4509287a92 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts > @@ -114,7 +114,7 @@ &ecspi3 { > &fec1 { > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_enet>; > - phy-connection-type = "rgmii"; > + phy-connection-type = "rgmii-rxid"; > phy-handle = <ðphy>; > status = "okay"; > > -- > 2.33.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel