From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 712E5C433F5 for ; Tue, 5 Oct 2021 11:18:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1797361264 for ; Tue, 5 Oct 2021 11:18:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1797361264 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KLFTBux7M8VEkqHd91hJsEkhGtzfenarVxkX3Aibg6E=; b=HVCAI7NDqK/5UK B30HlO3HLc5iQmpf2ylV+dqUpBtpqmNrpBtlvVlKMFMBe1oXfv0UOL37lO1CjEEKfAMgLPlO0tf70 9gjGprJNHUrd1qksirqCsrmIEGj3knC4F+WtBt4NR17yKpdvEF9lgx2Pt8G2/JbPmvDeIa8oRS2Yx rf4GHAJWRW3XdLsoaUAO7aIaq7zifMdFnYX0V9kf7sSwqXYdx6uYffaJj7J8Vquv3n6d4VMQQmLBJ 6JcwuwYym1aVnRYHYWqPprwBXz56IF9FyNhikq+WfcFzGehPJ7dXnXFPen+ey2LGb1e0RGaOuovW0 RJnRnmZC1BRpcd20sAbw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mXiQa-00A7Ns-Bz; Tue, 05 Oct 2021 11:16:08 +0000 Received: from mga02.intel.com ([134.134.136.20]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mXiQW-00A7N5-SG for linux-arm-kernel@lists.infradead.org; Tue, 05 Oct 2021 11:16:06 +0000 X-IronPort-AV: E=McAfee;i="6200,9189,10127"; a="212834327" X-IronPort-AV: E=Sophos;i="5.85,348,1624345200"; d="scan'208";a="212834327" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Oct 2021 04:16:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,348,1624345200"; d="scan'208";a="483736181" Received: from linux.intel.com ([10.54.29.200]) by fmsmga007.fm.intel.com with ESMTP; 05 Oct 2021 04:16:02 -0700 Received: from linux.intel.com (vwong3-ilbpg3.png.intel.com [10.88.229.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTPS id 53B435805EE; Tue, 5 Oct 2021 04:15:59 -0700 (PDT) Date: Tue, 5 Oct 2021 19:15:56 +0800 From: Wong Vee Khee To: Andrew Lunn Cc: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S . Miller" , Jakub Kicinski , Maxime Coquelin , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Michael Sit Wei Hong , Wong Vee Khee Subject: Re: [PATCH net v1 1/1] net: stmmac: fix EEE init issue when paired with EEE capable PHYs Message-ID: <20211005111556.GA28642@linux.intel.com> References: <20210930064436.1502516-1-vee.khee.wong@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211005_041604_993942_20064F59 X-CRM114-Status: GOOD ( 24.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 01, 2021 at 01:31:36AM +0200, Andrew Lunn wrote: > On Thu, Sep 30, 2021 at 02:44:36PM +0800, Wong Vee Khee wrote: > > When STMMAC is paired with Energy-Efficient Ethernet(EEE) capable PHY, > > and the PHY is advertising EEE by default, we need to enable EEE on the > > xPCS side too, instead of having user to manually trigger the enabling > > config via ethtool. > > > > Fixed this by adding xpcs_config_eee() call in stmmac_eee_init(). > > > > Fixes: 7617af3d1a5e ("net: pcs: Introducing support for DWC xpcs Energy Efficient Ethernet") > > Cc: Michael Sit Wei Hong > > Signed-off-by: Wong Vee Khee > > --- > > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > > index 553c4403258a..981ccf47dcea 100644 > > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > > @@ -486,6 +486,10 @@ bool stmmac_eee_init(struct stmmac_priv *priv) > > timer_setup(&priv->eee_ctrl_timer, stmmac_eee_ctrl_timer, 0); > > stmmac_set_eee_timer(priv, priv->hw, STMMAC_DEFAULT_LIT_LS, > > eee_tw_timer); > > + if (priv->hw->xpcs) > > + xpcs_config_eee(priv->hw->xpcs, > > + priv->plat->mult_fact_100ns, > > + true); > > } > > > /* Check if it needs to be deactivated */ > if (!priv->eee_active) { > if (priv->eee_enabled) { > netdev_dbg(priv->dev, "disable EEE\n"); > stmmac_lpi_entry_timer_config(priv, 0); > del_timer_sync(&priv->eee_ctrl_timer); > stmmac_set_eee_timer(priv, priv->hw, 0, eee_tw_timer); > } > mutex_unlock(&priv->lock); > return false; > } > > Don't you want to turn it of in here? > > Andrew You're right. Will introduce a new patch for that. Regards, Vee Khee _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel