From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7719EC433EF for ; Tue, 5 Oct 2021 23:19:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 33AEB61184 for ; Tue, 5 Oct 2021 23:19:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 33AEB61184 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To: Message-Id:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4H+xO/FyaCHyGYzl5QoWlu6ZN3jFHe2jx8xvST9eFFE=; b=KL2sbzc4n6Q0TB xAZdEjmxW3aE7dWbifGQZol5NX8p6IpoTTyKKPSTM2SsV8AtgrB4Rv9H6QUCNgS+kq6ikuCiY6U7t xp7d3aW/Plz73wh4uFne1cmKfwyYfIlLMeqA5510d8zdCVCvAKVqS2KPsYTTiUFz8eobMsZMLAffh Mz26jBrj5wpeMM+w6ti+4tDKRBAKJon6/SBITBRHm+xyLplQ532utraC1VNOZAK7yOAj9ZPkUlGLl rNQt/btGVf5adPrjzip4PT4CKGIUD+VKLCCGFJ+6n78dehaoK6j5R68+8phEzsJHB2KQLWd5Joi1d CfdYEUZbVzrJez/PSBcQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mXtf0-00CFeK-Ka; Tue, 05 Oct 2021 23:15:46 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mXtex-00CFe1-Oa for linux-arm-kernel@lists.infradead.org; Tue, 05 Oct 2021 23:15:45 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id E69926120F; Tue, 5 Oct 2021 23:15:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1633475743; bh=szEPXPJ8X7viHNp/RVsKgl6R1nk0IdsK/88slQMYcVg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Xu6H9CpKaSGrCpUh59EyIcZJLp6lp04Ho01eCWaDXv2I8EGgSs/ZWs91kJ4KlQODu 0wmV8khmYZLA5VRkTRcDSq0x95MXvZTt1aDFLORXy5an5BSeEpIxrsFRjkt8rcc+cO z77F1J9ZFYZOZXRLOph/nVFq0ODyEfkOipLdGmzE= Date: Tue, 5 Oct 2021 16:15:42 -0700 From: Andrew Morton To: Mike Kravetz Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Anshuman Khandual , Will Deacon , Mark Rutland , Barry Song , stable@vger.kernel.org Subject: Re: [PATCH] arm64/hugetlb: fix CMA gigantic page order for non-4K PAGE_SIZE Message-Id: <20211005161542.176a63eb7e197d795c5196d9@linux-foundation.org> In-Reply-To: <3747d914-c687-b983-c624-e3418b4d2448@oracle.com> References: <20211005202529.213812-1-mike.kravetz@oracle.com> <20211005135435.341477bb4b50b84202c32450@linux-foundation.org> <3747d914-c687-b983-c624-e3418b4d2448@oracle.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211005_161543_858364_179EA5CA X-CRM114-Status: GOOD ( 20.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 5 Oct 2021 14:28:03 -0700 Mike Kravetz wrote: > On 10/5/21 1:54 PM, Andrew Morton wrote: > > On Tue, 5 Oct 2021 13:25:29 -0700 Mike Kravetz wrote: > > > >> For non-4K PAGE_SIZE configs, the largest gigantic huge page size is > >> CONT_PMD_SHIFT order. > > > > What are the user visible effects of this bug? > > > > > > Sorry, > I only recently got easy access to arm64 platforms. This is what I saw > as a user: > > The largest gigantic huge page size on arm64 with 64K PAGE_SIZE 64K is > 16G. Therefore, one should be able to specify 'hugetlb_cma=16G' on the > kernel command line so that 1 gigantic page can be allocated from CMA. > However, when adding such an option the following message is produced: > > hugetlb_cma: cma area should be at least 8796093022208 MiB > > This is because the calculation for non-4K gigantic page order is > incorrect in the arm64 specific routine arm64_hugetlb_cma_reserve(). Cool, thanks. > Would you like me to send a new version with this in the commit message? > Or, is it easier for you to just add it? I assumed that it would be merged via the same path as the offending abb7962adc80. Catalin's arm tree, it appears. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel