From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41A85C433EF for ; Wed, 6 Oct 2021 11:00:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0E75E610C9 for ; Wed, 6 Oct 2021 11:00:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0E75E610C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6+adb9ZDxZ8FxfXlwhcjUo1g93BKYgqVjJU27X40Sy0=; b=I6PUFhRmRJCXKo BwOuj6DrAkb9wQqRa5Xfc4NI5tn/ZkRjY20z3SjOpbYw+S3AXYtDfxHCZ7WeYDtZu93Y/ivVcxDMP VlZJRXKWy+gYDFtIX0xBnvHEBPFPr1EUmoY71NV7SWKduOrF/xrM17TD5mxBHEKPl2fX8Xnr5t0LJ OWkBx9idLdqrWxWOOX1k69r/0ojC0XzLMsrf+rLCgP5YgIPzQBuT1aijAckd8myS2yQUtY9iLMfkJ o1Ug2+XavNc7DBsSvoz5VeHv5Zxc+d9hmyOsmn/YqLCTqFCSejDtaTMfoJyANfaGy9kVxLAIbWVl7 o3ht0BuY9+Vuv+XiuBLQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mY4db-00Dv6H-Fn; Wed, 06 Oct 2021 10:59:03 +0000 Received: from mail-lf1-x131.google.com ([2a00:1450:4864:20::131]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mY4dW-00Dv5V-Q1 for linux-arm-kernel@lists.infradead.org; Wed, 06 Oct 2021 10:59:00 +0000 Received: by mail-lf1-x131.google.com with SMTP id t9so8753469lfd.1 for ; Wed, 06 Oct 2021 03:58:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=4/bR370sJeXKagzVx84eEl7it6OjGumKTP1D7BeHtkI=; b=vwPdU129u5zyAAZVoq5ICdMKOAqzuAuD8txMDSGBEU46GJ20pL+UIOCx/7mI4hc77q 1OsVnqF23iXe04QrTh3wZI7MHG/1JH9kERtU7AK4GKPoiWlgNbCk52wG4DqKWRZ9olkT NkC7f+9TKPi1uH36JHd0L/kZjZygZwaOM+CxyrDpPI7lfWS4tsS8ONgTfRr1V6FSL28I AU2yh/UT35MQXsj5axdshFQ0CLbHAHqlz752JmTqJ7O00P/9d5WaJ/Ha0VMTDyi6SAsN wbMug8QL+boYiymommIwzomg8dS1Cfr1pGVvMIjUVRtILQiKsEC5ek06xS6bCIcgfhQL PrgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=4/bR370sJeXKagzVx84eEl7it6OjGumKTP1D7BeHtkI=; b=Efz1ZoYa2r2Kg+DvrvS8IpsqC+dXuvsURUC6culjnjp8CpXIl1vyof50OEW6xbBZlj lshwUNBzJHWv6kQ9BVfsZroCtqPCGwgrEVUThqvdeXycyX8mv9eWLzda8MQjiwW1A0bB rGOrz6Sn9u2FZDCaXLybxjI26FnvEdZbAWJi5MuWW9BwMHduIaPsDjW41oIMxFUquVlj faj/iSbODH02Q3NU7L5c3XoCB1nbZuoMXc40Dr2y2fpBVT1S6M7GDBKTSYmE6Fk+bWs7 XGRcSrdsC8bVM6DTjT6zXudhF0BtQjS9HjAC9ou54hjfJlIkzLezklYittwlqFVa0/5Z m0pQ== X-Gm-Message-State: AOAM533wvSrmrwwp3E6ZfZExtuZ/cP2BgxHAYx0XEZOJAs6KMxRvuJcP nH8kq40gxXGGw6ZHMep1ByqiyA== X-Google-Smtp-Source: ABdhPJx+pnnfB8C3Cjf8Zh+CAzXxa1LiUWiRG+ojgXuj8NlzQ8P1qVROeh4QiQHfNpNhowl5wMx97g== X-Received: by 2002:ac2:5582:: with SMTP id v2mr8987296lfg.143.1633517937070; Wed, 06 Oct 2021 03:58:57 -0700 (PDT) Received: from jade ([85.235.10.227]) by smtp.gmail.com with ESMTPSA id x2sm2247657ljc.59.2021.10.06.03.58.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Oct 2021 03:58:56 -0700 (PDT) Date: Wed, 6 Oct 2021 12:58:55 +0200 From: Jens Wiklander To: Jerome Forissier Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, op-tee@lists.trustedfirmware.org, Sumit Garg , Sudeep Holla , Marc Bonnici , sughosh.ganu@linaro.org Subject: Re: [PATCH v6 1/5] tee: add sec_world_id to struct tee_shm Message-ID: <20211006105855.GA2555558@jade> References: <20211006070902.2531311-1-jens.wiklander@linaro.org> <20211006070902.2531311-2-jens.wiklander@linaro.org> <2af3eda2-2ceb-4812-a813-ae3dff02cdac@forissier.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2af3eda2-2ceb-4812-a813-ae3dff02cdac@forissier.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211006_035858_898548_97B1BA9B X-CRM114-Status: GOOD ( 25.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 06, 2021 at 10:36:22AM +0200, Jerome Forissier wrote: > > > On 10/6/21 9:08 AM, Jens Wiklander wrote: > > Adds sec_world_id to struct tee_shm which describes a shared memory > > object. sec_world_id can be used by a driver to store an id assigned by > > secure world. > > > > Reviewed-by: Sumit Garg > > Signed-off-by: Jens Wiklander > > --- > > include/linux/tee_drv.h | 7 ++++++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > diff --git a/include/linux/tee_drv.h b/include/linux/tee_drv.h > > index 3ebfea0781f1..a1f03461369b 100644 > > --- a/include/linux/tee_drv.h > > +++ b/include/linux/tee_drv.h > > @@ -197,7 +197,11 @@ int tee_session_calc_client_uuid(uuid_t *uuid, u32 connection_method, > > * @num_pages: number of locked pages > > * @dmabuf: dmabuf used to for exporting to user space > > * @flags: defined by TEE_SHM_* in tee_drv.h > > - * @id: unique id of a shared memory object on this device > > + * @id: unique id of a shared memory object on this device, shared > > + * with user space > > + * @sec_world_id: > > + * secure world assigned id of this shared memory object, not > > + * used by all drivers > > * > > * This pool is only supposed to be accessed directly from the TEE > > * subsystem and from drivers that implements their own shm pool manager. > > @@ -213,6 +217,7 @@ struct tee_shm { > > struct dma_buf *dmabuf; > > u32 flags; > > int id; > > + u64 sec_world_id; > > Wouldn't it make more sense to have this outside struct tee_shm in a > driver-specific struct? (which could always be obtained from a struct > tee_shm * using container_of() for example). Yes, that could be quite useful, but the problem is that it's tee_shm_alloc() that allocates this struct so it can't easily be embedded in a driver-specific struct. We could of course change that but that will require changes to the AMDTEE driver also. I'm not sure it's worth the trouble though, since the AMDTEE driver could make use of this field too. Cheers, Jens _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel