From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1D79C433EF for ; Thu, 7 Oct 2021 14:44:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6F03861139 for ; Thu, 7 Oct 2021 14:44:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6F03861139 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LJ/FfPk/+CLUCsJbb2RC5eb68KWkMH/BjS7Qapb5kvE=; b=LZ8Yr1MEISzKS2 Fe0ojnOYC4m2P3ybsEmJ/1t5rpQ0hDORLs7t0WSDDL4OO2vDh3TD89EK47haIqVxUAB6F8xTD/5KU TktKbO+7o9wbyHyRFA8S5ild3KplJU3wXUXH9MfSeHBO7DXyHTEaLhNLHJpMgVWYLAaR6TvhWiQHm QxbZ9rYOnt7GbNtApgabN4JLUi/9TkJqAJvfSuwcKQunDMl539tkBISc6Q5mba0mA9g1/zeaWbgxG Q1CGRErlej83uCiVSEJF6udseRVAc7YWFVw2XbIIa79fALyZygLSgiMEVD6CrqPRvXaCijMLKInVX 5SRFCUxJLmOvP3Zs+Fww==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mYUbN-0002n6-B6; Thu, 07 Oct 2021 14:42:29 +0000 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mYUbJ-0002lZ-3b for linux-arm-kernel@lists.infradead.org; Thu, 07 Oct 2021 14:42:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633617743; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xazcSRU4hXAvOQ5GWPa9VCWbDLefBI+rO4m0xJqTNOQ=; b=hV1HPtjtkojabHHXhunC3eBMvDVxTmiMdurx0TUGJLAaeA0NWzfceAUFpBzVw4l+apDB59 NaaBZnxiUo3nWQS/Sp0OSbRFlta2byRPLXwJiq7p68Kmc+qO7gARy0KWXa1T0WRh01Woxy 90+RvphJoo67EbRBbRn2gdadqHX+yR0= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-453-pNxNJE6HM1KKekPCDPb_EQ-1; Thu, 07 Oct 2021 10:42:22 -0400 X-MC-Unique: pNxNJE6HM1KKekPCDPb_EQ-1 Received: by mail-wr1-f69.google.com with SMTP id k2-20020adfc702000000b0016006b2da9bso4874199wrg.1 for ; Thu, 07 Oct 2021 07:42:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=xazcSRU4hXAvOQ5GWPa9VCWbDLefBI+rO4m0xJqTNOQ=; b=vq+4LfkM+ExotsVNuC6B6MJgrGHNPetqxLKWG2pqJUSUzVGyu4wbhgc5eDdQzJ0Uo9 Zz/lx7AOwj5x70dd6ydN73YULUB5IJ2z26Zu3bnSomU+QSuRtnDssyTNaVXf4BvWQM6r 6pghZzimrUQNVM47xh7csIi1vi4NTaSdvdaC8HNfwqLZdqiT5SYrJ5C0p2jSXxdPOtoP LK1sOk5tSjcX+xnY5xYDHd4iehZORW+jf2fVYbq2bEurqlH5JIDfB0NpRKz4Rja5pJNE CVWD97FmKGVEl4wLgfPbS4KrihZHR9QGD6Dgu2AJnVU/nartA2xggURW3e5TrmkwrUb7 nSOg== X-Gm-Message-State: AOAM531tqMw8ZgJQojDpIducp4G5yFiQ17kUZsSLt4hq5k0LTRA0nvYq KmhPd2ldEn0o6SZBcyhLZF88eKFuaGkTHFDIPoaJxiw5m0m+ExXHoq4ucwyhv8atQPyOBp0HvCX 1zD0NVfEu+1HJr+0GcCDhj+5/Lhds8eBUxng= X-Received: by 2002:a1c:a914:: with SMTP id s20mr5090558wme.6.1633617741231; Thu, 07 Oct 2021 07:42:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwmbskMeR1xk9N+RgV327boeCxt5BJetcoJmu76NCY9APJsJpEu2sTGpBXGDLxTNSiHEwr3Vg== X-Received: by 2002:a1c:a914:: with SMTP id s20mr5090538wme.6.1633617741066; Thu, 07 Oct 2021 07:42:21 -0700 (PDT) Received: from gator (nat-pool-brq-u.redhat.com. [213.175.37.12]) by smtp.gmail.com with ESMTPSA id c132sm9169302wma.22.2021.10.07.07.42.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Oct 2021 07:42:18 -0700 (PDT) Date: Thu, 7 Oct 2021 16:42:14 +0200 From: Andrew Jones To: Marc Zyngier Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, will@kernel.org, qperret@google.com, dbrazdil@google.com, Steven Price , Fuad Tabba , Srivatsa Vaddagiri , Shanker R Donthineni , James Morse , Suzuki K Poulose , Alexandru Elisei , kernel-team@android.com Subject: Re: [PATCH v2 10/16] KVM: arm64: Add some documentation for the MMIO guard feature Message-ID: <20211007144214.pti5b2wjio6wneye@gator> References: <20211004174849.2831548-1-maz@kernel.org> <20211004174849.2831548-11-maz@kernel.org> MIME-Version: 1.0 In-Reply-To: <20211004174849.2831548-11-maz@kernel.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=drjones@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211007_074225_250936_B6972CC9 X-CRM114-Status: GOOD ( 28.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 04, 2021 at 06:48:43PM +0100, Marc Zyngier wrote: > Document the hypercalls user for the MMIO guard infrastructure. > > Signed-off-by: Marc Zyngier > --- > Documentation/virt/kvm/arm/index.rst | 1 + > Documentation/virt/kvm/arm/mmio-guard.rst | 74 +++++++++++++++++++++++ > 2 files changed, 75 insertions(+) > create mode 100644 Documentation/virt/kvm/arm/mmio-guard.rst > > diff --git a/Documentation/virt/kvm/arm/index.rst b/Documentation/virt/kvm/arm/index.rst > index 78a9b670aafe..e77a0ee2e2d4 100644 > --- a/Documentation/virt/kvm/arm/index.rst > +++ b/Documentation/virt/kvm/arm/index.rst > @@ -11,3 +11,4 @@ ARM > psci > pvtime > ptp_kvm > + mmio-guard > diff --git a/Documentation/virt/kvm/arm/mmio-guard.rst b/Documentation/virt/kvm/arm/mmio-guard.rst > new file mode 100644 > index 000000000000..8b3c852c5d92 > --- /dev/null > +++ b/Documentation/virt/kvm/arm/mmio-guard.rst > @@ -0,0 +1,74 @@ > +.. SPDX-License-Identifier: GPL-2.0 > + > +============== > +KVM MMIO guard > +============== > + > +KVM implements device emulation by handling translation faults to any > +IPA range that is not contained in a memory slot. Such a translation > +fault is in most cases passed on to userspace (or in rare cases to the > +host kernel) with the address, size and possibly data of the access > +for emulation. > + > +Should the guest exit with an address that is not one that corresponds > +to an emulatable device, userspace may take measures that are not the > +most graceful as far as the guest is concerned (such as terminating it > +or delivering a fatal exception). > + > +There is also an element of trust: by forwarding the request to > +userspace, the kernel assumes that the guest trusts userspace to do > +the right thing. > + > +The KVM MMIO guard offers a way to mitigate this last point: a guest > +can request that only certain regions of the IPA space are valid as > +MMIO. Only these regions will be handled as an MMIO, and any other > +will result in an exception being delivered to the guest. > + > +This relies on a set of hypercalls defined in the KVM-specific range, > +using the HVC64 calling convention. > + > +* ARM_SMCCC_KVM_FUNC_MMIO_GUARD_INFO > + > + ============== ======== ================================ > + Function ID: (uint32) 0xC6000002 > + Arguments: none > + Return Values: (int64) NOT_SUPPORTED(-1) on error, or > + (uint64) Protection Granule (PG) size in > + bytes (r0) > + ============== ======== ================================ > + > +* ARM_SMCCC_KVM_FUNC_MMIO_GUARD_ENROLL > + > + ============== ======== ============================== > + Function ID: (uint32) 0xC6000003 > + Arguments: none > + Return Values: (int64) NOT_SUPPORTED(-1) on error, or > + RET_SUCCESS(0) (r0) > + ============== ======== ============================== > + > +* ARM_SMCCC_KVM_FUNC_MMIO_GUARD_MAP > + > + ============== ======== ==================================== > + Function ID: (uint32) 0xC6000004 > + Arguments: (uint64) The base of the PG-sized IPA range > + that is allowed to be accessed as > + MMIO. Must be aligned to the PG size > + (r1) > + (uint64) Index in the MAIR_EL1 register > + providing the memory attribute that > + is used by the guest (r2) Already gave my r-b for this document, but after double checking I see that this r2 argument doesn't appeared used by the implementation yet. Is this left over from an older design or reserved for later use? Thanks, drew > + Return Values: (int64) NOT_SUPPORTED(-1) on error, or > + RET_SUCCESS(0) (r0) > + ============== ======== ==================================== > + > +* ARM_SMCCC_KVM_FUNC_MMIO_GUARD_UNMAP > + > + ============== ======== ====================================== > + Function ID: (uint32) 0xC6000005 > + Arguments: (uint64) PG-sized IPA range aligned to the PG > + size which has been previously mapped. > + Must be aligned to the PG size and > + have been previously mapped (r1) > + Return Values: (int64) NOT_SUPPORTED(-1) on error, or > + RET_SUCCESS(0) (r0) > + ============== ======== ====================================== > -- > 2.30.2 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel