From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05C9BC433EF for ; Thu, 7 Oct 2021 17:21:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CA55061042 for ; Thu, 7 Oct 2021 17:21:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CA55061042 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Li74WgikpHoYuIIvJtZbPeTKKZee2EElWHNs+/jethY=; b=5Dlo9jgmQY1sp5 h2HFuSRlTeUSy6NyaIO9ISsn3+rdehjLOTyvpa/xZPOzNrwBN9EsM/nnPoOppdYrAzesk5zLNCRSG TvyuugIVjpQobK4ZqP0VpPDul03jf8wVH+S2GWLPlLBn4L0IGjqnmpIygHUMx/7hYMeAq7Yujy63f d2rE+yaWUKuI5ijJGZhyMgS1vTGXKRQ3S07dKNKBOdkLSebjNpZ/ahhvsmUFP6APGCAy3chx0tO4v o1Vs8pjt6tvaJZ9bnAGtZLXDLDMeEvyFQiMsUDd4NmGa8SvWQgdd6bFeXyKUzyJ6PKYYe7RTM2tid 8XBaZLLdReKCoBCgitlg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mYX38-000MA0-5Y; Thu, 07 Oct 2021 17:19:18 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mYX33-000M9Z-P4 for linux-arm-kernel@lists.infradead.org; Thu, 07 Oct 2021 17:19:15 +0000 Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 645CA61108; Thu, 7 Oct 2021 17:19:10 +0000 (UTC) Date: Thu, 7 Oct 2021 18:23:14 +0100 From: Jonathan Cameron To: Cai Huoqing Cc: Lars-Peter Clausen , Michael Hennerich , "Vladimir Zapolskiy" , Marcus Folkesson , Maxime Coquelin , Alexandre Torgue , , , , Subject: Re: [PATCH v2 8/8] iio: dac: ti-dac7311: Make use of the helper function dev_err_probe() Message-ID: <20211007182314.6c53158e@jic23-huawei> In-Reply-To: <20210928013902.1341-8-caihuoqing@baidu.com> References: <20210928013902.1341-1-caihuoqing@baidu.com> <20210928013902.1341-8-caihuoqing@baidu.com> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211007_101913_860241_5BB1C6FD X-CRM114-Status: GOOD ( 20.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 28 Sep 2021 09:39:01 +0800 Cai Huoqing wrote: > When possible use dev_err_probe help to properly deal with the > PROBE_DEFER error, the benefit is that DEFER issue will be logged > in the devices_deferred debugfs file. > Using dev_err_probe() can reduce code size, and the error value > gets printed. > > Signed-off-by: Cai Huoqing Series applied to the togreg branch of iio.git and pushed out as testing for 0-day to see if it can find any problems before I push this out in a place where it can make a mess of linux-next Thanks, Jonathan > --- > drivers/iio/dac/ti-dac7311.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/iio/dac/ti-dac7311.c b/drivers/iio/dac/ti-dac7311.c > index 9d0b253be841..09218c3029f0 100644 > --- a/drivers/iio/dac/ti-dac7311.c > +++ b/drivers/iio/dac/ti-dac7311.c > @@ -266,10 +266,9 @@ static int ti_dac_probe(struct spi_device *spi) > ti_dac->resolution = spec->resolution; > > ti_dac->vref = devm_regulator_get(dev, "vref"); > - if (IS_ERR(ti_dac->vref)) { > - dev_err(dev, "error to get regulator\n"); > - return PTR_ERR(ti_dac->vref); > - } > + if (IS_ERR(ti_dac->vref)) > + return dev_err_probe(dev, PTR_ERR(ti_dac->vref), > + "error to get regulator\n"); > > ret = regulator_enable(ti_dac->vref); > if (ret < 0) { _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel