From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 051CCC433F5 for ; Fri, 8 Oct 2021 13:30:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C393D60F90 for ; Fri, 8 Oct 2021 13:30:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C393D60F90 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=I9Tk34TiUH62YuNiLpBm82JoJnzQGz7DgL6NBBouKeE=; b=aNJXpZN3Nkn7Gp PLoh/kwLZEDZel5gpTLID+TRoa2Vq0OD2LGpx8nHUG/k4q19OzBTonXxRZZA2NE7o2YUwpidoUHmc CzNKSbjCRMoDn6OUcTCmEYJ4bTFkCZusWQwRIqrJV9QeLjFxXeEJf5Vvx+nTPpHAcV1XypKy3Gec2 9lDW7SYgyWTcf45jc8gWwaeR9thac6fTB+YNhGgDnDK1HGD6j53RsnlHoxAef1fWoqjSnJ43iYgYA U4SwoGRq5uvcPYW2fm5VaMy5mx781aaLGu0Jkcss+CDUzsGyQOb18ks4MHSfQ+FJrIdRMHWRuAScj SzuIZuKN7dZ48Le5mAjQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mYpvL-002svy-5S; Fri, 08 Oct 2021 13:28:31 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mYpvH-002sv5-5w for linux-arm-kernel@lists.infradead.org; Fri, 08 Oct 2021 13:28:28 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 484CE6D; Fri, 8 Oct 2021 06:28:21 -0700 (PDT) Received: from bogus (unknown [10.57.25.198]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4FE883F66F; Fri, 8 Oct 2021 06:28:19 -0700 (PDT) Date: Fri, 8 Oct 2021 14:27:32 +0100 From: Sudeep Holla To: Jens Wiklander Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, op-tee@lists.trustedfirmware.org, Sumit Garg , Marc Bonnici , Jerome Forissier , sughosh.ganu@linaro.org Subject: Re: [PATCH v6 5/5] optee: add FF-A support Message-ID: <20211008132732.hbmkd3hftdydtrsc@bogus> References: <20211006070902.2531311-1-jens.wiklander@linaro.org> <20211006070902.2531311-6-jens.wiklander@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211006070902.2531311-6-jens.wiklander@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211008_062827_313210_55A75BC7 X-CRM114-Status: GOOD ( 12.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 06, 2021 at 09:09:02AM +0200, Jens Wiklander wrote: > Adds support for using FF-A [1] as transport to the OP-TEE driver. > > Introduces struct optee_msg_param_fmem which carries all information > needed when OP-TEE is calling FFA_MEM_RETRIEVE_REQ to get the shared > memory reference mapped by the hypervisor in S-EL2. Register usage is > also updated to include the information needed. > > The FF-A part of this driver is enabled if CONFIG_ARM_FFA_TRANSPORT is > enabled. > I am not sure if I missed this with earlier version but I see the below warning the second time I insert the optee module. I am sure I tested it with previous version when I was fixing issues with FF-A as a module. Not sure if I am missing something in my steps. Regards, Sudeep -->8 sysfs: cannot create duplicate filename '/devices/optee-ta-d96a5b40-c3e5-21e3-8794-1002a5d5c61b' CPU: 7 PID: 181 Comm: modprobe Not tainted 5.15.0-rc4+ #6 Hardware name: FVP Base RevC (DT) Call trace: dump_backtrace+0x0/0x1d4 show_stack+0x18/0x64 dump_stack_lvl+0x64/0x7c dump_stack+0x18/0x38 sysfs_create_dir_ns+0xe4/0x140 kobject_add_internal+0x170/0x354 kobject_add+0x94/0x100 device_add+0x178/0x5f0 device_register+0x20/0x30 optee_enumerate_devices+0x204/0x2fc [optee] optee_ffa_probe+0x370/0x3bc [optee] ffa_device_probe+0x1c/0x28 [ffa_module] really_probe+0xc4/0x2f4 __driver_probe_device+0xb4/0xe0 driver_probe_device+0x40/0x134 __driver_attach+0xe0/0x180 bus_for_each_dev+0x80/0xcc driver_attach+0x24/0x30 bus_add_driver+0xfc/0x1dc driver_register+0x78/0x110 ffa_driver_register+0x2c/0x40 [ffa_module] optee_ffa_abi_register+0x28/0x34 [optee] init_module+0x38/0x60 [optee] do_one_initcall+0xbc/0x230 do_init_module+0x58/0x304 load_module+0x1cb8/0x1f78 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel