From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1B25C433F5 for ; Fri, 8 Oct 2021 13:45:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AE01E60F5B for ; Fri, 8 Oct 2021 13:45:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AE01E60F5B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WdgPFKJZ9azEgrQX5A26cujDWt9FIQIvxqrQJnyrdXM=; b=pFqWQP3wURByKc r0vnGFfnc1OhpK8luF6tDYjqqIXfQG8OcTPUUd66j5Pda0LRCoH1U1O2Apwd1LLgWok0fBepT54Ap tUSOIOiu+bB0JABMjZ5ixni4FUwYAR7O0fObMNiX4rNR8SlmrcH8w271IXilvl727bgI9cp090Cww oD1A/67VtRqORTd87l9NMxSt3isZ2aujPuycf2mhfCNNtQZMfPhzeIfdwb0QSv7z02ZaV+tQZOrxz VlXWju5L8qCOOZen/+MVaXM4EI3cGNDzIF0YPjBJpdn1DGu46Gc/diYRP86pe9+ul5gQ3x5yH3BI3 iFJotuCYz+fjJ6j6gwoQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mYqAE-002wNS-7r; Fri, 08 Oct 2021 13:43:54 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mYqAA-002wN3-7t for linux-arm-kernel@lists.infradead.org; Fri, 08 Oct 2021 13:43:51 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id BF65160F5B; Fri, 8 Oct 2021 13:43:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1633700629; bh=1o9q1XcL0I+ROV0ip9arNCr7TM35n15Zzw1snvEtGcI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RGnWbO0Mzk+jd1zPqtfu0npWY10dB4OeJnTuFb6RA3BkXr9+Oek/joN9GpIRNYitX xJiJs8+lL6jUhWRKkJPiLmgbXaSmad9ISbNq1w+nm/bLQz6erKUx8mZkdbkODZ8jV4 Y6ukTvxxsstcHhBHqgnPE9dLP+mzAdX/QrWMv932mWSTtnmK14Pa3x+F9YnycdifJJ MHsuTfMZsUPIHe5alopFMUxQRYJoiyVxqNci3z1S0jF2ULemwVsSkuAnVSicbpzhiv vsF0pOklNqVJkgX2DvJgwzmbD+qs0j+v6pviv9XSUdy5alB5XzoWnRtGY1Y7CzsvtP PynHQzujJGUeA== Received: by pali.im (Postfix) id 76DD3760; Fri, 8 Oct 2021 15:43:47 +0200 (CEST) Date: Fri, 8 Oct 2021 15:43:47 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Robert Marko Cc: Marek =?utf-8?B?QmVow7pu?= , Rob Herring , Andrew Lunn , gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, devicetree , Linux Kernel Mailing List , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v5] arm64: dts: marvell: add Globalscale MOCHAbin Message-ID: <20211008134347.lskm5pzt73pkf7oc@pali> References: <20211008114343.57920-1-robert.marko@sartura.hr> <20211008120855.46zbo2fl5edwf7ja@pali> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211008_064350_324971_B32BBDA1 X-CRM114-Status: GOOD ( 17.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Friday 08 October 2021 15:28:38 Robert Marko wrote: > > > + cp0_pcie_reset_pins: cp0-pcie-reset-pins { > > > + marvell,pins = "mpp9"; > > > + marvell,function = "gpio"; > > > > Now I spotted this. Why is PERST# pin configured into gpio mode? Is > > there some issue that this pin in pcie mode is not working properly, > > that PCIe controller cannot handle it correctly? Or something else? > > Its because I have seen way too many broken controllers when it comes > to PERST and > other Armada 7k/8k devices are using it in GPIO mode as well. > Just look at the number of conversions back to GPIO for other > platforms as there is always some bug. I know that A3720 has broken PERST# control in PCIe block... or at least I was not able to figure out how A3720 PCIe block can control PERST#. So configuring it in gpio mode and let PERST# to be controlled manually via gpio by the software is the workaround. I just wanted to know if A7k/A8k/CN913x is also broken in the same way as A3720. Or it it just a configuration workaround for missing driver or missing proper software setup. HW bugs like this should be properly documented and not hidden behind some configuration in DTS file. And reported to HW vendors. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel