From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB2C4C433EF for ; Fri, 8 Oct 2021 16:35:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7821F60F9D for ; Fri, 8 Oct 2021 16:35:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7821F60F9D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BfROFMzW9Nsf5lTK/krFO3BeM6CrU/au00gjahPwREA=; b=HYQ3PJm1u+fbCx ysOeA+uS8c+cQobVgZnudMgE+0/+MB1qaHclsC2P3Ey4ncTj65G9fDakoWGAHw85bL1xHqSpmMcI/ ab1kDBvG9x69WRB1KROQwZwM0yUGWuEVLDZ+8/f7zMzw9zKOAh6Bv6SAFoQRok/fpIIxs6VNHYvvk irU/hfhhuXnSy2CRX6hO/J1ZnlaZOPGwrwbqrSnTElD68iaqk37WqPpTCnWjGRKLqvH4++Wk0C6bZ lotUkpmTDvzCXIA9CHGFJT0A4l2UBTLFcBT+DNCOQGxV4In3tWBIbJMx8wt30l4dE57BtrDPilxKI A+qvqGDJHbX2XoCgcdfw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mYsnt-003We1-SP; Fri, 08 Oct 2021 16:33:01 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mYsnl-003WcV-Ul for linux-arm-kernel@lists.infradead.org; Fri, 08 Oct 2021 16:32:55 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 208381063; Fri, 8 Oct 2021 09:32:49 -0700 (PDT) Received: from bogus (unknown [10.57.21.181]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DAC583F66F; Fri, 8 Oct 2021 09:32:46 -0700 (PDT) Date: Fri, 8 Oct 2021 17:32:00 +0100 From: Sudeep Holla To: Jens Wiklander Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, op-tee@lists.trustedfirmware.org, Sumit Garg , Sudeep Holla , Marc Bonnici , Jerome Forissier , sughosh.ganu@linaro.org Subject: Re: [PATCH v6 5/5] optee: add FF-A support Message-ID: <20211008163200.wgls7gijpsk556kl@bogus> References: <20211006070902.2531311-1-jens.wiklander@linaro.org> <20211006070902.2531311-6-jens.wiklander@linaro.org> <20211008132732.hbmkd3hftdydtrsc@bogus> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211008132732.hbmkd3hftdydtrsc@bogus> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211008_093254_080173_35ECC4ED X-CRM114-Status: GOOD ( 18.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 08, 2021 at 02:27:32PM +0100, Sudeep Holla wrote: > On Wed, Oct 06, 2021 at 09:09:02AM +0200, Jens Wiklander wrote: > > Adds support for using FF-A [1] as transport to the OP-TEE driver. > > > > Introduces struct optee_msg_param_fmem which carries all information > > needed when OP-TEE is calling FFA_MEM_RETRIEVE_REQ to get the shared > > memory reference mapped by the hypervisor in S-EL2. Register usage is > > also updated to include the information needed. > > > > The FF-A part of this driver is enabled if CONFIG_ARM_FFA_TRANSPORT is > > enabled. > > > > I am not sure if I missed this with earlier version but I see the below > warning the second time I insert the optee module. I am sure I tested it > with previous version when I was fixing issues with FF-A as a module. > > Not sure if I am missing something in my steps. > OK, more info, indeed I didn't observe this issue 2 weeks back with optee at commit 57e642f12085 ("core: enable system PTA upon user TA support"). The UUID(d96a5b40-c3e5-21e3-8794-1002a5d5c61b) wasn't enumerated with above commit. Today I am testing the latest commit 2de2880065f3 ("core: update reference link to PrimeCell Cache Controller"). Though it looks like an issue with the driver, the latest optee changes triggered the driver to hit this issue in my setup. Hope this helps. IIUC we are not undoing optee_register_device executed via optee_enumerate_devices in the exit path. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel