public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: John Stultz <john.stultz@linaro.org>
To: lkml <linux-kernel@vger.kernel.org>
Cc: John Stultz <john.stultz@linaro.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Amit Pundir <amit.pundir@linaro.org>,
	Caleb Connolly <caleb.connolly@linaro.org>,
	Kalle Valo <kvalo@codeaurora.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	linux-arm-msm <linux-arm-msm@vger.kernel.org>
Subject: [RFC][PATCH] iommu: Kconfig: Fix missing config option for CONFIG_ARM_SMMU_QCOM
Date: Tue, 12 Oct 2021 03:26:33 +0000	[thread overview]
Message-ID: <20211012032633.4169364-1-john.stultz@linaro.org> (raw)

In commit 424953cf3c665 ("qcom_scm: hide Kconfig symbol"), some
logic was added to make the code depend on CONFIG_ARM_SMMU_QCOM,
however no such option exist.

This caused regressions on db845c (and I suspect other qcom
platforms), but can be easily fixed up by adding a new option
to re-enable the newly conditionalized code.

I set it to default to ARCH_QCOM, so folks don't have to
discover this new option to keep things booting, but if folks
would rather, I'm ok to drop that line.

Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Amit Pundir <amit.pundir@linaro.org>
Cc: Caleb Connolly <caleb.connolly@linaro.org>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Cc: linux-arm-msm <linux-arm-msm@vger.kernel.org>
Fixes: 424953cf3c665 ("qcom_scm: hide Kconfig symbol")
Signed-off-by: John Stultz <john.stultz@linaro.org>
---
 drivers/iommu/Kconfig | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig
index c5c71b7ab7e83..e674796b1174d 100644
--- a/drivers/iommu/Kconfig
+++ b/drivers/iommu/Kconfig
@@ -380,6 +380,16 @@ config ARM_SMMU_V3_SVA
 	  Say Y here if your system supports SVA extensions such as PCIe PASID
 	  and PRI.
 
+config ARM_SMMU_QCOM
+	bool "QCOM Specific ARM SMMU implementation support"
+	depends on ARM_SMMU
+	default ARCH_QCOM
+	help
+          Support for the QCOM implementation of the ARM System MMU architecture.
+
+          Say Y here if your SoC includes an QCOM IOMMU device implementing
+          the ARM SMMU architecture.
+
 config S390_IOMMU
 	def_bool y if S390 && PCI
 	depends on S390 && PCI
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

             reply	other threads:[~2021-10-12  3:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-12  3:26 John Stultz [this message]
2021-10-12  3:37 ` [RFC][PATCH] iommu: Kconfig: Fix missing config option for CONFIG_ARM_SMMU_QCOM Bjorn Andersson
2021-10-12  3:51   ` John Stultz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211012032633.4169364-1-john.stultz@linaro.org \
    --to=john.stultz@linaro.org \
    --cc=amit.pundir@linaro.org \
    --cc=arnd@arndb.de \
    --cc=bjorn.andersson@linaro.org \
    --cc=caleb.connolly@linaro.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox