From: Horatiu Vultur <horatiu.vultur@microchip.com>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: <robh+dt@kernel.org>, <andrew@lunn.ch>,
<lars.povlsen@microchip.com>, <Steen.Hegelund@microchip.com>,
<UNGLinuxDriver@microchip.com>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 1/2] dt-bindings: reset: Add lan966x support
Date: Tue, 12 Oct 2021 16:40:52 +0200 [thread overview]
Message-ID: <20211012144052.pmn4u3s2j27itwxe@soft-dev3-1.localhost> (raw)
In-Reply-To: <91ae922d66b4b8c521142c8030bdd1a9f6d2fad1.camel@pengutronix.de>
The 10/12/2021 15:35, Philipp Zabel wrote:
Hi Philipp,
>
> Hi Horatiu,
>
> On Tue, 2021-10-12 at 13:42 +0200, Horatiu Vultur wrote:
> > This adds support for lan966x.
> >
> > Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> > ---
> > .../devicetree/bindings/reset/microchip,rst.yaml | 14 +++++++++++++-
> > 1 file changed, 13 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/reset/microchip,rst.yaml b/Documentation/devicetree/bindings/reset/microchip,rst.yaml
> > index 370579aeeca1..622cf3d0455d 100644
> > --- a/Documentation/devicetree/bindings/reset/microchip,rst.yaml
> > +++ b/Documentation/devicetree/bindings/reset/microchip,rst.yaml
> > @@ -20,7 +20,11 @@ properties:
> > pattern: "^reset-controller@[0-9a-f]+$"
> >
> > compatible:
> > - const: microchip,sparx5-switch-reset
> > + oneOf:
> > + - items:
> > + - const: microchip,sparx5-switch-reset
> > + - items:
> > + - const: microchip,lan966x-switch-reset
> >
> > reg:
> > items:
> > @@ -37,6 +41,14 @@ properties:
> > $ref: "/schemas/types.yaml#/definitions/phandle"
> > description: syscon used to access CPU reset
> >
> > + cuphy-syscon:
> > + $ref: "/schemas/types.yaml#/definitions/phandle"
> > + description: syscon used to access CuPHY
> > +
> > + gpios:
>
> From the description I'd expect this to be called phy-reset-gpios.
Yes, I can rename this.
>
> > + description: used for release of reset of the external PHY
> > + maxItems: 1
> > +
>
> Shouldn't an external PHY be described as a separate DT node, with its
> own reset gpio?
I am not sure, this is more board specific than PHY specific. On lan966x
ung8290 board, the external PHYs are kept in reset until this GPIO is toggled.
>
> regards
> Philipp
--
/Horatiu
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-10-12 14:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-12 11:42 [PATCH v2 0/2] Extend Sparx5 switch reset driver for lan966x Horatiu Vultur
2021-10-12 11:42 ` [PATCH v2 1/2] dt-bindings: reset: Add lan966x support Horatiu Vultur
2021-10-12 13:35 ` Philipp Zabel
2021-10-12 14:40 ` Horatiu Vultur [this message]
2021-10-12 11:42 ` [PATCH v2 2/2] reset: mchp: sparx5: Extend support for lan966x Horatiu Vultur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211012144052.pmn4u3s2j27itwxe@soft-dev3-1.localhost \
--to=horatiu.vultur@microchip.com \
--cc=Steen.Hegelund@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=lars.povlsen@microchip.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).