From: Sudeep Holla <sudeep.holla@arm.com>
To: Sumit Garg <sumit.garg@linaro.org>
Cc: op-tee@lists.trustedfirmware.org, jens.wiklander@linaro.org,
jerome@forissier.org, daniel.thompson@linaro.org,
maxim.uvarov@linaro.org, linux-arm-kernel@lists.infradead.org,
Sudeep Holla <sudeep.holla@arm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tee: optee: Fix missing devices unregister during optee_remove
Date: Tue, 12 Oct 2021 19:03:48 +0100 [thread overview]
Message-ID: <20211012180348.zalanzdw3ykqg4db@bogus> (raw)
In-Reply-To: <20211012073116.4156054-1-sumit.garg@linaro.org>
On Tue, Oct 12, 2021 at 01:01:16PM +0530, Sumit Garg wrote:
> When OP-TEE driver is built as a module, OP-TEE client devices
> registered on TEE bus during probe should be unregistered during
> optee_remove. So implement optee_unregister_devices() accordingly.
>
> Fixes: c3fa24af9244 ("tee: optee: add TEE bus device enumeration support")
> Reported-by: Sudeep Holla <sudeep.holla@arm.com>
> Signed-off-by: Sumit Garg <sumit.garg@linaro.org>
> ---
> drivers/tee/optee/core.c | 3 +++
> drivers/tee/optee/device.c | 22 ++++++++++++++++++++++
> drivers/tee/optee/optee_private.h | 1 +
> 3 files changed, 26 insertions(+)
>
> diff --git a/drivers/tee/optee/core.c b/drivers/tee/optee/core.c
> index ccad3c7c8f6d..3915dc574503 100644
> --- a/drivers/tee/optee/core.c
> +++ b/drivers/tee/optee/core.c
> @@ -586,6 +586,9 @@ static int optee_remove(struct platform_device *pdev)
> {
> struct optee *optee = platform_get_drvdata(pdev);
>
> + /* Unregister OP-TEE specific client devices on TEE bus */
> + optee_unregister_devices();
> +
This is not based on FF-A support series by Jens I assume. I added
optee_unregister_devices to optee_remove_common and that fixes the issue
I reported. I haven't followed the comments by Jens on the approach yet.
--
Regards,
Sudeep
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-10-12 18:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-12 7:31 [PATCH] tee: optee: Fix missing devices unregister during optee_remove Sumit Garg
2021-10-12 7:59 ` Jens Wiklander
2021-10-12 8:27 ` Sumit Garg
2021-10-13 12:26 ` Jens Wiklander
2021-10-12 18:03 ` Sudeep Holla [this message]
2021-10-13 6:00 ` Sumit Garg
2021-10-13 12:27 ` Jens Wiklander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211012180348.zalanzdw3ykqg4db@bogus \
--to=sudeep.holla@arm.com \
--cc=daniel.thompson@linaro.org \
--cc=jens.wiklander@linaro.org \
--cc=jerome@forissier.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxim.uvarov@linaro.org \
--cc=op-tee@lists.trustedfirmware.org \
--cc=sumit.garg@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox