From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83666C433F5 for ; Wed, 13 Oct 2021 12:45:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5516160D07 for ; Wed, 13 Oct 2021 12:45:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5516160D07 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Koqaxk+zK+STIgqxJxSYiZHfOLjaOQC65AakxsCWhSA=; b=JEYeWdrSw6YAP/ 3zemoua1qIXt312bNLDZEJeVFRhR1CBMS1pLmsPUkiQ4bsyB57sewUKvqJQ684XITma+w+dlneCxO XWGyyxUqm0tcaelujWutu886jonPHtBdrZ4mal7wcqZwrMr77ebAYkCKMjQa5NfNzF8sNz5ZgrC3V t2Ozz6+3L3gGZPBeU6wet00gzujWG/nl/oCrvwDfQyywPDHPetE18EQ5PDbLEjXcb8UwwlZPLsQem eCrXzXu6vBwi0/p0R85r8M8KBlW1nscK+/f/SIyQyzlWA5OIWr8+w9Nyadl8yF2FD1UtDshnLlwjI SVbv6WvIp7ITCw5UqNpw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1madbH-00GdvT-GC; Wed, 13 Oct 2021 12:43:16 +0000 Received: from esa.microchip.iphmx.com ([68.232.153.233]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1maccJ-00GMqe-UH for linux-arm-kernel@lists.infradead.org; Wed, 13 Oct 2021 11:40:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1634125217; x=1665661217; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=gIJaKWc3mhoqjpjyoYXjqJKzdlBFVRY8Zq/+CGn0tEE=; b=Mx7R6EpGG2yexjTWPgP9uEs3zlqvWMqIdbIVCygeVwPEGlMVB2esgh92 TEvirF0NCSGlYPAq/if0epcLkBomwbFsZ1FJxBvnBxPVfuuIeplocUeeG VTXW5gnEi3aKoYYYJApbSFezq6LV9U74y+XEGjdnAZRSlFr3c25b9U3T+ 4hZ4WU+SrCc/Y2NMybtPUS/EZIpRuBYzjsOmU0BktMwOHubEGEjgpZDR2 R1DlguH/pzceSs6qchrYT+WIY/rZ6W1X4NTMxIxvxuLl0rMMJhyAJhitf OuXARS+9P+saSHtdxg348Nl3J267/LM7fDb8glh6ESqWlszsOX5sC98nm Q==; IronPort-SDR: gVgmCvWJ9ecNKu3wuehcCZQzhMW/7yJY52kQ+bFrZme95ab1USK5qJuZn7/b65LJ6L0Fzhc0Vq 1d6yQc9q6JSUYGa006jwIKW1GmUHauZMppditai1biTGLHXexH4SgrIlT7mEPqawnwtDlUHYj4 rEawZM7bZXO2Jv4wa+ysS6Bg4M5aAUumwptP30+8Ihp+V4M52mXZmE9em70hS8jGUfpP4oxRMo 9qGNRfyy2Q2zNRjm1oElLR7KNUynY+jhJHYndB9orr7yfCsveZ42trXMmVfZZc59yOJ8dkphQV //LQIUhwz8GplLmfQJ9zfq5M X-IronPort-AV: E=Sophos;i="5.85,370,1624345200"; d="scan'208";a="139556124" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa5.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 13 Oct 2021 04:40:13 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.85.144) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Wed, 13 Oct 2021 04:40:11 -0700 Received: from localhost (10.10.115.15) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Wed, 13 Oct 2021 04:40:11 -0700 Date: Wed, 13 Oct 2021 13:41:44 +0200 From: Horatiu Vultur - M31836 To: Codrin Ciubotariu - M19940 Subject: Re: [PATCH 0/2] i2c: at91: Add support for programmable clock source Message-ID: <20211013114144.7j4scdaq2rjfmiwn@soft-dev3-1.localhost> References: <20211012140718.2138278-1-horatiu.vultur@microchip.com> <8a775c67-00a3-1dbe-daa3-09a537f482d8@microchip.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8a775c67-00a3-1dbe-daa3-09a537f482d8@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211013_044016_035180_E2403D37 X-CRM114-Status: GOOD ( 20.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , "alexandre.belloni@bootlin.com" , "linux-kernel@vger.kernel.org" , Ludovic Desroches - M43218 , "robh+dt@kernel.org" , "linux-i2c@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The 10/13/2021 08:49, Codrin Ciubotariu - M19940 wrote: > On 12.10.2021 17:07, Horatiu Vultur wrote: > > Add support to be able to set BRSRCCLK. This feature is support on lan966x > > > > Horatiu Vultur (2): > > dt-bindings: i2c: at91: Extend compatible list for lan966x > > i2c: at91: add support for brsrcclk > > > > .../devicetree/bindings/i2c/i2c-at91.txt | 6 +++-- > > drivers/i2c/busses/i2c-at91-core.c | 16 +++++++++++++ > > drivers/i2c/busses/i2c-at91-master.c | 23 +++++++++++++++++-- > > drivers/i2c/busses/i2c-at91.h | 1 + > > 4 files changed, 42 insertions(+), 4 deletions(-) > > > > Hi Horatiu, Hi Codrin, > > From what I understand, on your DTS, you replaced the peripheral clock > with the GCLK in the I2C node. This means that you are forcing all the > variants that support clk_brsrcclk to treat the current clock as GCLK. > This is not necessarily correct, since this newer variants can also work > fine with only the peripheral clock and we should keep these option > available. > > I would add an optional GCLK clock binding in the I2C node. This way > GCLK will be used only if it is present in DT and clk_brsrcclk set. Thanks for the explanation. I think actually I will drop this patch series because apparently lan966x works fine also with the peripheral clock. So then no changes are required. If you think is worth it, I can do another version with the proposed changes. > > Best regards, > Codrin -- /Horatiu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel