From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDB16C433F5 for ; Thu, 14 Oct 2021 16:12:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7E760600EF for ; Thu, 14 Oct 2021 16:12:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7E760600EF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=loWIPuGe0mS9kR0qnaJ/7iWtWM0mXRxYKuVwkK2BX7Y=; b=ET4VgUQTnER/jK BCeSnn6tnM2ToZOfQjwggeaGSg8TuGRi5qkFkbNNBZt/6B5J8zhBHMVN1P2XuYDL49jPWzemGDQj9 z/awiFlRtonJIGt3VB49LGyPx63X9q8V6l7TOULP2O+ZfeIOGKs3b7D/cEu/cHuB3s6AINt2PH2FU XNVvjI2U48Kdph4qPsu8H0muP//5YHyjg1OwiEgjegDIveP20bC0s5LnUYeQ+nZ9/ajQYk7Iz9za1 9BHJR1+79A4XBcjq20Xx9HTsSHe+Zcra62lqmMFsdn8brwDjy2Jg/aoGnRlEBrtNRtcdhnCNMRPid pcZYvVvMMeXx0whhjegA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mb3Jq-003nbK-4N; Thu, 14 Oct 2021 16:10:58 +0000 Received: from mail-pg1-x530.google.com ([2607:f8b0:4864:20::530]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mb3Jl-003naB-Ps for linux-arm-kernel@lists.infradead.org; Thu, 14 Oct 2021 16:10:55 +0000 Received: by mail-pg1-x530.google.com with SMTP id 133so6004708pgb.1 for ; Thu, 14 Oct 2021 09:10:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=BWS52dql+ajKsVGzTwJ00TvBktdComipttyL2oNuCUA=; b=sgo2JFiKekAgFg2ykYeltwB/Fsj+4+LoUN3qyXiTzbhETyJAtuzFRBfn2cZFtCJLYD Ww0LHEKVXCN19dMW27H7oETvQjTySlLeBRTilHKJUTuSaIuBlfHMYQOaVFnEN+sLvqsg vstoadWRFJGTjDUBemqdAGv33z9jm6L2k8jqgsYr8g7m/aDHXEnsYQOP6sVeUCQ5DeYs QuXdv8fdnU4wzib7JjSl5RB+Aow/LCAHkaF6rQXykxcQB56PRh5YuD6ZtReQiOrGnfdy 8lfXufISo8qUCLoHUK/FW9PX2ZuXxWdaChqrAdoDnsBa/960uo8o0hMG2LhjnW0o3QOT q0IQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=BWS52dql+ajKsVGzTwJ00TvBktdComipttyL2oNuCUA=; b=xYfciYxLDNLo3iQ2C0YU8tlK6YeEsKFkOlPH2HNCx+r17QfK6FYcmD/JkQCT5LsfKc b/h49+3UqI95ac/4twEIEl8AEsWsNR5zPupmHg5i/rHQQhldUOY9+DYFKbPCKftP4yUZ V5oInGRYz69S/5rCHwU4sBkC8Znv2mZFfEcL2Qb1DugOrfemwp/Yh2Hl2ElZKh2aLM6L dt7/B7mK13Rea45LatuMUt1eNRVVXljgnLyqxLlkEXSL1VRiPp1rwvSG4rn5S/hkleuC 85jJIDzEChPb8xsBMEab1uDdOgMRiG2YBjyvaB3jvS1rJWnA85+Coq87yNFxBazZgdzj ay/A== X-Gm-Message-State: AOAM530uVSkAAQ/eb3A6DskVJkwBnh4w6cnmP2Va2BJ7kIYUV0V3lNdO yjIH3U7FTKqlSVxlvth0XjrOnw== X-Google-Smtp-Source: ABdhPJzpYqMNKRQchBTM3b76cveOWAI9PjBSkypDO3jKlwMXS3Yau7rxWQtIpFXM7PNYB5zfArVjjw== X-Received: by 2002:a63:1d10:: with SMTP id d16mr4805233pgd.13.1634227850721; Thu, 14 Oct 2021 09:10:50 -0700 (PDT) Received: from p14s (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id d19sm2843113pfn.102.2021.10.14.09.10.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Oct 2021 09:10:48 -0700 (PDT) Date: Thu, 14 Oct 2021 10:10:46 -0600 From: Mathieu Poirier To: Arnd Bergmann Cc: Ohad Ben-Cohen , Bjorn Andersson , Shawn Guo , Sascha Hauer , Shengjiu Wang , Arnd Bergmann , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] remoteproc: imx_dsp_rproc: mark PM functions as __maybe_unused Message-ID: <20211014161046.GA2847733@p14s> References: <20211014075239.3714694-1-arnd@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211014075239.3714694-1-arnd@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211014_091053_873836_0570C242 X-CRM114-Status: GOOD ( 19.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 14, 2021 at 09:52:24AM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > When CONFIG_PM_SLEEP is disabled, we get a harmless warning: > > drivers/remoteproc/imx_dsp_rproc.c:1145:12: error: 'imx_dsp_resume' defined but not used [-Werror=unused-function] > 1145 | static int imx_dsp_resume(struct device *dev) > | ^~~~~~~~~~~~~~ > drivers/remoteproc/imx_dsp_rproc.c:1110:12: error: 'imx_dsp_suspend' defined but not used [-Werror=unused-function] > 1110 | static int imx_dsp_suspend(struct device *dev) > | ^~~~~~~~~~~~~~~ > > Mark these as __maybe_unused to get a clean build. > > Fixes: ec0e5549f358 ("remoteproc: imx_dsp_rproc: Add remoteproc driver for DSP on i.MX") > Signed-off-by: Arnd Bergmann > --- > drivers/remoteproc/imx_dsp_rproc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) I have applied this. Thanks, Mathieu > > diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_dsp_rproc.c > index 63749cfcf22f..90fcb389e252 100644 > --- a/drivers/remoteproc/imx_dsp_rproc.c > +++ b/drivers/remoteproc/imx_dsp_rproc.c > @@ -1107,7 +1107,7 @@ static void imx_dsp_load_firmware(const struct firmware *fw, void *context) > release_firmware(fw); > } > > -static int imx_dsp_suspend(struct device *dev) > +static __maybe_unused int imx_dsp_suspend(struct device *dev) > { > struct rproc *rproc = dev_get_drvdata(dev); > struct imx_dsp_rproc *priv = rproc->priv; > @@ -1142,7 +1142,7 @@ static int imx_dsp_suspend(struct device *dev) > return pm_runtime_force_suspend(dev); > } > > -static int imx_dsp_resume(struct device *dev) > +static __maybe_unused int imx_dsp_resume(struct device *dev) > { > struct rproc *rproc = dev_get_drvdata(dev); > int ret = 0; > -- > 2.29.2 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel