From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACD68C433F5 for ; Fri, 15 Oct 2021 04:10:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 70BFB6058D for ; Fri, 15 Oct 2021 04:10:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 70BFB6058D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=T8d8VspF4i7MuAgvhCgpZ3Qis51V6Yr7XNtIjUzZaI4=; b=BcijKwMYPYnTBA 5HAbSvXoQ8wker/IoNf2v9j5KQQ9bvK2gdg0yZyPWRNFaL2zT6Ayj31AqBHIDTYOuoiT0LHeMrhFv qPom55foHbeq5IC5aSz7RDcktmOeMxYUTLma0dTI22bA5Yjq+rzPqHNp1HiWIh0RgONiaEl1u9Pet zxTA74f38RXRhjiQaohQ81UQGc1WILkKRyEmvLldxfeE91SQarn3nGyo7FO7zo7LuuDQZQKcOtKnU HW5p0BWS1nCKBey/y4FAYacKgfwQ9GyPjtfgd/Rifi/oJ63HnzK+TTsraiLrbjufPp83Cl1a55qJo xfQ9jv5jsX5VqNo9G1vw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mbEWx-005NbR-Ss; Fri, 15 Oct 2021 04:09:16 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mbEWu-005Nax-F5 for linux-arm-kernel@lists.infradead.org; Fri, 15 Oct 2021 04:09:13 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id BECF56058D; Fri, 15 Oct 2021 04:09:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634270951; bh=9wYm3/Ll/jdCBRIBMa/tBI8ZuMw1Bu4NWha2opzSxxs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qnmgFXiUhKMpnzEMW25QN3ISvoR/hFcdtG9WibPtzTgAEwCOGBoTRKX6+AEFVJeOE Wa7lrGomgZKJv8uA3WTt/VyFmOFDOAichm8mU+YoUzjHjKUH+YnWa/CWJbzEW9gsFO jGtostUbsgEh5rjWd/F2opcNMKaNFKk+Z+N3bWkBpPyKWTV0uDmxWOJpR/3+EsXr7e bmiAzgiqM//+4ZQolnROtYThQ1oROfe2iYcR+K5ad3OBmmdVtUWg8OpeTw/avcbTHa Xk4wBzeqINZfx1x6v91ezroeFoWNcQH3DAlsLiCHuREfqD3yR1bYMWIREw1YaYokO/ z0Gp54GQ8p6UA== Date: Fri, 15 Oct 2021 12:09:05 +0800 From: Shawn Guo To: Frieder Schrempf Cc: Frieder Schrempf , devicetree@vger.kernel.org, Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Rob Herring , Sascha Hauer , stable@vger.kernel.org, Fabio Estevam , NXP Linux Team , Pengutronix Kernel Team Subject: Re: [PATCH 4/8] arm64: dts: imx8mm-kontron: Fix reg_rst_eth2 and reg_vdd_5v regulators Message-ID: <20211015040904.GG22881@dragon> References: <20210930155633.2745201-1-frieder@fris.de> <20210930155633.2745201-5-frieder@fris.de> <20211005070949.GB20743@dragon> <725cc24e-f264-60ea-e30c-c50a61f7fe88@kontron.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <725cc24e-f264-60ea-e30c-c50a61f7fe88@kontron.de> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211014_210912_568206_1DAB5601 X-CRM114-Status: GOOD ( 31.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 05, 2021 at 07:06:57PM +0200, Frieder Schrempf wrote: > On 05.10.21 09:09, Shawn Guo wrote: > > On Thu, Sep 30, 2021 at 05:56:27PM +0200, Frieder Schrempf wrote: > >> From: Frieder Schrempf > >> > >> The regulator reg_vdd_5v represents the fixed 5V supply on the board which > >> can't be switched off. Mark it as always-on. > >> > >> The regulator reg_rst_eth2 should keep the reset signal of the USB ethernet > >> adapter deassertet anytime. Fix the polarity and mark it as always-on. > > > > It seems to be wrong from the beginning that the reset is modelled by a > > regulator. > > Right, but at least at the time when I upstreamed this, there was no way > to pass the reset GPIO to a USB device driver and using a regulator > seems to be an accepted workaround as far as I understand. Do we have the solution in usb driver now? If so, we should probably switch to that, instead of patching the workaround? Shawn > > > > >> > >> Fixes: 21c4f45b335f ("arm64: dts: Add the Kontron i.MX8M Mini SoMs and baseboards") > >> Cc: stable@vger.kernel.org > >> Signed-off-by: Frieder Schrempf > >> --- > >> arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts | 5 ++++- > >> 1 file changed, 4 insertions(+), 1 deletion(-) > >> > >> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts > >> index 62ba3bd08a0c..f2c8ccefd1bf 100644 > >> --- a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts > >> +++ b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts > >> @@ -70,7 +70,9 @@ reg_rst_eth2: regulator-rst-eth2 { > >> regulator-name = "rst-usb-eth2"; > >> pinctrl-names = "default"; > >> pinctrl-0 = <&pinctrl_usb_eth2>; > >> - gpio = <&gpio3 2 GPIO_ACTIVE_LOW>; > >> + gpio = <&gpio3 2 GPIO_ACTIVE_HIGH>; > >> + enable-active-high; > >> + regulator-always-on; > >> }; > >> > >> reg_vdd_5v: regulator-5v { > >> @@ -78,6 +80,7 @@ reg_vdd_5v: regulator-5v { > >> regulator-name = "vdd-5v"; > >> regulator-min-microvolt = <5000000>; > >> regulator-max-microvolt = <5000000>; > >> + regulator-always-on; > > > > You do not have any on/off control over the regulator. So how does this > > always-on property make any difference? > > Right, this doesn't make a difference and is definitely not a fix, I > will drop it. Anyway, this regulator is just there for completeness of > the hardware description. > > > > >> }; > >> }; > >> > >> -- > >> 2.33.0 > >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel