From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D642DC433F5 for ; Fri, 15 Oct 2021 14:32:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 99F0060E09 for ; Fri, 15 Oct 2021 14:32:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 99F0060E09 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3jCB0STCxbNi5CT6igA2VwiC0hYVaTzZ6HqY5gVEdTg=; b=kVCFGwbBbvpWMJ w1FRs3OzKUIY2cf0nedWM9t1UujmLgLDtlWb7YRoPANoIAfGcIY/73z0P2Q60pcUfnpr2xygPjVrM GRzVWq+EUFyf1Ba6aqm63REe4LQdMIkyn06ozUJMWMRN21kQCNuvMFsItxZMhI5aAjWCG2kKEirkC XDtn2aYW/wS7Nn+2orIxhAA7m6SIjNLZbKxuZlRDIkSmAIUvb37fxydklJODIg/dqT50qAUNRjG5Z YWj1N8mjI5vT6QDwd4BgZ7VbDlHsDaRWZqxZrKD0NLGhox++o259/0Zv5/fwPDyu4lo/7of4GqHS2 Cf7pelo6fMTa2sMCAg6A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mbOE2-007bol-Ik; Fri, 15 Oct 2021 14:30:23 +0000 Received: from mail-pg1-x536.google.com ([2607:f8b0:4864:20::536]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mbO0N-007VsJ-0t for linux-arm-kernel@lists.infradead.org; Fri, 15 Oct 2021 14:16:16 +0000 Received: by mail-pg1-x536.google.com with SMTP id 75so8757399pga.3 for ; Fri, 15 Oct 2021 07:16:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=cQSzYDsggFl8upEXTgG7vVR8z62QkXf5gqGOcLIHjKU=; b=PssTITKzkxd85I31lnbK8Qyd73nN6bTOOJVVoXTE9dvERrfkP18XLbw0lx8tCBqrEA M8QMbXwKY9XT3GoEM1gJvF4+5DL4rrjMuJKcVNukCOM1HfTawPUNxZVzjPyIuY0PAGDK s1JtlONXeEAg+ZHhq0bDSRbXFwmTAZ6TH8CHrRChf2phLcQFsnQSHyNEFpRBwuPTsz+9 FCfxs0CClDQkS/a6aONvB75KEX+KhKeK465GvX+Y2+29O6m3TUmK95wnoPK+tyQeJxk1 F+Zkv1LGtV6b09o/enW7PEhnbhCfbc3LKUQBuvEAMx76bjUYbPs6pHcmeRezXKZajbVu 1naQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=cQSzYDsggFl8upEXTgG7vVR8z62QkXf5gqGOcLIHjKU=; b=mNjTzuha/PAASfHS+BIo7FCvkjaGiV8hTHvowMJgO/Gw+0IWMdGvJd7ZJNMO3Ebbuq LkzilsHhY1v4Dfzrvo+iVN2c4MP9MXgY6bzb4OkhfOYLxF7Rr4hDEqn4uiTjiwzRw+k2 RFfzc/GKPEMxBC61INlSYRm6L9FrJflDjtnx2075t19DTqlvk5WrXFhhLnBuMsqBUzUV bwuq8Cswi8EZBNutn1VKahjOtWM3HEP3bIipYsRE7hNNEPm3BhgnBk2W/HqtELcbbRhO T/eBK8qCFNJVuf1aAcmVl6k7otxnsorVkwrreWEQ5Kt3FQ+OhVhO4+HTDolmfhCpYdJD JGpA== X-Gm-Message-State: AOAM532xgnG5XufHdmsi99Gr6dIolbUK7wXvaPZhou5XsqaHMIstGC5p zdkcGHbS6uHRCJRaLofuzk/5aw== X-Google-Smtp-Source: ABdhPJyPAWpWo3XYeTjPeOZKWB1JZNg/wgaZ79old44NbH90CBBxxA99HJEp2zv6WP0pJ73o5gmGug== X-Received: by 2002:a62:7506:0:b0:44c:efe8:4167 with SMTP id q6-20020a627506000000b0044cefe84167mr12018725pfc.59.1634307372973; Fri, 15 Oct 2021 07:16:12 -0700 (PDT) Received: from leoy-ThinkPad-X240s (23.83.225.140.16clouds.com. [23.83.225.140]) by smtp.gmail.com with ESMTPSA id c12sm4973471pgw.39.2021.10.15.07.16.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Oct 2021 07:16:12 -0700 (PDT) Date: Fri, 15 Oct 2021 22:16:01 +0800 From: Leo Yan To: German Gomez Cc: Will Deacon , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, John Garry , Mathieu Poirier , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Mike Leach , linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org, James Clark Subject: Re: [PATCH 4/5] perf arm-spe: Implement find_snapshot callback Message-ID: <20211015141601.GA66946@leoy-ThinkPad-X240s> References: <20210923135016.GG400258@leoy-ThinkPad-X240s> <20210923144048.GB603008@leoy-ThinkPad-X240s> <1c6a3a73-27dc-6673-7fe7-34bc7fcb0a68@arm.com> <20211004122724.GC174271@leoy-ThinkPad-X240s> <6b092f13-832f-5d1d-a504-aea96c81bf17@arm.com> <20211006095124.GC14400@leoy-ThinkPad-X240s> <377b54ef-b9c0-9cfc-ef0c-0187d7c493cc@arm.com> <20211013003916.GA130842@leoy-ThinkPad-X240s> <20211013075125.GA6701@willie-the-truck> <35209d5c-6387-5248-ab61-a1e1cb0553de@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <35209d5c-6387-5248-ab61-a1e1cb0553de@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211015_071615_115627_A4BB0A56 X-CRM114-Status: GOOD ( 20.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi German, On Fri, Oct 15, 2021 at 01:33:39PM +0100, German Gomez wrote: > Hi Leo, > > Would you be ok with the current patch the way it is? Sorry for my failure to catch up the discussion. As you and Will have mentioned in other emails that it will lead to breakage if we change to monotonical increasing head, I read the code and realized the difficulty to use monotonical increasing head in Arm SPE driver. So let's use the way as this patch set is. > In case it's of > any help, I'm sharing the testing steps that James and I went through > when testing this internally, if you want to add to it > > - Test that only a portion of the buffer is saved until there is a wraparound > > $ ./perf record -vvv -e arm_spe/period=148576/u -S -- taskset --cpu-list 0 stress --cpu 1 & while true; do sleep 0.2; killall -s USR2 perf; done > > - Test snapshot mode in CPU mode > > $ sudo ./perf record -vvv -C 0 -e arm_spe/period=148576/u -S -- taskset --cpu-list 0 stress --cpu 1 & > > - Test that auxtrace buffers correspond to an aux record > - Test snapshot default sizes in sudo and user modes > - Test small snapshot size > > $ ./perf record -vvv -e arm_spe/period=148576/u -S1000 -m16,16 -- taskset --cpu-list 0 stress --cpu 1 & > > If there are any concerns with the patches, please let me know and I > will try to address them. Thanks for sharing the testing cases. Could give me a bit more time for the test at my side? And please expect I might give some comments if I think it's necessary. Thanks, Leo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel