From: "Gustavo A. R. Silva" <gustavoars@kernel.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: jing yangyang <cgel.zte@gmail.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Sudeep Holla <sudeep.holla@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
jing yangyang <jing.yangyang@zte.com.cn>,
Zeal Robot <zealci@zte.com.cn>,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH linux-next] firmware/psci: fix application of sizeof to pointer
Date: Sat, 16 Oct 2021 13:10:03 -0500 [thread overview]
Message-ID: <20211016181003.GA1193402@embeddedor> (raw)
In-Reply-To: <20210824105824.GC96738@C02TD0UTHF1T.local>
On Tue, Aug 24, 2021 at 11:58:24AM +0100, Mark Rutland wrote:
> On Thu, Aug 19, 2021 at 07:30:16PM -0700, jing yangyang wrote:
> > sizeof when applied to a pointer typed expression gives the size of
> > the pointer.
> >
> > ./drivers/firmware/psci/psci_checker.c:158:41-47: ERROR application of sizeof to pointer
> >
> > This issue was detected with the help of Coccinelle.
> >
> > Reported-by: Zeal Robot <zealci@zte.com.cn>
> > Signed-off-by: jing yangyang <jing.yangyang@zte.com.cn>
>
> >From looking at the git history, we should add:
>
> Fixes: 7401056de5f8d4ea ("drivers/firmware: psci_checker: stash and use topology_core_cpumask for hotplug tests)"
>
> With that:
>
> Acked-by: Mark Rutland <mark.rutland@arm.com>
>
> Lorenzo, how do we normally direct these patches?
It seems that these patches are consistently being ignored[1][2][3]. So,
I'll take this in my -next tree[4] before it gets lost again.
Thanks
--
Gustavo
[1] https://lore.kernel.org/lkml/20200917081353.2083241-1-liushixin2@huawei.com/
[2] https://lore.kernel.org/lkml/1606179525-63938-1-git-send-email-tiantao6@hisilicon.com/
[3] https://lore.kernel.org/lkml/20211012024229.180058-1-davidcomponentone@gmail.com/
[4] https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git/log/?h=for-next/kspp-misc-fixes
>
>
> > ---
> > drivers/firmware/psci/psci_checker.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/firmware/psci/psci_checker.c b/drivers/firmware/psci/psci_checker.c
> > index 9a369a2..116eb46 100644
> > --- a/drivers/firmware/psci/psci_checker.c
> > +++ b/drivers/firmware/psci/psci_checker.c
> > @@ -155,7 +155,7 @@ static int alloc_init_cpu_groups(cpumask_var_t **pcpu_groups)
> > if (!alloc_cpumask_var(&tmp, GFP_KERNEL))
> > return -ENOMEM;
> >
> > - cpu_groups = kcalloc(nb_available_cpus, sizeof(cpu_groups),
> > + cpu_groups = kcalloc(nb_available_cpus, sizeof(*cpu_groups),
> > GFP_KERNEL);
> > if (!cpu_groups) {
> > free_cpumask_var(tmp);
> > --
> > 1.8.3.1
> >
> >
>
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-10-16 18:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 2:30 [PATCH linux-next] firmware/psci: fix application of sizeof to pointer jing yangyang
2021-08-24 10:58 ` Mark Rutland
2021-10-16 18:10 ` Gustavo A. R. Silva [this message]
2021-10-18 13:54 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211016181003.GA1193402@embeddedor \
--to=gustavoars@kernel.org \
--cc=cgel.zte@gmail.com \
--cc=jing.yangyang@zte.com.cn \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=sudeep.holla@arm.com \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).